Re: [PATCH 1/3] media: imx: add capture compose rectangle

[Philipp Zabel <p.zabel@pengutronix.de>]

Hi Steve,

thank you for the review.

On Thu, 2018-11-08 at 21:33 -0800, Steve Longerbeam wrote:
[...]
> > --- a/drivers/staging/media/imx/imx-media-capture.c
> > +++ b/drivers/staging/media/imx/imx-media-capture.c
> > @@ -262,6 +262,10 @@ static int capture_s_fmt_vid_cap(struct file *file, void *fh,
> >   	priv->vdev.fmt.fmt.pix = f->fmt.pix;
> >   	priv->vdev.cc = imx_media_find_format(f->fmt.pix.pixelformat,
> >   					      CS_SEL_ANY, true);
> > +	priv->vdev.compose.left = 0;
> > +	priv->vdev.compose.top = 0;
> > +	priv->vdev.compose.width = f->fmt.fmt.pix.width;
> > +	priv->vdev.compose.height = f->fmt.fmt.pix.height;
> 
> this should be:
> 
> priv->vdev.compose.width = fmt_src.format.width;
> priv->vdev.compose.height = fmt_src.format.height;
> 
> (corrected in the next patches but needs to be corrected here).

Thanks for catching this, it should be

+	priv->vdev.compose.width = f->fmt.pix.width;
+	priv->vdev.compose.height = f->fmt.pix.height;

though, fmt_src is only introduced in patch 2.

regards
Philipp