public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Steve Longerbeam <slongerbeam@gmail.com>, linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 2/3] media: imx: set compose rectangle to mbus format
Date: Fri, 09 Nov 2018 14:09:43 +0100	[thread overview]
Message-ID: <1541768983.4112.38.camel@pengutronix.de> (raw)
In-Reply-To: <3614b93e-feeb-a118-efda-e5265af24499@gmail.com>

On Thu, 2018-11-08 at 21:33 -0800, Steve Longerbeam wrote:
> Hi Philipp,
> 
> On 11/5/18 7:20 AM, Philipp Zabel wrote:
> > Prepare for mbus format being smaller than the written rectangle
> > due to burst size.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >   drivers/staging/media/imx/imx-media-capture.c | 55 +++++++++++++------
> >   1 file changed, 38 insertions(+), 17 deletions(-)
> > 
> > diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c
> > index cace8a51aca8..2d49d9573056 100644
> > --- a/drivers/staging/media/imx/imx-media-capture.c
> > +++ b/drivers/staging/media/imx/imx-media-capture.c
> > @@ -203,21 +203,14 @@ static int capture_g_fmt_vid_cap(struct file *file, void *fh,
> >   	return 0;
> >   }
> >   
> > -static int capture_try_fmt_vid_cap(struct file *file, void *fh,
> > -				   struct v4l2_format *f)
> > +static int __capture_try_fmt_vid_cap(struct capture_priv *priv,
> > +				     struct v4l2_subev_format *fmt_src,
> 
> 
> typo: struct v4l2_subdev_format *fmt_src,

Fixed, thanks.

[...]
> > 
> > +	return __capture_try_fmt(priv, &fmt_src, f);
> 
> 
> typo: return __capture_try_fmt_vid_cap(priv, &fmt_src, f);

And thanks. Looks like I've misplaced a fixup! patch.

regards
Philipp

  reply	other threads:[~2018-11-09 22:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 15:20 [PATCH 1/3] media: imx: add capture compose rectangle Philipp Zabel
2018-11-05 15:20 ` [PATCH 2/3] media: imx: set compose rectangle to mbus format Philipp Zabel
2018-11-09  5:33   ` Steve Longerbeam
2018-11-09 13:09     ` Philipp Zabel [this message]
2018-11-05 15:20 ` [PATCH 3/3] media: imx: lift CSI width alignment restriction Philipp Zabel
2018-11-09  5:46   ` Steve Longerbeam
2018-11-09 13:30     ` Philipp Zabel
2018-11-09 14:50     ` Philipp Zabel
2018-11-09 17:45       ` Steve Longerbeam
2018-11-06 14:01 ` [PATCH 1/3] media: imx: add capture compose rectangle Sakari Ailus
2018-11-06 14:44   ` Philipp Zabel
2018-11-07 11:45     ` Sakari Ailus
2018-11-09  5:33 ` Steve Longerbeam
2018-11-09 13:00   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541768983.4112.38.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-media@vger.kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox