From: "Hans Werner" <HWerner4@gmx.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media@vger.kernel.org, abraham.manu@gmail.com,
linux-dvb@linuxtv.org
Subject: [linux-dvb] [PATCH] [RESEND] stb6100: stb6100_init fix
Date: Thu, 08 Jan 2009 18:17:55 +0100 [thread overview]
Message-ID: <20090108171755.23040@gmx.net> (raw)
In-Reply-To: <20090108100149.2c6df55e@pedra.chehab.org>
> > Hi Mauro,
> > please look at the patch below.
> >
> > Signed-off-by: Hans Werner <hwerner4@gmx.de>
> >
> > Thanks,
> > Hans
> >
> > -------- Original-Nachricht --------
> > Datum: Mon, 05 Jan 2009 16:10:50 +0100
> > Von: "Hans Werner" <HWerner4@gmx.de>
> > An: linux-dvb@linuxtv.org
> > Betreff: [linux-dvb] [PATCH] stb6100: stb6100_init fix
> >
> > Two issues in stb6100_init : the call to stb6100_set_bandwidth needs an
> argument in Hz
> > not kHz, and a comment incorrectly says MHz instead of Hz. I don't know
> if this caused
> > real problems anywhere.
> >
> > This patch is for v4l-dvb, but it is also needs to be fixed in
> s2-liplianin.
> >
> > ...
> > ...
>
> Considering that the ioctl use "state" instead of "status", your patch
> looks
> sane:
>
> case DVBFE_TUNER_BANDWIDTH:
> stb6100_set_bandwidth(fe, state->bandwidth);
>
> Could you please re-send this patch to me, mentioning the above,
> explicitly C/C
> Manu, linux-media and linux-dvb ML's? Please, mark the patch as a resend.
>
> Cheers,
> Mauro
Resending the following patch as requested by Mauro.
Signed-off-by: Hans Werner <hwerner4@gmx.de>
diff -r b7e7abe3e3aa linux/drivers/media/dvb/frontends/stb6100.c
--- a/linux/drivers/media/dvb/frontends/stb6100.c
+++ b/linux/drivers/media/dvb/frontends/stb6100.c
@@ -434,11 +434,11 @@ static int stb6100_init(struct dvb_front
status->refclock = 27000000; /* Hz */
status->iqsense = 1;
status->bandwidth = 36000; /* kHz */
- state->bandwidth = status->bandwidth * 1000; /* MHz */
+ state->bandwidth = status->bandwidth * 1000; /* Hz */
state->reference = status->refclock / 1000; /* kHz */
/* Set default bandwidth. */
- return stb6100_set_bandwidth(fe, status->bandwidth);
+ return stb6100_set_bandwidth(fe, state->bandwidth);
}
static int stb6100_get_state(struct dvb_frontend *fe,
--
Release early, release often.
Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger
_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead linux-media@vger.kernel.org
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
next parent reply other threads:[~2009-01-08 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090105152029.293080@gmx.net>
[not found] ` <20090108100149.2c6df55e@pedra.chehab.org>
2009-01-08 17:17 ` Hans Werner [this message]
2009-01-08 20:14 ` [linux-dvb] [PATCH] [RESEND] stb6100: stb6100_init fix Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090108171755.23040@gmx.net \
--to=hwerner4@gmx.de \
--cc=abraham.manu@gmail.com \
--cc=linux-dvb@linuxtv.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox