Linux Media Controller development
 help / color / mirror / Atom feed
* [linux-dvb] [PATCH] [RESEND] stb6100: stb6100_init fix
       [not found] ` <20090108100149.2c6df55e@pedra.chehab.org>
@ 2009-01-08 17:17   ` Hans Werner
  2009-01-08 20:14     ` Manu Abraham
  0 siblings, 1 reply; 2+ messages in thread
From: Hans Werner @ 2009-01-08 17:17 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, linux-media, abraham.manu, linux-dvb


> > Hi Mauro,
> > please look at the patch below.
> > 
> > Signed-off-by: Hans Werner <hwerner4@gmx.de>
> > 
> > Thanks,
> > Hans
> > 
> > -------- Original-Nachricht --------
> > Datum: Mon, 05 Jan 2009 16:10:50 +0100
> > Von: "Hans Werner" <HWerner4@gmx.de>
> > An: linux-dvb@linuxtv.org
> > Betreff: [linux-dvb] [PATCH] stb6100: stb6100_init fix
> > 
> > Two issues in stb6100_init : the call to stb6100_set_bandwidth needs an
> argument in Hz
> > not kHz, and a comment incorrectly says MHz instead of Hz.  I don't know
> if this caused
> > real problems anywhere.
> > 
> > This patch is for v4l-dvb, but it is also needs to be fixed in
> s2-liplianin.
> > 
> > ...
> > ...
> 
> Considering that the ioctl use "state" instead of "status", your patch
> looks
> sane:
> 
> case DVBFE_TUNER_BANDWIDTH:
>                 stb6100_set_bandwidth(fe, state->bandwidth);
> 
> Could you please re-send this patch to me, mentioning the above,
> explicitly C/C
> Manu, linux-media and linux-dvb ML's? Please, mark the patch as a resend.
> 
> Cheers,
> Mauro

Resending the following patch as requested by Mauro.
Signed-off-by: Hans Werner <hwerner4@gmx.de>

diff -r b7e7abe3e3aa linux/drivers/media/dvb/frontends/stb6100.c
--- a/linux/drivers/media/dvb/frontends/stb6100.c
+++ b/linux/drivers/media/dvb/frontends/stb6100.c
@@ -434,11 +434,11 @@ static int stb6100_init(struct dvb_front
        status->refclock        = 27000000;     /* Hz   */
        status->iqsense         = 1;
        status->bandwidth       = 36000;        /* kHz  */
-       state->bandwidth        = status->bandwidth * 1000;     /* MHz  */
+       state->bandwidth        = status->bandwidth * 1000;     /* Hz   */
        state->reference        = status->refclock / 1000;      /* kHz  */

        /* Set default bandwidth.       */
-       return stb6100_set_bandwidth(fe, status->bandwidth);
+       return stb6100_set_bandwidth(fe, state->bandwidth);
 }

 static int stb6100_get_state(struct dvb_frontend *fe,




-- 
Release early, release often.

Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead linux-media@vger.kernel.org
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [linux-dvb] [PATCH] [RESEND] stb6100: stb6100_init fix
  2009-01-08 17:17   ` [linux-dvb] [PATCH] [RESEND] stb6100: stb6100_init fix Hans Werner
@ 2009-01-08 20:14     ` Manu Abraham
  0 siblings, 0 replies; 2+ messages in thread
From: Manu Abraham @ 2009-01-08 20:14 UTC (permalink / raw)
  To: Hans Werner; +Cc: linux-dvb, Mauro Carvalho Chehab, linux-media


[-- Attachment #1.1: Type: text/plain, Size: 1189 bytes --]

On Thu, Jan 8, 2009 at 9:17 PM, Hans Werner <HWerner4@gmx.de> wrote:

>
>
> Signed-off-by: Hans Werner <hwerner4@gmx.de>
>
> diff -r b7e7abe3e3aa linux/drivers/media/dvb/frontends/stb6100.c
> --- a/linux/drivers/media/dvb/frontends/stb6100.c
> +++ b/linux/drivers/media/dvb/frontends/stb6100.c
> @@ -434,11 +434,11 @@ static int stb6100_init(struct dvb_front
>        status->refclock        = 27000000;     /* Hz   */
>        status->iqsense         = 1;
>        status->bandwidth       = 36000;        /* kHz  */
> -       state->bandwidth        = status->bandwidth * 1000;     /* MHz  */
> +       state->bandwidth        = status->bandwidth * 1000;     /* Hz   */
>        state->reference        = status->refclock / 1000;      /* kHz  */
>
>        /* Set default bandwidth.       */
> -       return stb6100_set_bandwidth(fe, status->bandwidth);
> +       return stb6100_set_bandwidth(fe, state->bandwidth);
>  }
>
>  static int stb6100_get_state(struct dvb_frontend *fe,
>


Patch looks more or less ok, but it won't have any effect in any manner at
all as it is a
NOP during init (purely cosmetic). Anyway will pull it in along with the
other patches
and after testing.


Manu

[-- Attachment #1.2: Type: text/html, Size: 2041 bytes --]

[-- Attachment #2: Type: text/plain, Size: 228 bytes --]

_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead linux-media@vger.kernel.org
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-08 20:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20090105152029.293080@gmx.net>
     [not found] ` <20090108100149.2c6df55e@pedra.chehab.org>
2009-01-08 17:17   ` [linux-dvb] [PATCH] [RESEND] stb6100: stb6100_init fix Hans Werner
2009-01-08 20:14     ` Manu Abraham

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox