* [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats
@ 2014-12-03 13:53 Philipp Zabel
2014-12-03 13:53 ` [PATCH v2 2/3] Add YUV8_1X24 media bus format Philipp Zabel
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Philipp Zabel @ 2014-12-03 13:53 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Hans Verkuil, Laurent Pinchart, Boris Brezillon, linux-media,
kernel, Philipp Zabel
This patch adds two more 24-bit RGB formats. BGR888 is more or less common,
GBR888 is used on the internal connection between the IPU display interface
and the TVE (VGA DAC) on i.MX53 SoCs.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Changes since v1:
- Reordered 24-bit RGB formats alphabetically
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 60 ++++++++++++++++++++++
include/uapi/linux/media-bus-format.h | 4 +-
2 files changed, 63 insertions(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
index 52d7f04..a8da9d3 100644
--- a/Documentation/DocBook/media/v4l/subdev-formats.xml
+++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
@@ -469,6 +469,66 @@
<entry>b<subscript>1</subscript></entry>
<entry>b<subscript>0</subscript></entry>
</row>
+ <row id="MEDIA-BUS-FMT-BGR888-1X24">
+ <entry>MEDIA_BUS_FMT_BGR888_1X24</entry>
+ <entry>0x1013</entry>
+ <entry></entry>
+ &dash-ent-8;
+ <entry>b<subscript>7</subscript></entry>
+ <entry>b<subscript>6</subscript></entry>
+ <entry>b<subscript>5</subscript></entry>
+ <entry>b<subscript>4</subscript></entry>
+ <entry>b<subscript>3</subscript></entry>
+ <entry>b<subscript>2</subscript></entry>
+ <entry>b<subscript>1</subscript></entry>
+ <entry>b<subscript>0</subscript></entry>
+ <entry>g<subscript>7</subscript></entry>
+ <entry>g<subscript>6</subscript></entry>
+ <entry>g<subscript>5</subscript></entry>
+ <entry>g<subscript>4</subscript></entry>
+ <entry>g<subscript>3</subscript></entry>
+ <entry>g<subscript>2</subscript></entry>
+ <entry>g<subscript>1</subscript></entry>
+ <entry>g<subscript>0</subscript></entry>
+ <entry>r<subscript>7</subscript></entry>
+ <entry>r<subscript>6</subscript></entry>
+ <entry>r<subscript>5</subscript></entry>
+ <entry>r<subscript>4</subscript></entry>
+ <entry>r<subscript>3</subscript></entry>
+ <entry>r<subscript>2</subscript></entry>
+ <entry>r<subscript>1</subscript></entry>
+ <entry>r<subscript>0</subscript></entry>
+ </row>
+ <row id="MEDIA-BUS-FMT-GBR888-1X24">
+ <entry>MEDIA_BUS_FMT_GBR888_1X24</entry>
+ <entry>0x1014</entry>
+ <entry></entry>
+ &dash-ent-8;
+ <entry>g<subscript>7</subscript></entry>
+ <entry>g<subscript>6</subscript></entry>
+ <entry>g<subscript>5</subscript></entry>
+ <entry>g<subscript>4</subscript></entry>
+ <entry>g<subscript>3</subscript></entry>
+ <entry>g<subscript>2</subscript></entry>
+ <entry>g<subscript>1</subscript></entry>
+ <entry>g<subscript>0</subscript></entry>
+ <entry>b<subscript>7</subscript></entry>
+ <entry>b<subscript>6</subscript></entry>
+ <entry>b<subscript>5</subscript></entry>
+ <entry>b<subscript>4</subscript></entry>
+ <entry>b<subscript>3</subscript></entry>
+ <entry>b<subscript>2</subscript></entry>
+ <entry>b<subscript>1</subscript></entry>
+ <entry>b<subscript>0</subscript></entry>
+ <entry>r<subscript>7</subscript></entry>
+ <entry>r<subscript>6</subscript></entry>
+ <entry>r<subscript>5</subscript></entry>
+ <entry>r<subscript>4</subscript></entry>
+ <entry>r<subscript>3</subscript></entry>
+ <entry>r<subscript>2</subscript></entry>
+ <entry>r<subscript>1</subscript></entry>
+ <entry>r<subscript>0</subscript></entry>
+ </row>
<row id="MEDIA-BUS-FMT-RGB888-1X24">
<entry>MEDIA_BUS_FMT_RGB888_1X24</entry>
<entry>0x100a</entry>
diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
index 7f8b1e2..10b40dd 100644
--- a/include/uapi/linux/media-bus-format.h
+++ b/include/uapi/linux/media-bus-format.h
@@ -33,7 +33,7 @@
#define MEDIA_BUS_FMT_FIXED 0x0001
-/* RGB - next is 0x1013 */
+/* RGB - next is 0x1015 */
#define MEDIA_BUS_FMT_RGB444_1X12 0x100e
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
@@ -46,6 +46,8 @@
#define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008
#define MEDIA_BUS_FMT_RGB666_1X18 0x1009
#define MEDIA_BUS_FMT_RGB666_LVDS_SPWG 0x1010
+#define MEDIA_BUS_FMT_BGR888_1X24 0x1013
+#define MEDIA_BUS_FMT_GBR888_1X24 0x1014
#define MEDIA_BUS_FMT_RGB888_1X24 0x100a
#define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
#define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
--
2.1.3
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 2/3] Add YUV8_1X24 media bus format
2014-12-03 13:53 [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Philipp Zabel
@ 2014-12-03 13:53 ` Philipp Zabel
2014-12-03 13:53 ` [PATCH 3/3] Add RGB666_1X24_CPADHI " Philipp Zabel
2015-02-02 15:08 ` [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Hans Verkuil
2 siblings, 0 replies; 11+ messages in thread
From: Philipp Zabel @ 2014-12-03 13:53 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Hans Verkuil, Laurent Pinchart, Boris Brezillon, linux-media,
kernel, Philipp Zabel
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 37 ++++++++++++++++++++++
include/uapi/linux/media-bus-format.h | 3 +-
2 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
index a8da9d3..3d88a25 100644
--- a/Documentation/DocBook/media/v4l/subdev-formats.xml
+++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
@@ -2933,6 +2933,43 @@
<entry>u<subscript>1</subscript></entry>
<entry>u<subscript>0</subscript></entry>
</row>
+ <row id="MEDIA-BUS-FMT-YUV8-1X24">
+ <entry>MEDIA_BUS_FMT_YUV8_1X24</entry>
+ <entry>0x2024</entry>
+ <entry></entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>-</entry>
+ <entry>y<subscript>7</subscript></entry>
+ <entry>y<subscript>6</subscript></entry>
+ <entry>y<subscript>5</subscript></entry>
+ <entry>y<subscript>4</subscript></entry>
+ <entry>y<subscript>3</subscript></entry>
+ <entry>y<subscript>2</subscript></entry>
+ <entry>y<subscript>1</subscript></entry>
+ <entry>y<subscript>0</subscript></entry>
+ <entry>u<subscript>7</subscript></entry>
+ <entry>u<subscript>6</subscript></entry>
+ <entry>u<subscript>5</subscript></entry>
+ <entry>u<subscript>4</subscript></entry>
+ <entry>u<subscript>3</subscript></entry>
+ <entry>u<subscript>2</subscript></entry>
+ <entry>u<subscript>1</subscript></entry>
+ <entry>u<subscript>0</subscript></entry>
+ <entry>v<subscript>7</subscript></entry>
+ <entry>v<subscript>6</subscript></entry>
+ <entry>v<subscript>5</subscript></entry>
+ <entry>v<subscript>4</subscript></entry>
+ <entry>v<subscript>3</subscript></entry>
+ <entry>v<subscript>2</subscript></entry>
+ <entry>v<subscript>1</subscript></entry>
+ <entry>v<subscript>0</subscript></entry>
+ </row>
<row id="MEDIA-BUS-FMT-YUV10-1X30">
<entry>MEDIA_BUS_FMT_YUV10_1X30</entry>
<entry>0x2016</entry>
diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
index 10b40dd..35e0579 100644
--- a/include/uapi/linux/media-bus-format.h
+++ b/include/uapi/linux/media-bus-format.h
@@ -55,7 +55,7 @@
#define MEDIA_BUS_FMT_RGB888_LVDS_JEIDA 0x1012
#define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d
-/* YUV (including grey) - next is 0x2024 */
+/* YUV (including grey) - next is 0x2025 */
#define MEDIA_BUS_FMT_Y8_1X8 0x2001
#define MEDIA_BUS_FMT_UV8_1X8 0x2015
#define MEDIA_BUS_FMT_UYVY8_1_5X8 0x2002
@@ -81,6 +81,7 @@
#define MEDIA_BUS_FMT_VYUY10_1X20 0x201b
#define MEDIA_BUS_FMT_YUYV10_1X20 0x200d
#define MEDIA_BUS_FMT_YVYU10_1X20 0x200e
+#define MEDIA_BUS_FMT_YUV8_1X24 0x2024
#define MEDIA_BUS_FMT_YUV10_1X30 0x2016
#define MEDIA_BUS_FMT_AYUV8_1X32 0x2017
#define MEDIA_BUS_FMT_UYVY12_2X12 0x201c
--
2.1.3
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/3] Add RGB666_1X24_CPADHI media bus format
2014-12-03 13:53 [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Philipp Zabel
2014-12-03 13:53 ` [PATCH v2 2/3] Add YUV8_1X24 media bus format Philipp Zabel
@ 2014-12-03 13:53 ` Philipp Zabel
2015-02-02 15:08 ` [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Hans Verkuil
2 siblings, 0 replies; 11+ messages in thread
From: Philipp Zabel @ 2014-12-03 13:53 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Hans Verkuil, Laurent Pinchart, Boris Brezillon, linux-media,
kernel, Philipp Zabel, Emil Renner Berthing
Commit 9e74d2926a28 ("staging: imx-drm: add LVDS666 support for parallel
display") describes a 24-bit bus format where three 6-bit components each
take the lower part of 8 bits with the two high bits zero padded. Add a
component-wise padded media bus format RGB666_1X24_CPADHI to support this
connection.
Cc: Emil Renner Berthing <kernel@esmil.dk>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
Changes since v1:
- Added missing /* RGB - next is ... */ comment update
---
Documentation/DocBook/media/v4l/subdev-formats.xml | 30 ++++++++++++++++++++++
include/uapi/linux/media-bus-format.h | 3 ++-
2 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
index 3d88a25..e60a01f 100644
--- a/Documentation/DocBook/media/v4l/subdev-formats.xml
+++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
@@ -469,6 +469,36 @@
<entry>b<subscript>1</subscript></entry>
<entry>b<subscript>0</subscript></entry>
</row>
+ <row id="MEDIA-BUS-FMT-RGB666-1X24_CPADHI">
+ <entry>MEDIA_BUS_FMT_RGB666_1X24_CPADHI</entry>
+ <entry>0x1015</entry>
+ <entry></entry>
+ &dash-ent-8;
+ <entry>0</entry>
+ <entry>0</entry>
+ <entry>r<subscript>5</subscript></entry>
+ <entry>r<subscript>4</subscript></entry>
+ <entry>r<subscript>3</subscript></entry>
+ <entry>r<subscript>2</subscript></entry>
+ <entry>r<subscript>1</subscript></entry>
+ <entry>r<subscript>0</subscript></entry>
+ <entry>0</entry>
+ <entry>0</entry>
+ <entry>g<subscript>5</subscript></entry>
+ <entry>g<subscript>4</subscript></entry>
+ <entry>g<subscript>3</subscript></entry>
+ <entry>g<subscript>2</subscript></entry>
+ <entry>g<subscript>1</subscript></entry>
+ <entry>g<subscript>0</subscript></entry>
+ <entry>0</entry>
+ <entry>0</entry>
+ <entry>b<subscript>5</subscript></entry>
+ <entry>b<subscript>4</subscript></entry>
+ <entry>b<subscript>3</subscript></entry>
+ <entry>b<subscript>2</subscript></entry>
+ <entry>b<subscript>1</subscript></entry>
+ <entry>b<subscript>0</subscript></entry>
+ </row>
<row id="MEDIA-BUS-FMT-BGR888-1X24">
<entry>MEDIA_BUS_FMT_BGR888_1X24</entry>
<entry>0x1013</entry>
diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
index 35e0579..95826e5 100644
--- a/include/uapi/linux/media-bus-format.h
+++ b/include/uapi/linux/media-bus-format.h
@@ -33,7 +33,7 @@
#define MEDIA_BUS_FMT_FIXED 0x0001
-/* RGB - next is 0x1015 */
+/* RGB - next is 0x1016 */
#define MEDIA_BUS_FMT_RGB444_1X12 0x100e
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
#define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
@@ -45,6 +45,7 @@
#define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007
#define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008
#define MEDIA_BUS_FMT_RGB666_1X18 0x1009
+#define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015
#define MEDIA_BUS_FMT_RGB666_LVDS_SPWG 0x1010
#define MEDIA_BUS_FMT_BGR888_1X24 0x1013
#define MEDIA_BUS_FMT_GBR888_1X24 0x1014
--
2.1.3
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats
2014-12-03 13:53 [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Philipp Zabel
2014-12-03 13:53 ` [PATCH v2 2/3] Add YUV8_1X24 media bus format Philipp Zabel
2014-12-03 13:53 ` [PATCH 3/3] Add RGB666_1X24_CPADHI " Philipp Zabel
@ 2015-02-02 15:08 ` Hans Verkuil
2015-02-02 15:21 ` Philipp Zabel
2 siblings, 1 reply; 11+ messages in thread
From: Hans Verkuil @ 2015-02-02 15:08 UTC (permalink / raw)
To: Philipp Zabel, Mauro Carvalho Chehab
Cc: Hans Verkuil, Laurent Pinchart, Boris Brezillon, linux-media,
kernel
On 12/03/2014 02:53 PM, Philipp Zabel wrote:
> This patch adds two more 24-bit RGB formats. BGR888 is more or less common,
> GBR888 is used on the internal connection between the IPU display interface
> and the TVE (VGA DAC) on i.MX53 SoCs.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This three-part patch series doesn't apply. Is it on top of another patch
series?
Anyway, it can't be merged unless it is actually used in a driver.
I'm changing this to 'Changes Requested' in patchwork.
Regards,
Hans
> ---
> Changes since v1:
> - Reordered 24-bit RGB formats alphabetically
> ---
> Documentation/DocBook/media/v4l/subdev-formats.xml | 60 ++++++++++++++++++++++
> include/uapi/linux/media-bus-format.h | 4 +-
> 2 files changed, 63 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml b/Documentation/DocBook/media/v4l/subdev-formats.xml
> index 52d7f04..a8da9d3 100644
> --- a/Documentation/DocBook/media/v4l/subdev-formats.xml
> +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
> @@ -469,6 +469,66 @@
> <entry>b<subscript>1</subscript></entry>
> <entry>b<subscript>0</subscript></entry>
> </row>
> + <row id="MEDIA-BUS-FMT-BGR888-1X24">
> + <entry>MEDIA_BUS_FMT_BGR888_1X24</entry>
> + <entry>0x1013</entry>
> + <entry></entry>
> + &dash-ent-8;
> + <entry>b<subscript>7</subscript></entry>
> + <entry>b<subscript>6</subscript></entry>
> + <entry>b<subscript>5</subscript></entry>
> + <entry>b<subscript>4</subscript></entry>
> + <entry>b<subscript>3</subscript></entry>
> + <entry>b<subscript>2</subscript></entry>
> + <entry>b<subscript>1</subscript></entry>
> + <entry>b<subscript>0</subscript></entry>
> + <entry>g<subscript>7</subscript></entry>
> + <entry>g<subscript>6</subscript></entry>
> + <entry>g<subscript>5</subscript></entry>
> + <entry>g<subscript>4</subscript></entry>
> + <entry>g<subscript>3</subscript></entry>
> + <entry>g<subscript>2</subscript></entry>
> + <entry>g<subscript>1</subscript></entry>
> + <entry>g<subscript>0</subscript></entry>
> + <entry>r<subscript>7</subscript></entry>
> + <entry>r<subscript>6</subscript></entry>
> + <entry>r<subscript>5</subscript></entry>
> + <entry>r<subscript>4</subscript></entry>
> + <entry>r<subscript>3</subscript></entry>
> + <entry>r<subscript>2</subscript></entry>
> + <entry>r<subscript>1</subscript></entry>
> + <entry>r<subscript>0</subscript></entry>
> + </row>
> + <row id="MEDIA-BUS-FMT-GBR888-1X24">
> + <entry>MEDIA_BUS_FMT_GBR888_1X24</entry>
> + <entry>0x1014</entry>
> + <entry></entry>
> + &dash-ent-8;
> + <entry>g<subscript>7</subscript></entry>
> + <entry>g<subscript>6</subscript></entry>
> + <entry>g<subscript>5</subscript></entry>
> + <entry>g<subscript>4</subscript></entry>
> + <entry>g<subscript>3</subscript></entry>
> + <entry>g<subscript>2</subscript></entry>
> + <entry>g<subscript>1</subscript></entry>
> + <entry>g<subscript>0</subscript></entry>
> + <entry>b<subscript>7</subscript></entry>
> + <entry>b<subscript>6</subscript></entry>
> + <entry>b<subscript>5</subscript></entry>
> + <entry>b<subscript>4</subscript></entry>
> + <entry>b<subscript>3</subscript></entry>
> + <entry>b<subscript>2</subscript></entry>
> + <entry>b<subscript>1</subscript></entry>
> + <entry>b<subscript>0</subscript></entry>
> + <entry>r<subscript>7</subscript></entry>
> + <entry>r<subscript>6</subscript></entry>
> + <entry>r<subscript>5</subscript></entry>
> + <entry>r<subscript>4</subscript></entry>
> + <entry>r<subscript>3</subscript></entry>
> + <entry>r<subscript>2</subscript></entry>
> + <entry>r<subscript>1</subscript></entry>
> + <entry>r<subscript>0</subscript></entry>
> + </row>
> <row id="MEDIA-BUS-FMT-RGB888-1X24">
> <entry>MEDIA_BUS_FMT_RGB888_1X24</entry>
> <entry>0x100a</entry>
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index 7f8b1e2..10b40dd 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -33,7 +33,7 @@
>
> #define MEDIA_BUS_FMT_FIXED 0x0001
>
> -/* RGB - next is 0x1013 */
> +/* RGB - next is 0x1015 */
> #define MEDIA_BUS_FMT_RGB444_1X12 0x100e
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
> @@ -46,6 +46,8 @@
> #define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008
> #define MEDIA_BUS_FMT_RGB666_1X18 0x1009
> #define MEDIA_BUS_FMT_RGB666_LVDS_SPWG 0x1010
> +#define MEDIA_BUS_FMT_BGR888_1X24 0x1013
> +#define MEDIA_BUS_FMT_GBR888_1X24 0x1014
> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a
> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats
2015-02-02 15:08 ` [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Hans Verkuil
@ 2015-02-02 15:21 ` Philipp Zabel
2015-02-02 15:24 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 11+ messages in thread
From: Philipp Zabel @ 2015-02-02 15:21 UTC (permalink / raw)
To: Hans Verkuil
Cc: Mauro Carvalho Chehab, Hans Verkuil, Laurent Pinchart,
Boris Brezillon, linux-media, kernel
Am Montag, den 02.02.2015, 16:08 +0100 schrieb Hans Verkuil:
> On 12/03/2014 02:53 PM, Philipp Zabel wrote:
> > This patch adds two more 24-bit RGB formats. BGR888 is more or less common,
> > GBR888 is used on the internal connection between the IPU display interface
> > and the TVE (VGA DAC) on i.MX53 SoCs.
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> This three-part patch series doesn't apply. Is it on top of another patch
> series?
It is on top of "Add RGB444_1X12 and RGB565_1X16 media bus formats" and
"Add LVDS RGB media bus formats".
> Anyway, it can't be merged unless it is actually used in a driver.
I'd like to use these in the imx-drm driver, so this is kind of a
chicken and egg situation. Shall I submit a patch that uses the defines
to dri-devel and reference it here?
regards
Philipp
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats
2015-02-02 15:21 ` Philipp Zabel
@ 2015-02-02 15:24 ` Mauro Carvalho Chehab
2015-02-02 15:34 ` Philipp Zabel
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Mauro Carvalho Chehab @ 2015-02-02 15:24 UTC (permalink / raw)
To: Philipp Zabel
Cc: Hans Verkuil, Hans Verkuil, Laurent Pinchart, Boris Brezillon,
linux-media, kernel
Em Mon, 02 Feb 2015 16:21:00 +0100
Philipp Zabel <p.zabel@pengutronix.de> escreveu:
> Am Montag, den 02.02.2015, 16:08 +0100 schrieb Hans Verkuil:
> > On 12/03/2014 02:53 PM, Philipp Zabel wrote:
> > > This patch adds two more 24-bit RGB formats. BGR888 is more or less common,
> > > GBR888 is used on the internal connection between the IPU display interface
> > > and the TVE (VGA DAC) on i.MX53 SoCs.
> > >
> > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > This three-part patch series doesn't apply. Is it on top of another patch
> > series?
>
> It is on top of "Add RGB444_1X12 and RGB565_1X16 media bus formats" and
> "Add LVDS RGB media bus formats".
>
> > Anyway, it can't be merged unless it is actually used in a driver.
>
> I'd like to use these in the imx-drm driver, so this is kind of a
> chicken and egg situation. Shall I submit a patch that uses the defines
> to dri-devel and reference it here?
Submit the full patch series with the imx-drm driver, mentioning at the
V4L2 patch that it will be applied via the DRM tree. We'll review
and give our ack for it to be applied via DRM tree.
Regards,
Mauro
>
> regards
> Philipp
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats
2015-02-02 15:24 ` Mauro Carvalho Chehab
@ 2015-02-02 15:34 ` Philipp Zabel
2015-02-02 15:48 ` Boris Brezillon
2015-02-04 14:43 ` Sakari Ailus
2015-03-24 9:40 ` Philipp Zabel
2 siblings, 1 reply; 11+ messages in thread
From: Philipp Zabel @ 2015-02-02 15:34 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Boris Brezillon, Hans Verkuil, Hans Verkuil, Laurent Pinchart,
kernel, linux-media
Am Montag, den 02.02.2015, 13:24 -0200 schrieb Mauro Carvalho Chehab:
> Em Mon, 02 Feb 2015 16:21:00 +0100
> Philipp Zabel <p.zabel@pengutronix.de> escreveu:
>
> > Am Montag, den 02.02.2015, 16:08 +0100 schrieb Hans Verkuil:
> > > On 12/03/2014 02:53 PM, Philipp Zabel wrote:
> > > > This patch adds two more 24-bit RGB formats. BGR888 is more or less common,
> > > > GBR888 is used on the internal connection between the IPU display interface
> > > > and the TVE (VGA DAC) on i.MX53 SoCs.
> > > >
> > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > This three-part patch series doesn't apply. Is it on top of another patch
> > > series?
> >
> > It is on top of "Add RGB444_1X12 and RGB565_1X16 media bus formats" and
> > "Add LVDS RGB media bus formats".
> >
> > > Anyway, it can't be merged unless it is actually used in a driver.
> >
> > I'd like to use these in the imx-drm driver, so this is kind of a
> > chicken and egg situation. Shall I submit a patch that uses the defines
> > to dri-devel and reference it here?
>
> Submit the full patch series with the imx-drm driver, mentioning at the
> V4L2 patch that it will be applied via the DRM tree. We'll review
> and give our ack for it to be applied via DRM tree.
I'll do that, thanks.
regards
Philipp
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats
2015-02-02 15:34 ` Philipp Zabel
@ 2015-02-02 15:48 ` Boris Brezillon
2015-02-02 16:51 ` Philipp Zabel
0 siblings, 1 reply; 11+ messages in thread
From: Boris Brezillon @ 2015-02-02 15:48 UTC (permalink / raw)
To: Philipp Zabel
Cc: Mauro Carvalho Chehab, Hans Verkuil, Hans Verkuil,
Laurent Pinchart, kernel, linux-media
Hi Philip,
On Mon, 02 Feb 2015 16:34:42 +0100
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Am Montag, den 02.02.2015, 13:24 -0200 schrieb Mauro Carvalho Chehab:
> > Em Mon, 02 Feb 2015 16:21:00 +0100
> > Philipp Zabel <p.zabel@pengutronix.de> escreveu:
> >
> > > Am Montag, den 02.02.2015, 16:08 +0100 schrieb Hans Verkuil:
> > > > On 12/03/2014 02:53 PM, Philipp Zabel wrote:
> > > > > This patch adds two more 24-bit RGB formats. BGR888 is more or less common,
> > > > > GBR888 is used on the internal connection between the IPU display interface
> > > > > and the TVE (VGA DAC) on i.MX53 SoCs.
> > > > >
> > > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > >
> > > > This three-part patch series doesn't apply. Is it on top of another patch
> > > > series?
> > >
> > > It is on top of "Add RGB444_1X12 and RGB565_1X16 media bus formats" and
> > > "Add LVDS RGB media bus formats".
> > >
> > > > Anyway, it can't be merged unless it is actually used in a driver.
> > >
> > > I'd like to use these in the imx-drm driver, so this is kind of a
> > > chicken and egg situation. Shall I submit a patch that uses the defines
> > > to dri-devel and reference it here?
> >
> > Submit the full patch series with the imx-drm driver, mentioning at the
> > V4L2 patch that it will be applied via the DRM tree. We'll review
> > and give our ack for it to be applied via DRM tree.
>
> I'll do that, thanks.
Don't know if you plan to keep the dependency on my RGB444 and RGB565
addition, but if you do, I guess you don't want to wait for my
atmel-hlcdc changes, so the best solution is to include my patch in
your series ;-).
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats
2015-02-02 15:48 ` Boris Brezillon
@ 2015-02-02 16:51 ` Philipp Zabel
0 siblings, 0 replies; 11+ messages in thread
From: Philipp Zabel @ 2015-02-02 16:51 UTC (permalink / raw)
To: Boris Brezillon
Cc: Hans Verkuil, Hans Verkuil, Laurent Pinchart, kernel,
Mauro Carvalho Chehab, linux-media
Hi Boris,
Am Montag, den 02.02.2015, 16:48 +0100 schrieb Boris Brezillon:
> Hi Philip,
>
> On Mon, 02 Feb 2015 16:34:42 +0100
> Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> > Am Montag, den 02.02.2015, 13:24 -0200 schrieb Mauro Carvalho Chehab:
> > > Em Mon, 02 Feb 2015 16:21:00 +0100
> > > Philipp Zabel <p.zabel@pengutronix.de> escreveu:
> > >
> > > > Am Montag, den 02.02.2015, 16:08 +0100 schrieb Hans Verkuil:
> > > > > On 12/03/2014 02:53 PM, Philipp Zabel wrote:
> > > > > > This patch adds two more 24-bit RGB formats. BGR888 is more or less common,
> > > > > > GBR888 is used on the internal connection between the IPU display interface
> > > > > > and the TVE (VGA DAC) on i.MX53 SoCs.
> > > > > >
> > > > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > > > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > >
> > > > > This three-part patch series doesn't apply. Is it on top of another patch
> > > > > series?
> > > >
> > > > It is on top of "Add RGB444_1X12 and RGB565_1X16 media bus formats" and
> > > > "Add LVDS RGB media bus formats".
> > > >
> > > > > Anyway, it can't be merged unless it is actually used in a driver.
> > > >
> > > > I'd like to use these in the imx-drm driver, so this is kind of a
> > > > chicken and egg situation. Shall I submit a patch that uses the defines
> > > > to dri-devel and reference it here?
> > >
> > > Submit the full patch series with the imx-drm driver, mentioning at the
> > > V4L2 patch that it will be applied via the DRM tree. We'll review
> > > and give our ack for it to be applied via DRM tree.
> >
> > I'll do that, thanks.
>
> Don't know if you plan to keep the dependency on my RGB444 and RGB565
> addition, but if you do, I guess you don't want to wait for my
> atmel-hlcdc changes, so the best solution is to include my patch in
> your series ;-).
Ok, I'll include your patch since I need the RGB565 format description
as well.
regards
Philipp
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats
2015-02-02 15:24 ` Mauro Carvalho Chehab
2015-02-02 15:34 ` Philipp Zabel
@ 2015-02-04 14:43 ` Sakari Ailus
2015-03-24 9:40 ` Philipp Zabel
2 siblings, 0 replies; 11+ messages in thread
From: Sakari Ailus @ 2015-02-04 14:43 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Philipp Zabel, Hans Verkuil, Hans Verkuil, Laurent Pinchart,
Boris Brezillon, linux-media, kernel
Hi Mauro and Philipp,
On Mon, Feb 02, 2015 at 01:24:21PM -0200, Mauro Carvalho Chehab wrote:
> Em Mon, 02 Feb 2015 16:21:00 +0100
> Philipp Zabel <p.zabel@pengutronix.de> escreveu:
>
> > Am Montag, den 02.02.2015, 16:08 +0100 schrieb Hans Verkuil:
> > > On 12/03/2014 02:53 PM, Philipp Zabel wrote:
> > > > This patch adds two more 24-bit RGB formats. BGR888 is more or less common,
> > > > GBR888 is used on the internal connection between the IPU display interface
> > > > and the TVE (VGA DAC) on i.MX53 SoCs.
> > > >
> > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > This three-part patch series doesn't apply. Is it on top of another patch
> > > series?
> >
> > It is on top of "Add RGB444_1X12 and RGB565_1X16 media bus formats" and
> > "Add LVDS RGB media bus formats".
> >
> > > Anyway, it can't be merged unless it is actually used in a driver.
> >
> > I'd like to use these in the imx-drm driver, so this is kind of a
> > chicken and egg situation. Shall I submit a patch that uses the defines
> > to dri-devel and reference it here?
>
> Submit the full patch series with the imx-drm driver, mentioning at the
> V4L2 patch that it will be applied via the DRM tree. We'll review
> and give our ack for it to be applied via DRM tree.
Just remember that as these patches change the RGB and YUV formats in
media-bus-format.h --- it's very easy to get a conflict and even overlapping
IDs defined this way if / when someone else submits a patch to these. There
usually have been a few format related patches per minor release. So I'd
personally still put these patches through linux-media, and just accept that
a driver will use them later on.
Just my 5 euro cents. :-)
--
Cheers,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats
2015-02-02 15:24 ` Mauro Carvalho Chehab
2015-02-02 15:34 ` Philipp Zabel
2015-02-04 14:43 ` Sakari Ailus
@ 2015-03-24 9:40 ` Philipp Zabel
2 siblings, 0 replies; 11+ messages in thread
From: Philipp Zabel @ 2015-03-24 9:40 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Hans Verkuil, Hans Verkuil, Laurent Pinchart, Boris Brezillon,
linux-media, kernel
Hi Mauro,
Am Montag, den 02.02.2015, 13:24 -0200 schrieb Mauro Carvalho Chehab:
[...]
> Submit the full patch series with the imx-drm driver, mentioning at the
> V4L2 patch that it will be applied via the DRM tree. We'll review
> and give our ack for it to be applied via DRM tree.
I think I also need your ack for the "[PATCH v3 00/10] Use media bus
formats in imx-drm and add drm panel support" series I sent in response
to this request. Could you please have a look?
regards
Philipp
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-03-24 9:40 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 13:53 [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Philipp Zabel
2014-12-03 13:53 ` [PATCH v2 2/3] Add YUV8_1X24 media bus format Philipp Zabel
2014-12-03 13:53 ` [PATCH 3/3] Add RGB666_1X24_CPADHI " Philipp Zabel
2015-02-02 15:08 ` [PATCH v2 1/3] Add BGR888_1X24 and GBR888_1X24 media bus formats Hans Verkuil
2015-02-02 15:21 ` Philipp Zabel
2015-02-02 15:24 ` Mauro Carvalho Chehab
2015-02-02 15:34 ` Philipp Zabel
2015-02-02 15:48 ` Boris Brezillon
2015-02-02 16:51 ` Philipp Zabel
2015-02-04 14:43 ` Sakari Ailus
2015-03-24 9:40 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox