[PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Cimbůrek]

Hi,

with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
anymore.

I checked the changes and found out the problem in commit
af3a4a9bbeb00df3e42e77240b4cdac5479812f9.

In dib0700_core.c in struct dib0700_rc_response the following union:

union {
    u16 system16;
    struct {
        u8 not_system;
        u8 system;
    };
};

has been replaced by simple variables:

u8 system;
u8 not_system;

But these variables are in reverse order! When I switch the order
back, the remote works fine again! Here is the patch:


--- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
14:27:15.000000000 +0100
+++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
14:27:36.000000000 +0100
@@ -658,8 +658,8 @@
 struct dib0700_rc_response {
     u8 report_id;
     u8 data_state;
-    u8 system;
     u8 not_system;
+    u8 system;
     u8 data;
     u8 not_data;
 };


Regards,
David

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Cimbůrek]

No one is interested? I'd like to get this patch to kernel to fix the
issue. Can someone here do it please?


2014-12-20 14:36 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
> Hi,
>
> with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
> Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
> anymore.
>
> I checked the changes and found out the problem in commit
> af3a4a9bbeb00df3e42e77240b4cdac5479812f9.
>
> In dib0700_core.c in struct dib0700_rc_response the following union:
>
> union {
>     u16 system16;
>     struct {
>         u8 not_system;
>         u8 system;
>     };
> };
>
> has been replaced by simple variables:
>
> u8 system;
> u8 not_system;
>
> But these variables are in reverse order! When I switch the order
> back, the remote works fine again! Here is the patch:
>
>
> --- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
> 14:27:15.000000000 +0100
> +++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
> 14:27:36.000000000 +0100
> @@ -658,8 +658,8 @@
>  struct dib0700_rc_response {
>      u8 report_id;
>      u8 data_state;
> -    u8 system;
>      u8 not_system;
> +    u8 system;
>      u8 data;
>      u8 not_data;
>  };
>
>
> Regards,
> David

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Cimbůrek]

Please include this patch to kernel! It takes too much time for such a
simple fix!


2015-01-07 13:51 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
> No one is interested? I'd like to get this patch to kernel to fix the
> issue. Can someone here do it please?
>
>
> 2014-12-20 14:36 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>> Hi,
>>
>> with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
>> Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
>> anymore.
>>
>> I checked the changes and found out the problem in commit
>> af3a4a9bbeb00df3e42e77240b4cdac5479812f9.
>>
>> In dib0700_core.c in struct dib0700_rc_response the following union:
>>
>> union {
>>     u16 system16;
>>     struct {
>>         u8 not_system;
>>         u8 system;
>>     };
>> };
>>
>> has been replaced by simple variables:
>>
>> u8 system;
>> u8 not_system;
>>
>> But these variables are in reverse order! When I switch the order
>> back, the remote works fine again! Here is the patch:
>>
>>
>> --- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>> 14:27:15.000000000 +0100
>> +++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>> 14:27:36.000000000 +0100
>> @@ -658,8 +658,8 @@
>>  struct dib0700_rc_response {
>>      u8 report_id;
>>      u8 data_state;
>> -    u8 system;
>>      u8 not_system;
>> +    u8 system;
>>      u8 data;
>>      u8 not_data;
>>  };
>>
>>
>> Regards,
>> David

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[Antti Palosaari]

David Härdeman,
Could you look that as it is your patch which has broken it

commit af3a4a9bbeb00df3e42e77240b4cdac5479812f9
Author: David Härdeman <david@hardeman.nu>
Date:   Thu Apr 3 20:31:51 2014 -0300

     [media] dib0700: NEC scancode cleanup


Antti

On 02/10/2015 12:38 PM, David Cimbůrek wrote:
> Please include this patch to kernel! It takes too much time for such a
> simple fix!
>
>
> 2015-01-07 13:51 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>> No one is interested? I'd like to get this patch to kernel to fix the
>> issue. Can someone here do it please?
>>
>>
>> 2014-12-20 14:36 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>>> Hi,
>>>
>>> with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
>>> Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
>>> anymore.
>>>
>>> I checked the changes and found out the problem in commit
>>> af3a4a9bbeb00df3e42e77240b4cdac5479812f9.
>>>
>>> In dib0700_core.c in struct dib0700_rc_response the following union:
>>>
>>> union {
>>>      u16 system16;
>>>      struct {
>>>          u8 not_system;
>>>          u8 system;
>>>      };
>>> };
>>>
>>> has been replaced by simple variables:
>>>
>>> u8 system;
>>> u8 not_system;
>>>
>>> But these variables are in reverse order! When I switch the order
>>> back, the remote works fine again! Here is the patch:
>>>
>>>
>>> --- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>>> 14:27:15.000000000 +0100
>>> +++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>>> 14:27:36.000000000 +0100
>>> @@ -658,8 +658,8 @@
>>>   struct dib0700_rc_response {
>>>       u8 report_id;
>>>       u8 data_state;
>>> -    u8 system;
>>>       u8 not_system;
>>> +    u8 system;
>>>       u8 data;
>>>       u8 not_data;
>>>   };
>>>
>>>
>>> Regards,
>>> David
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

-- 
http://palosaari.fi/

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Härdeman]

David C: are you using the in-kernel keymap or loading a custom one?

On 2015-02-10 11:45, Antti Palosaari wrote:
> David Härdeman,
> Could you look that as it is your patch which has broken it
> 
> commit af3a4a9bbeb00df3e42e77240b4cdac5479812f9
> Author: David Härdeman <david@hardeman.nu>
> Date:   Thu Apr 3 20:31:51 2014 -0300
> 
>     [media] dib0700: NEC scancode cleanup
> 
> 
> Antti
> 
> On 02/10/2015 12:38 PM, David Cimbůrek wrote:
>> Please include this patch to kernel! It takes too much time for such a
>> simple fix!
>> 
>> 
>> 2015-01-07 13:51 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>>> No one is interested? I'd like to get this patch to kernel to fix the
>>> issue. Can someone here do it please?
>>> 
>>> 
>>> 2014-12-20 14:36 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>>>> Hi,
>>>> 
>>>> with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
>>>> Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
>>>> anymore.
>>>> 
>>>> I checked the changes and found out the problem in commit
>>>> af3a4a9bbeb00df3e42e77240b4cdac5479812f9.
>>>> 
>>>> In dib0700_core.c in struct dib0700_rc_response the following union:
>>>> 
>>>> union {
>>>>      u16 system16;
>>>>      struct {
>>>>          u8 not_system;
>>>>          u8 system;
>>>>      };
>>>> };
>>>> 
>>>> has been replaced by simple variables:
>>>> 
>>>> u8 system;
>>>> u8 not_system;
>>>> 
>>>> But these variables are in reverse order! When I switch the order
>>>> back, the remote works fine again! Here is the patch:
>>>> 
>>>> 
>>>> --- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>>>> 14:27:15.000000000 +0100
>>>> +++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>>>> 14:27:36.000000000 +0100
>>>> @@ -658,8 +658,8 @@
>>>>   struct dib0700_rc_response {
>>>>       u8 report_id;
>>>>       u8 data_state;
>>>> -    u8 system;
>>>>       u8 not_system;
>>>> +    u8 system;
>>>>       u8 data;
>>>>       u8 not_data;
>>>>   };
>>>> 
>>>> 
>>>> Regards,
>>>> David
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" 
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> 

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Cimbůrek]

David Härdeman: I'm using defaults, I have no custom modifications.


2015-02-11 14:24 GMT+01:00 David Härdeman <david@hardeman.nu>:
> David C: are you using the in-kernel keymap or loading a custom one?
>
>
> On 2015-02-10 11:45, Antti Palosaari wrote:
>>
>> David Härdeman,
>> Could you look that as it is your patch which has broken it
>>
>> commit af3a4a9bbeb00df3e42e77240b4cdac5479812f9
>> Author: David Härdeman <david@hardeman.nu>
>> Date:   Thu Apr 3 20:31:51 2014 -0300
>>
>>     [media] dib0700: NEC scancode cleanup
>>
>>
>> Antti
>>
>> On 02/10/2015 12:38 PM, David Cimbůrek wrote:
>>>
>>> Please include this patch to kernel! It takes too much time for such a
>>> simple fix!
>>>
>>>
>>> 2015-01-07 13:51 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>>>>
>>>> No one is interested? I'd like to get this patch to kernel to fix the
>>>> issue. Can someone here do it please?
>>>>
>>>>
>>>> 2014-12-20 14:36 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>>>>>
>>>>> Hi,
>>>>>
>>>>> with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
>>>>> Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
>>>>> anymore.
>>>>>
>>>>> I checked the changes and found out the problem in commit
>>>>> af3a4a9bbeb00df3e42e77240b4cdac5479812f9.
>>>>>
>>>>> In dib0700_core.c in struct dib0700_rc_response the following union:
>>>>>
>>>>> union {
>>>>>      u16 system16;
>>>>>      struct {
>>>>>          u8 not_system;
>>>>>          u8 system;
>>>>>      };
>>>>> };
>>>>>
>>>>> has been replaced by simple variables:
>>>>>
>>>>> u8 system;
>>>>> u8 not_system;
>>>>>
>>>>> But these variables are in reverse order! When I switch the order
>>>>> back, the remote works fine again! Here is the patch:
>>>>>
>>>>>
>>>>> --- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>>>>> 14:27:15.000000000 +0100
>>>>> +++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>>>>> 14:27:36.000000000 +0100
>>>>> @@ -658,8 +658,8 @@
>>>>>   struct dib0700_rc_response {
>>>>>       u8 report_id;
>>>>>       u8 data_state;
>>>>> -    u8 system;
>>>>>       u8 not_system;
>>>>> +    u8 system;
>>>>>       u8 data;
>>>>>       u8 not_data;
>>>>>   };
>>>>>
>>>>>
>>>>> Regards,
>>>>> David
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Härdeman]

Can you generate some scancodes before and after commit 
af3a4a9bbeb00df3e42e77240b4cdac5479812f9?


On 2015-02-11 14:53, David Cimbůrek wrote:
> David Härdeman: I'm using defaults, I have no custom modifications.
> 
> 
> 2015-02-11 14:24 GMT+01:00 David Härdeman <david@hardeman.nu>:
>> David C: are you using the in-kernel keymap or loading a custom one?
>> 
>> 
>> On 2015-02-10 11:45, Antti Palosaari wrote:
>>> 
>>> David Härdeman,
>>> Could you look that as it is your patch which has broken it
>>> 
>>> commit af3a4a9bbeb00df3e42e77240b4cdac5479812f9
>>> Author: David Härdeman <david@hardeman.nu>
>>> Date:   Thu Apr 3 20:31:51 2014 -0300
>>> 
>>>     [media] dib0700: NEC scancode cleanup
>>> 
>>> 
>>> Antti
>>> 
>>> On 02/10/2015 12:38 PM, David Cimbůrek wrote:
>>>> 
>>>> Please include this patch to kernel! It takes too much time for such 
>>>> a
>>>> simple fix!
>>>> 
>>>> 
>>>> 2015-01-07 13:51 GMT+01:00 David Cimbůrek 
>>>> <david.cimburek@gmail.com>:
>>>>> 
>>>>> No one is interested? I'd like to get this patch to kernel to fix 
>>>>> the
>>>>> issue. Can someone here do it please?
>>>>> 
>>>>> 
>>>>> 2014-12-20 14:36 GMT+01:00 David Cimbůrek 
>>>>> <david.cimburek@gmail.com>:
>>>>>> 
>>>>>> Hi,
>>>>>> 
>>>>>> with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
>>>>>> Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
>>>>>> anymore.
>>>>>> 
>>>>>> I checked the changes and found out the problem in commit
>>>>>> af3a4a9bbeb00df3e42e77240b4cdac5479812f9.
>>>>>> 
>>>>>> In dib0700_core.c in struct dib0700_rc_response the following 
>>>>>> union:
>>>>>> 
>>>>>> union {
>>>>>>      u16 system16;
>>>>>>      struct {
>>>>>>          u8 not_system;
>>>>>>          u8 system;
>>>>>>      };
>>>>>> };
>>>>>> 
>>>>>> has been replaced by simple variables:
>>>>>> 
>>>>>> u8 system;
>>>>>> u8 not_system;
>>>>>> 
>>>>>> But these variables are in reverse order! When I switch the order
>>>>>> back, the remote works fine again! Here is the patch:
>>>>>> 
>>>>>> 
>>>>>> --- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>>>>>> 14:27:15.000000000 +0100
>>>>>> +++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>>>>>> 14:27:36.000000000 +0100
>>>>>> @@ -658,8 +658,8 @@
>>>>>>   struct dib0700_rc_response {
>>>>>>       u8 report_id;
>>>>>>       u8 data_state;
>>>>>> -    u8 system;
>>>>>>       u8 not_system;
>>>>>> +    u8 system;
>>>>>>       u8 data;
>>>>>>       u8 not_data;
>>>>>>   };
>>>>>> 
>>>>>> 
>>>>>> Regards,
>>>>>> David
>>>> 
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe 
>>>> linux-media" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>> 
>> 

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Cimbůrek]

Let me know what exactly do you want me to do (which commands, which
traces etc.). I'm not very familiar with the Linux media stuff...

2015-02-11 15:40 GMT+01:00 David Härdeman <david@hardeman.nu>:
> Can you generate some scancodes before and after commit
> af3a4a9bbeb00df3e42e77240b4cdac5479812f9?
>
>
>
> On 2015-02-11 14:53, David Cimbůrek wrote:
>>
>> David Härdeman: I'm using defaults, I have no custom modifications.
>>
>>
>> 2015-02-11 14:24 GMT+01:00 David Härdeman <david@hardeman.nu>:
>>>
>>> David C: are you using the in-kernel keymap or loading a custom one?
>>>
>>>
>>> On 2015-02-10 11:45, Antti Palosaari wrote:
>>>>
>>>>
>>>> David Härdeman,
>>>> Could you look that as it is your patch which has broken it
>>>>
>>>> commit af3a4a9bbeb00df3e42e77240b4cdac5479812f9
>>>> Author: David Härdeman <david@hardeman.nu>
>>>> Date:   Thu Apr 3 20:31:51 2014 -0300
>>>>
>>>>     [media] dib0700: NEC scancode cleanup
>>>>
>>>>
>>>> Antti
>>>>
>>>> On 02/10/2015 12:38 PM, David Cimbůrek wrote:
>>>>>
>>>>>
>>>>> Please include this patch to kernel! It takes too much time for such a
>>>>> simple fix!
>>>>>
>>>>>
>>>>> 2015-01-07 13:51 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>>>>>>
>>>>>>
>>>>>> No one is interested? I'd like to get this patch to kernel to fix the
>>>>>> issue. Can someone here do it please?
>>>>>>
>>>>>>
>>>>>> 2014-12-20 14:36 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>>>>>>>
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
>>>>>>> Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
>>>>>>> anymore.
>>>>>>>
>>>>>>> I checked the changes and found out the problem in commit
>>>>>>> af3a4a9bbeb00df3e42e77240b4cdac5479812f9.
>>>>>>>
>>>>>>> In dib0700_core.c in struct dib0700_rc_response the following union:
>>>>>>>
>>>>>>> union {
>>>>>>>      u16 system16;
>>>>>>>      struct {
>>>>>>>          u8 not_system;
>>>>>>>          u8 system;
>>>>>>>      };
>>>>>>> };
>>>>>>>
>>>>>>> has been replaced by simple variables:
>>>>>>>
>>>>>>> u8 system;
>>>>>>> u8 not_system;
>>>>>>>
>>>>>>> But these variables are in reverse order! When I switch the order
>>>>>>> back, the remote works fine again! Here is the patch:
>>>>>>>
>>>>>>>
>>>>>>> --- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>>>>>>> 14:27:15.000000000 +0100
>>>>>>> +++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>>>>>>> 14:27:36.000000000 +0100
>>>>>>> @@ -658,8 +658,8 @@
>>>>>>>   struct dib0700_rc_response {
>>>>>>>       u8 report_id;
>>>>>>>       u8 data_state;
>>>>>>> -    u8 system;
>>>>>>>       u8 not_system;
>>>>>>> +    u8 system;
>>>>>>>       u8 data;
>>>>>>>       u8 not_data;
>>>>>>>   };
>>>>>>>
>>>>>>>
>>>>>>> Regards,
>>>>>>> David
>>>>>
>>>>>
>>>>> --
>>>>> To unsubscribe from this list: send the line "unsubscribe linux-media"
>>>>> in
>>>>> the body of a message to majordomo@vger.kernel.org
>>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>>>
>>>
>

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[Luis de Bethencourt]

On Tue, Feb 10, 2015 at 11:38:11AM +0100, David Cimbůrek wrote:
> Please include this patch to kernel! It takes too much time for such a
> simple fix!
> 

The patch is simple but why it fixes the issue isn't that simple. Could you
explain why the order of the variables inside the structure is breaking things?

All the uses of the variables inside the structure that I can see are by name.
Not by memory offsets.

Thanks,
Luis

> 
> 2015-01-07 13:51 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
> > No one is interested? I'd like to get this patch to kernel to fix the
> > issue. Can someone here do it please?
> >
> >
> > 2014-12-20 14:36 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
> >> Hi,
> >>
> >> with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
> >> Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
> >> anymore.
> >>
> >> I checked the changes and found out the problem in commit
> >> af3a4a9bbeb00df3e42e77240b4cdac5479812f9.
> >>
> >> In dib0700_core.c in struct dib0700_rc_response the following union:
> >>
> >> union {
> >>     u16 system16;
> >>     struct {
> >>         u8 not_system;
> >>         u8 system;
> >>     };
> >> };
> >>
> >> has been replaced by simple variables:
> >>
> >> u8 system;
> >> u8 not_system;
> >>
> >> But these variables are in reverse order! When I switch the order
> >> back, the remote works fine again! Here is the patch:
> >>
> >>
> >> --- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
> >> 14:27:15.000000000 +0100
> >> +++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
> >> 14:27:36.000000000 +0100
> >> @@ -658,8 +658,8 @@
> >>  struct dib0700_rc_response {
> >>      u8 report_id;
> >>      u8 data_state;
> >> -    u8 system;
> >>      u8 not_system;
> >> +    u8 system;
> >>      u8 data;
> >>      u8 not_data;
> >>  };
> >>
> >>
> >> Regards,
> >> David
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Cimbůrek]

I'll try to describe my thoughts.

The changed structure "dib0700_rc_response" is used in
dib0700_core.c:dib0700_rc_urb_completion(struct urb *purb) function:

struct dib0700_rc_response *poll_reply;
...
poll_reply = purb->transfer_buffer;

dib0700_rc_urb_completion() is then used in
dib0700_core.c:dib0700_rc_setup() in macros usb_fill_bulk_urb and
usb_fill_int_urb. These macros are defined in header file usb.h. Here
I have found in macro description this:

 * @transfer_buffer: pointer to the transfer buffer

I suppose that it means that the struct dib0700_rc_response is being
filled from this transfer buffer. Therefore I suppose that the order
of structure members IS important.

Of course it's only my guess but my patch is really working for me :-)



2015-02-12 1:10 GMT+01:00 Luis de Bethencourt <luis@debethencourt.com>:
> On Tue, Feb 10, 2015 at 11:38:11AM +0100, David Cimbůrek wrote:
>> Please include this patch to kernel! It takes too much time for such a
>> simple fix!
>>
>
> The patch is simple but why it fixes the issue isn't that simple. Could you
> explain why the order of the variables inside the structure is breaking things?
>
> All the uses of the variables inside the structure that I can see are by name.
> Not by memory offsets.
>
> Thanks,
> Luis
>
>>
>> 2015-01-07 13:51 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>> > No one is interested? I'd like to get this patch to kernel to fix the
>> > issue. Can someone here do it please?
>> >
>> >
>> > 2014-12-20 14:36 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
>> >> Hi,
>> >>
>> >> with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
>> >> Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
>> >> anymore.
>> >>
>> >> I checked the changes and found out the problem in commit
>> >> af3a4a9bbeb00df3e42e77240b4cdac5479812f9.
>> >>
>> >> In dib0700_core.c in struct dib0700_rc_response the following union:
>> >>
>> >> union {
>> >>     u16 system16;
>> >>     struct {
>> >>         u8 not_system;
>> >>         u8 system;
>> >>     };
>> >> };
>> >>
>> >> has been replaced by simple variables:
>> >>
>> >> u8 system;
>> >> u8 not_system;
>> >>
>> >> But these variables are in reverse order! When I switch the order
>> >> back, the remote works fine again! Here is the patch:
>> >>
>> >>
>> >> --- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>> >> 14:27:15.000000000 +0100
>> >> +++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
>> >> 14:27:36.000000000 +0100
>> >> @@ -658,8 +658,8 @@
>> >>  struct dib0700_rc_response {
>> >>      u8 report_id;
>> >>      u8 data_state;
>> >> -    u8 system;
>> >>      u8 not_system;
>> >> +    u8 system;
>> >>      u8 data;
>> >>      u8 not_data;
>> >>  };
>> >>
>> >>
>> >> Regards,
>> >> David
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[Luis de Bethencourt]

On Thu, Feb 12, 2015 at 08:15:10AM +0100, David Cimbůrek wrote:
> I'll try to describe my thoughts.
> 
> The changed structure "dib0700_rc_response" is used in
> dib0700_core.c:dib0700_rc_urb_completion(struct urb *purb) function:
> 
> struct dib0700_rc_response *poll_reply;
> ...
> poll_reply = purb->transfer_buffer;
> 
> dib0700_rc_urb_completion() is then used in
> dib0700_core.c:dib0700_rc_setup() in macros usb_fill_bulk_urb and
> usb_fill_int_urb. These macros are defined in header file usb.h. Here
> I have found in macro description this:
> 
>  * @transfer_buffer: pointer to the transfer buffer
> 
> I suppose that it means that the struct dib0700_rc_response is being
> filled from this transfer buffer. Therefore I suppose that the order
> of structure members IS important.
> 
> Of course it's only my guess but my patch is really working for me :-)
> 

Hi David,

I am away from the keyboard most of today. Busy with a training.

I will follow the code you describe as soon as I can in a few hours and report
back.

Thanks,
Luis

> 
> 
> 2015-02-12 1:10 GMT+01:00 Luis de Bethencourt <luis@debethencourt.com>:
> > On Tue, Feb 10, 2015 at 11:38:11AM +0100, David Cimbůrek wrote:
> >> Please include this patch to kernel! It takes too much time for such a
> >> simple fix!
> >>
> >
> > The patch is simple but why it fixes the issue isn't that simple. Could you
> > explain why the order of the variables inside the structure is breaking things?
> >
> > All the uses of the variables inside the structure that I can see are by name.
> > Not by memory offsets.
> >
> > Thanks,
> > Luis
> >
> >>
> >> 2015-01-07 13:51 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
> >> > No one is interested? I'd like to get this patch to kernel to fix the
> >> > issue. Can someone here do it please?
> >> >
> >> >
> >> > 2014-12-20 14:36 GMT+01:00 David Cimbůrek <david.cimburek@gmail.com>:
> >> >> Hi,
> >> >>
> >> >> with kernel 3.17 remote control for Pinnacle 73e (ID 2304:0237
> >> >> Pinnacle Systems, Inc. PCTV 73e [DiBcom DiB7000PC]) does not work
> >> >> anymore.
> >> >>
> >> >> I checked the changes and found out the problem in commit
> >> >> af3a4a9bbeb00df3e42e77240b4cdac5479812f9.
> >> >>
> >> >> In dib0700_core.c in struct dib0700_rc_response the following union:
> >> >>
> >> >> union {
> >> >>     u16 system16;
> >> >>     struct {
> >> >>         u8 not_system;
> >> >>         u8 system;
> >> >>     };
> >> >> };
> >> >>
> >> >> has been replaced by simple variables:
> >> >>
> >> >> u8 system;
> >> >> u8 not_system;
> >> >>
> >> >> But these variables are in reverse order! When I switch the order
> >> >> back, the remote works fine again! Here is the patch:
> >> >>
> >> >>
> >> >> --- a/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
> >> >> 14:27:15.000000000 +0100
> >> >> +++ b/drivers/media/usb/dvb-usr/dib0700_core.c    2014-12-20
> >> >> 14:27:36.000000000 +0100
> >> >> @@ -658,8 +658,8 @@
> >> >>  struct dib0700_rc_response {
> >> >>      u8 report_id;
> >> >>      u8 data_state;
> >> >> -    u8 system;
> >> >>      u8 not_system;
> >> >> +    u8 system;
> >> >>      u8 data;
> >> >>      u8 not_data;
> >> >>  };
> >> >>
> >> >>
> >> >> Regards,
> >> >> David
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[Mauro Carvalho Chehab]

Em Wed, 11 Feb 2015 17:41:01 +0100
David Cimbůrek <david.cimburek@gmail.com> escreveu:

Please don't top post. I reordered the messages below in order to get some
sanity.

> 
> 2015-02-11 15:40 GMT+01:00 David Härdeman <david@hardeman.nu>:
> > Can you generate some scancodes before and after commit
> > af3a4a9bbeb00df3e42e77240b4cdac5479812f9?
>
> Let me know what exactly do you want me to do (which commands, which
> traces etc.). I'm not very familiar with the Linux media stuff...

As root, you should run:

	# ir-keytable -r

This will print the scancodes and their key associations.

Also, on what architecture are you testing?

Regards,
Mauro

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Cimbůrek]

2015-02-12 12:50 GMT+01:00 Mauro Carvalho Chehab <mchehab@osg.samsung.com>:
> Em Wed, 11 Feb 2015 17:41:01 +0100
> David Cimbůrek <david.cimburek@gmail.com> escreveu:
>
> Please don't top post. I reordered the messages below in order to get some
> sanity.
>
>>
>> 2015-02-11 15:40 GMT+01:00 David Härdeman <david@hardeman.nu>:
>> > Can you generate some scancodes before and after commit
>> > af3a4a9bbeb00df3e42e77240b4cdac5479812f9?
>>
>> Let me know what exactly do you want me to do (which commands, which
>> traces etc.). I'm not very familiar with the Linux media stuff...
>
> As root, you should run:
>
>         # ir-keytable -r
>
> This will print the scancodes and their key associations.
>
> Also, on what architecture are you testing?
>
> Regards,
> Mauro

Output of the "ir-keytable -r" is available here:
http://pastebin.com/eEDu1Bmn. It is the same before and after the
patch.

Architecture is x86_64.

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[Luis de Bethencourt]

On Thu, Feb 12, 2015 at 06:34:40PM +0100, David Cimbůrek wrote:
> 2015-02-12 12:50 GMT+01:00 Mauro Carvalho Chehab <mchehab@osg.samsung.com>:
> > Em Wed, 11 Feb 2015 17:41:01 +0100
> > David Cimbůrek <david.cimburek@gmail.com> escreveu:
> >
> > Please don't top post. I reordered the messages below in order to get some
> > sanity.
> >
> >>
> >> 2015-02-11 15:40 GMT+01:00 David Härdeman <david@hardeman.nu>:
> >> > Can you generate some scancodes before and after commit
> >> > af3a4a9bbeb00df3e42e77240b4cdac5479812f9?
> >>
> >> Let me know what exactly do you want me to do (which commands, which
> >> traces etc.). I'm not very familiar with the Linux media stuff...
> >
> > As root, you should run:
> >
> >         # ir-keytable -r
> >
> > This will print the scancodes and their key associations.
> >
> > Also, on what architecture are you testing?
> >
> > Regards,
> > Mauro
> 
> Output of the "ir-keytable -r" is available here:
> http://pastebin.com/eEDu1Bmn. It is the same before and after the
> patch.
> 
> Architecture is x86_64.
>
>

>From the top-posted thread. Merging it here to not confuse people.

> I'll try to describe my thoughts.
> 
> The changed structure "dib0700_rc_response" is used in
> dib0700_core.c:dib0700_rc_urb_completion(struct urb *purb) function:
> 
> struct dib0700_rc_response *poll_reply;
> ...
> poll_reply = purb->transfer_buffer;
> 
> dib0700_rc_urb_completion() is then used in
> dib0700_core.c:dib0700_rc_setup() in macros usb_fill_bulk_urb and
> usb_fill_int_urb. These macros are defined in header file usb.h. Here
> I have found in macro description this:
> 
>  * @transfer_buffer: pointer to the transfer buffer
> 
> I suppose that it means that the struct dib0700_rc_response is being
> filled from this transfer buffer. Therefore I suppose that the order
> of structure members IS important.
> 
> Of course it's only my guess but my patch is really working for me :-)

Hi,

I looked at this again and I still don't see why the order is important.
Plus the code looks like it does what it should be doing when using
RC_SCANCODE_NEC, RC_SCANCODE_NEC32, RC_SCANCODE_NECX and RC_SCANCODE_RC5.

Unfortunately I can't review this if I am not sure about it, and I don't
have the device to be able to properly test your patch.

Hopefully your print of the scancodes helps.

Luis

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Cimbůrek]

2015-02-12 22:57 GMT+01:00 Luis de Bethencourt <luis@debethencourt.com>:
> On Thu, Feb 12, 2015 at 06:34:40PM +0100, David Cimbůrek wrote:
>> 2015-02-12 12:50 GMT+01:00 Mauro Carvalho Chehab <mchehab@osg.samsung.com>:
>> > Em Wed, 11 Feb 2015 17:41:01 +0100
>> > David Cimbůrek <david.cimburek@gmail.com> escreveu:
>> >
>> > Please don't top post. I reordered the messages below in order to get some
>> > sanity.
>> >
>> >>
>> >> 2015-02-11 15:40 GMT+01:00 David Härdeman <david@hardeman.nu>:
>> >> > Can you generate some scancodes before and after commit
>> >> > af3a4a9bbeb00df3e42e77240b4cdac5479812f9?
>> >>
>> >> Let me know what exactly do you want me to do (which commands, which
>> >> traces etc.). I'm not very familiar with the Linux media stuff...
>> >
>> > As root, you should run:
>> >
>> >         # ir-keytable -r
>> >
>> > This will print the scancodes and their key associations.
>> >
>> > Also, on what architecture are you testing?
>> >
>> > Regards,
>> > Mauro
>>
>> Output of the "ir-keytable -r" is available here:
>> http://pastebin.com/eEDu1Bmn. It is the same before and after the
>> patch.
>>
>> Architecture is x86_64.
>>
>>
>
> From the top-posted thread. Merging it here to not confuse people.
>
>> I'll try to describe my thoughts.
>>
>> The changed structure "dib0700_rc_response" is used in
>> dib0700_core.c:dib0700_rc_urb_completion(struct urb *purb) function:
>>
>> struct dib0700_rc_response *poll_reply;
>> ...
>> poll_reply = purb->transfer_buffer;
>>
>> dib0700_rc_urb_completion() is then used in
>> dib0700_core.c:dib0700_rc_setup() in macros usb_fill_bulk_urb and
>> usb_fill_int_urb. These macros are defined in header file usb.h. Here
>> I have found in macro description this:
>>
>>  * @transfer_buffer: pointer to the transfer buffer
>>
>> I suppose that it means that the struct dib0700_rc_response is being
>> filled from this transfer buffer. Therefore I suppose that the order
>> of structure members IS important.
>>
>> Of course it's only my guess but my patch is really working for me :-)
>
> Hi,
>
> I looked at this again and I still don't see why the order is important.
> Plus the code looks like it does what it should be doing when using
> RC_SCANCODE_NEC, RC_SCANCODE_NEC32, RC_SCANCODE_NECX and RC_SCANCODE_RC5.
>
> Unfortunately I can't review this if I am not sure about it, and I don't
> have the device to be able to properly test your patch.
>
> Hopefully your print of the scancodes helps.
>
> Luis

Hi,

unfortunately I don't understand the code very well but it really
works like I described.

I tried to get debugging output from the
dib0700_core.c:dib0700_rc_urb_completion() function:

deb_data("IR ID = %02X state = %02X System = %02X %02X Cmd = %02X %02X
(len %d)\n",
        poll_reply->report_id, poll_reply->data_state,
        poll_reply->system, poll_reply->not_system,
        poll_reply->data, poll_reply->not_data,
        purb->actual_length);

And the output after my patch (and before commit
af3a4a9bbeb00df3e42e77240b4cdac5479812f9!) looks like this:

[  282.842557] IR ID = 01 state = 01 System = 07 00 Cmd = 0F F0 (len 6)
[  282.955810] IR ID = 01 state = 02 System = 07 00 Cmd = 0F F0 (len 6)

But without my patch the output looks after commit
af3a4a9bbeb00df3e42e77240b4cdac5479812f9 like this:

[  186.302282] IR ID = 01 state = 01 System = 00 07 Cmd = 0F F0 (len 6)
[  186.415660] IR ID = 01 state = 02 System = 00 07 Cmd = 0F F0 (len 6)

You can see that the content of "system" and "not_system" is really switched...

Regards,
David

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Cimbůrek]

>> Hi,
>>
>> I looked at this again and I still don't see why the order is important.
>> Plus the code looks like it does what it should be doing when using
>> RC_SCANCODE_NEC, RC_SCANCODE_NEC32, RC_SCANCODE_NECX and RC_SCANCODE_RC5.
>>
>> Unfortunately I can't review this if I am not sure about it, and I don't
>> have the device to be able to properly test your patch.
>>
>> Hopefully your print of the scancodes helps.
>>
>> Luis
>
> Hi,
>
> unfortunately I don't understand the code very well but it really
> works like I described.
>
> I tried to get debugging output from the
> dib0700_core.c:dib0700_rc_urb_completion() function:
>
> deb_data("IR ID = %02X state = %02X System = %02X %02X Cmd = %02X %02X
> (len %d)\n",
>         poll_reply->report_id, poll_reply->data_state,
>         poll_reply->system, poll_reply->not_system,
>         poll_reply->data, poll_reply->not_data,
>         purb->actual_length);
>
> And the output after my patch (and before commit
> af3a4a9bbeb00df3e42e77240b4cdac5479812f9!) looks like this:
>
> [  282.842557] IR ID = 01 state = 01 System = 07 00 Cmd = 0F F0 (len 6)
> [  282.955810] IR ID = 01 state = 02 System = 07 00 Cmd = 0F F0 (len 6)
>
> But without my patch the output looks after commit
> af3a4a9bbeb00df3e42e77240b4cdac5479812f9 like this:
>
> [  186.302282] IR ID = 01 state = 01 System = 00 07 Cmd = 0F F0 (len 6)
> [  186.415660] IR ID = 01 state = 02 System = 00 07 Cmd = 0F F0 (len 6)
>
> You can see that the content of "system" and "not_system" is really switched...
>
> Regards,
> David

Is there anything more I can do? Shall I provide some more debugging
outputs? There is no response nearly for two weeks...

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Härdeman]

On 2015-02-24 11:08, David Cimbůrek wrote:
>>> Hi,
>>> 
>>> I looked at this again and I still don't see why the order is 
>>> important.
>>> Plus the code looks like it does what it should be doing when using
>>> RC_SCANCODE_NEC, RC_SCANCODE_NEC32, RC_SCANCODE_NECX and 
>>> RC_SCANCODE_RC5.
>>> 
>>> Unfortunately I can't review this if I am not sure about it, and I 
>>> don't
>>> have the device to be able to properly test your patch.
>>> 
>>> Hopefully your print of the scancodes helps.
>>> 
>>> Luis
>> 
>> Hi,
>> 
>> unfortunately I don't understand the code very well but it really
>> works like I described.
>> 
>> I tried to get debugging output from the
>> dib0700_core.c:dib0700_rc_urb_completion() function:
>> 
>> deb_data("IR ID = %02X state = %02X System = %02X %02X Cmd = %02X %02X
>> (len %d)\n",
>>         poll_reply->report_id, poll_reply->data_state,
>>         poll_reply->system, poll_reply->not_system,
>>         poll_reply->data, poll_reply->not_data,
>>         purb->actual_length);
>> 
>> And the output after my patch (and before commit
>> af3a4a9bbeb00df3e42e77240b4cdac5479812f9!) looks like this:
>> 
>> [  282.842557] IR ID = 01 state = 01 System = 07 00 Cmd = 0F F0 (len 
>> 6)
>> [  282.955810] IR ID = 01 state = 02 System = 07 00 Cmd = 0F F0 (len 
>> 6)
>> 
>> But without my patch the output looks after commit
>> af3a4a9bbeb00df3e42e77240b4cdac5479812f9 like this:
>> 
>> [  186.302282] IR ID = 01 state = 01 System = 00 07 Cmd = 0F F0 (len 
>> 6)
>> [  186.415660] IR ID = 01 state = 02 System = 00 07 Cmd = 0F F0 (len 
>> 6)
>> 
>> You can see that the content of "system" and "not_system" is really 
>> switched...
>> 
>> Regards,
>> David
> 
> Is there anything more I can do? Shall I provide some more debugging
> outputs? There is no response nearly for two weeks...

Sorry, I'm just really busy.

The output that you gave (the actual scancodes that are generated) is 
what I was looking for, not the keymap. If I remember correctly my patch 
wasn't supposed to change the generated scancodes (or the keymap would 
have to be changed as well).

The question is whether the right thing to do is to change back the 
scancode calculation or to update the keymap. I'll try to have a closer 
look as soon as possible (which might take a few days more, sorry).

Re,
David

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[Mauro Carvalho Chehab]

Em Tue, 24 Feb 2015 11:15:53 +0100
David Härdeman <david@hardeman.nu> escreveu:

> On 2015-02-24 11:08, David Cimbůrek wrote:
> >>> Hi,
> >>> 
> >>> I looked at this again and I still don't see why the order is 
> >>> important.
> >>> Plus the code looks like it does what it should be doing when using
> >>> RC_SCANCODE_NEC, RC_SCANCODE_NEC32, RC_SCANCODE_NECX and 
> >>> RC_SCANCODE_RC5.
> >>> 
> >>> Unfortunately I can't review this if I am not sure about it, and I 
> >>> don't
> >>> have the device to be able to properly test your patch.
> >>> 
> >>> Hopefully your print of the scancodes helps.
> >>> 
> >>> Luis
> >> 
> >> Hi,
> >> 
> >> unfortunately I don't understand the code very well but it really
> >> works like I described.
> >> 
> >> I tried to get debugging output from the
> >> dib0700_core.c:dib0700_rc_urb_completion() function:
> >> 
> >> deb_data("IR ID = %02X state = %02X System = %02X %02X Cmd = %02X %02X
> >> (len %d)\n",
> >>         poll_reply->report_id, poll_reply->data_state,
> >>         poll_reply->system, poll_reply->not_system,
> >>         poll_reply->data, poll_reply->not_data,
> >>         purb->actual_length);
> >> 
> >> And the output after my patch (and before commit
> >> af3a4a9bbeb00df3e42e77240b4cdac5479812f9!) looks like this:
> >> 
> >> [  282.842557] IR ID = 01 state = 01 System = 07 00 Cmd = 0F F0 (len 
> >> 6)
> >> [  282.955810] IR ID = 01 state = 02 System = 07 00 Cmd = 0F F0 (len 
> >> 6)
> >> 
> >> But without my patch the output looks after commit
> >> af3a4a9bbeb00df3e42e77240b4cdac5479812f9 like this:
> >> 
> >> [  186.302282] IR ID = 01 state = 01 System = 00 07 Cmd = 0F F0 (len 
> >> 6)
> >> [  186.415660] IR ID = 01 state = 02 System = 00 07 Cmd = 0F F0 (len 
> >> 6)
> >> 
> >> You can see that the content of "system" and "not_system" is really 
> >> switched...
> >> 
> >> Regards,
> >> David
> > 
> > Is there anything more I can do? Shall I provide some more debugging
> > outputs? There is no response nearly for two weeks...
> 
> Sorry, I'm just really busy.
> 
> The output that you gave (the actual scancodes that are generated) is 
> what I was looking for, not the keymap. If I remember correctly my patch 
> wasn't supposed to change the generated scancodes (or the keymap would 
> have to be changed as well).
> 
> The question is whether the right thing to do is to change back the 
> scancode calculation or to update the keymap. I'll try to have a closer 
> look as soon as possible (which might take a few days more, sorry).

I suspect we should change back the scancode calculation, as I think that
the scancode table is right, but I need to do some tests with some other
driver to be certain.

I have a few devices here that I can use for testing, including a PCTV
remote, just lacking the time.

> 
> Re,
> David
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] media: Pinnacle 73e infrared control stopped working since kernel 3.17

[David Härdeman]

On 2015-02-24 14:44, Mauro Carvalho Chehab wrote:
> Em Tue, 24 Feb 2015 11:15:53 +0100
> David Härdeman <david@hardeman.nu> escreveu:
>> The output that you gave (the actual scancodes that are generated) is
>> what I was looking for, not the keymap. If I remember correctly my 
>> patch
>> wasn't supposed to change the generated scancodes (or the keymap would
>> have to be changed as well).
>> 
>> The question is whether the right thing to do is to change back the
>> scancode calculation or to update the keymap. I'll try to have a 
>> closer
>> look as soon as possible (which might take a few days more, sorry).
> 
> I suspect we should change back the scancode calculation, as I think 
> that
> the scancode table is right, but I need to do some tests with some 
> other
> driver to be certain.
> 
> I have a few devices here that I can use for testing, including a PCTV
> remote, just lacking the time.

I've exchanged a few more emails with David. I think I know what the 
problem is now. It's not the NEC scancode generation, it's that my patch 
accidentally broke the RC5 case (his remote is an RC5 one). I'll post a 
patch later.