Re: [PATCH v2] media: staging/intel-ipu3: make imgu use fixed running mode

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hi Bingbu,

On Thu, Jan 09, 2020 at 12:37:07PM +0800, Bingbu Cao wrote:
> 
> 
> On 1/9/20 12:06 PM, Tomasz Figa wrote:
> > On Thu, Jan 9, 2020 at 12:58 PM Bingbu Cao <bingbu.cao@linux.intel.com> wrote:
> >>
> >>
> >>
> >> On 1/8/20 8:57 PM, Tomasz Figa wrote:
> >>> On Mon, Dec 30, 2019 at 6:21 PM Bingbu Cao <bingbu.cao@intel.com> wrote:
> >>>>
> >>>> Currently, the imgu running mode need user to set by v4l2 ctrl.
> >>>> However, imgu only support 2 pipes and 2 operation modes - video and
> >>>> still. This patch make the first imgu subdev running as video and second
> >>>> one running as still, it will make the user understand easily, it can
> >>>> also cover current camera use cases requirement. The running mode is set
> >>>> during subdev registering, no race-condition after change, so it is safe
> >>>> to change the mode data type to integer.
> >>>>
> >>>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> >>>> ---
> >>>>  Documentation/media/v4l-drivers/ipu3.rst        |  6 +-
> >>>>  drivers/staging/media/ipu3/include/intel-ipu3.h |  4 --
> >>>>  drivers/staging/media/ipu3/ipu3-v4l2.c          | 74 +++----------------------
> >>>>  drivers/staging/media/ipu3/ipu3.h               |  5 +-
> >>>>  4 files changed, 12 insertions(+), 77 deletions(-)
> >>>>
> >>>
> >>> Doesn't it make it impossible to use two video (aka fast) pipes?
> >> Hi, Tomasz,
> >> Yes, once applying this patch, you can not run two video pipes with same input.
> >> I have no idea what are fast pipes and which scenario need two video pipes if
> >> the driver did not support multiple camera?
> > 
> > Processing in video pipes is faster than in still pipes and so one
> > could still want to use two video pipes for lower system load and thus
> > also lower power consumption, even for a single camera scenario, but
> > with ZSL.
> > 
> > That said, AFAICT CIO2 wouldn't have problems handling 2 raw captures,
> > so why would we want to prevent anyone from having 2 video pipes for 2
> > different cameras?
> Tomasz, your comments make sense for me. we can not limit the usage.
> 
> Sakari,
> Do you have comments on that? Could we revert this patch?

Please send a revert if you feel like it.

-- 
Regards,

Sakari Ailus