From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Yong Zhi <yong.zhi@intel.com>, Bingbu Cao <bingbu.cao@intel.com>,
Tian Shu Qiu <tian.shu.qiu@intel.com>,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/7] media: ipu3-cio2: Simplify cleanup code
Date: Fri, 14 Aug 2020 23:16:17 +0300 [thread overview]
Message-ID: <20200814201617.GE24582@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20200814163017.35001-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
Thanks for the patchset.
On Fri, Aug 14, 2020 at 07:30:11PM +0300, Andy Shevchenko wrote:
> The code looks more nicer if we use:
> while (i--)
> instead:
> for (i = i - 1; i >= 0; i--)
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index 92f5eadf2c99..c7c3692a6e72 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -887,7 +887,7 @@ static int cio2_vb2_buf_init(struct vb2_buffer *vb)
> b->lop[i][j] = cio2->dummy_page_bus_addr >> PAGE_SHIFT;
> return 0;
> fail:
> - for (i--; i >= 0; i--)
> + while (i--)
Nice! This would also allow making i unsigned again.
> dma_free_coherent(dev, CIO2_PAGE_SIZE,
> b->lop[i], b->lop_bus_addr[i]);
> return -ENOMEM;
--
Sakari Ailus
next prev parent reply other threads:[~2020-08-14 20:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 16:30 [PATCH v1 1/7] media: ipu3-cio2: Simplify cleanup code Andy Shevchenko
2020-08-14 16:30 ` [PATCH v1 2/7] media: ipu3-cio2: Introduce CIO2_MAX_ENTRIES constant Andy Shevchenko
2020-08-14 20:18 ` Sakari Ailus
2020-08-17 11:46 ` Andy Shevchenko
2020-08-14 16:30 ` [PATCH v1 3/7] media: ipu2-cio2: Replace custom definition with PAGE_SIZE Andy Shevchenko
2020-08-14 16:30 ` [PATCH v1 4/7] media: ipu3-cio2: Use macros from pfn.h Andy Shevchenko
2020-08-14 16:30 ` [PATCH v1 5/7] media: ipu3-cio2: Replace infinite loop by one with clear exit condition Andy Shevchenko
2020-08-17 10:21 ` Bingbu Cao
2020-08-17 11:47 ` Andy Shevchenko
2020-08-14 16:30 ` [PATCH v1 6/7] media: ipu3-cio2: Use readl_poll_timeout() helper Andy Shevchenko
2020-08-17 9:27 ` Bingbu Cao
2020-08-17 9:44 ` Andy Shevchenko
2020-08-17 11:13 ` Sakari Ailus
2020-08-17 11:20 ` Andy Shevchenko
2020-08-17 11:27 ` Sakari Ailus
2020-08-17 11:33 ` Andy Shevchenko
2020-08-17 11:55 ` Sakari Ailus
2020-08-17 12:29 ` Andy Shevchenko
2020-08-17 12:44 ` Sakari Ailus
2020-08-14 16:30 ` [PATCH v1 7/7] media: ipu3-cio2: Update Copyright year and fix indentation issues Andy Shevchenko
2020-08-14 20:16 ` Sakari Ailus [this message]
2020-08-17 14:37 ` [PATCH v1 1/7] media: ipu3-cio2: Simplify cleanup code Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814201617.GE24582@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox