public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Scally <djrscally@gmail.com>
To: djrscally@gmail.com, sakari.ailus@linux.intel.com,
	paul.kocialkowski@bootlin.com, ezequiel@collabora.com,
	hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org
Cc: yong.zhi@intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com,
	kevin.lhopital@bootlin.com, yang.lee@linux.alibaba.com,
	andy.shevchenko@gmail.com, laurent.pinchart@ideasonboard.com,
	kieran.bingham@ideasonboard.com
Subject: [PATCH v2 10/12] media: i2c: Add controls from fwnode to ov8865
Date: Mon,  9 Aug 2021 23:58:43 +0100	[thread overview]
Message-ID: <20210809225845.916430-11-djrscally@gmail.com> (raw)
In-Reply-To: <20210809225845.916430-1-djrscally@gmail.com>

Add V4L2_CID_CAMERA_ORIENTATION and V4L2_CID_CAMERA_SENSOR_ROTATION
controls to the ov8865 driver by attempting to parse them from firmware.

Signed-off-by: Daniel Scally <djrscally@gmail.com>
---
Changes in v2:

	- None

 drivers/media/i2c/ov8865.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
index 70747552e32a..d7926cadce70 100644
--- a/drivers/media/i2c/ov8865.c
+++ b/drivers/media/i2c/ov8865.c
@@ -2519,6 +2519,7 @@ static int ov8865_ctrls_init(struct ov8865_sensor *sensor)
 	struct v4l2_ctrl_handler *handler = &ctrls->handler;
 	const struct v4l2_ctrl_ops *ops = &ov8865_ctrl_ops;
 	const struct ov8865_mode *mode = sensor->state.mode;
+	struct v4l2_fwnode_device_properties props;
 	unsigned int vblank_max, vblank_def;
 	unsigned int hblank;
 	int ret;
@@ -2581,6 +2582,15 @@ static int ov8865_ctrls_init(struct ov8865_sensor *sensor)
 		v4l2_ctrl_new_std(handler, NULL, V4L2_CID_PIXEL_RATE, 1,
 				  INT_MAX, 1, 1);
 
+	/* set properties from fwnode (e.g. rotation, orientation) */
+	ret = v4l2_fwnode_device_parse(sensor->dev, &props);
+	if (ret)
+		goto error_ctrls;
+
+	ret = v4l2_ctrl_new_fwnode_properties(handler, ops, &props);
+	if (ret)
+		goto error_ctrls;
+
 	if (handler->error) {
 		ret = handler->error;
 		goto error_ctrls;
-- 
2.25.1


  parent reply	other threads:[~2021-08-09 22:59 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 22:58 [PATCH v2 00/12] Extensions to ov8865 driver Daniel Scally
2021-08-09 22:58 ` [PATCH v2 01/12] media: i2c: Add ACPI support to ov8865 Daniel Scally
2021-08-10 12:57   ` Andy Shevchenko
2021-08-09 22:58 ` [PATCH v2 02/12] media: i2c: Fix incorrect value in comment Daniel Scally
2021-08-09 22:58 ` [PATCH v2 03/12] media: i2c: Defer probe if not endpoint found Daniel Scally
2021-08-09 22:58 ` [PATCH v2 04/12] media: i2c: Support 19.2MHz input clock in ov8865 Daniel Scally
2021-08-10 13:04   ` Andy Shevchenko
2021-08-10 21:46     ` Daniel Scally
2021-08-10 13:34   ` Sakari Ailus
2021-08-10 21:37     ` Daniel Scally
2021-08-10 21:49       ` Sakari Ailus
2021-09-07 22:44         ` Daniel Scally
2021-09-08  6:52           ` Sakari Ailus
2021-08-09 22:58 ` [PATCH v2 05/12] media: i2c: Add .get_selection() support to ov8865 Daniel Scally
2021-08-10 13:38   ` Sakari Ailus
2021-08-24 23:17     ` Daniel Scally
2021-08-25  7:16       ` Sakari Ailus
2021-08-25  8:04         ` Laurent Pinchart
2021-08-25  8:29           ` Sakari Ailus
2021-08-09 22:58 ` [PATCH v2 06/12] media: i2c: Switch control to V4L2_CID_ANALOGUE_GAIN Daniel Scally
2021-08-10 13:48   ` Sakari Ailus
2021-08-09 22:58 ` [PATCH v2 07/12] media: i2c: Add vblank control to ov8865 Daniel Scally
2021-08-09 22:58 ` [PATCH v2 08/12] media: i2c: Add hblank " Daniel Scally
2021-08-10 13:10   ` Andy Shevchenko
2021-08-10 14:29   ` Sakari Ailus
2021-08-10 22:07     ` Daniel Scally
2021-08-13  3:05       ` Laurent Pinchart
2021-08-13  9:45         ` Daniel Scally
2021-08-14 20:56           ` Laurent Pinchart
2021-09-09 22:36             ` Daniel Scally
2021-10-09 23:10               ` Daniel Scally
2021-08-09 22:58 ` [PATCH v2 09/12] media: i2c: cap exposure at height + vblank in ov8865 Daniel Scally
2021-08-10 14:30   ` Sakari Ailus
2021-08-09 22:58 ` Daniel Scally [this message]
2021-08-09 22:58 ` [PATCH v2 11/12] media: i2c: Switch exposure control unit to lines Daniel Scally
2021-08-09 22:58 ` [PATCH v2 12/12] media: ipu3-cio2: Add INT347A to cio2-bridge Daniel Scally
2021-08-10 13:12   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210809225845.916430-11-djrscally@gmail.com \
    --to=djrscally@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bingbu.cao@intel.com \
    --cc=ezequiel@collabora.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kevin.lhopital@bootlin.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tian.shu.qiu@intel.com \
    --cc=yang.lee@linux.alibaba.com \
    --cc=yong.zhi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox