From: Daniel Scally <djrscally@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
yong.zhi@intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com,
kevin.lhopital@bootlin.com, yang.lee@linux.alibaba.com,
laurent.pinchart@ideasonboard.com,
kieran.bingham@ideasonboard.com
Subject: Re: [PATCH v2 04/12] media: i2c: Support 19.2MHz input clock in ov8865
Date: Tue, 10 Aug 2021 22:46:40 +0100 [thread overview]
Message-ID: <a4c5592a-2350-9abb-b9c0-143ee6a028af@gmail.com> (raw)
In-Reply-To: <CAHp75VfXjWkBLsxmDY6DtaU0cZjVsQntp2Q99hZkguWz6PQy9A@mail.gmail.com>
Hi Andy
On 10/08/2021 14:04, Andy Shevchenko wrote:
>> + ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency",
>> + &rate);
>> + if (!ret) {
> I'm wondering if something like
>
> ... rate = 0;
>
> fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", &rate);
> if (rate > 0) {
>
> can be used.
Should be fine, and I agree that it makes the point of the check more
clear, thanks.
next prev parent reply other threads:[~2021-08-10 21:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 22:58 [PATCH v2 00/12] Extensions to ov8865 driver Daniel Scally
2021-08-09 22:58 ` [PATCH v2 01/12] media: i2c: Add ACPI support to ov8865 Daniel Scally
2021-08-10 12:57 ` Andy Shevchenko
2021-08-09 22:58 ` [PATCH v2 02/12] media: i2c: Fix incorrect value in comment Daniel Scally
2021-08-09 22:58 ` [PATCH v2 03/12] media: i2c: Defer probe if not endpoint found Daniel Scally
2021-08-09 22:58 ` [PATCH v2 04/12] media: i2c: Support 19.2MHz input clock in ov8865 Daniel Scally
2021-08-10 13:04 ` Andy Shevchenko
2021-08-10 21:46 ` Daniel Scally [this message]
2021-08-10 13:34 ` Sakari Ailus
2021-08-10 21:37 ` Daniel Scally
2021-08-10 21:49 ` Sakari Ailus
2021-09-07 22:44 ` Daniel Scally
2021-09-08 6:52 ` Sakari Ailus
2021-08-09 22:58 ` [PATCH v2 05/12] media: i2c: Add .get_selection() support to ov8865 Daniel Scally
2021-08-10 13:38 ` Sakari Ailus
2021-08-24 23:17 ` Daniel Scally
2021-08-25 7:16 ` Sakari Ailus
2021-08-25 8:04 ` Laurent Pinchart
2021-08-25 8:29 ` Sakari Ailus
2021-08-09 22:58 ` [PATCH v2 06/12] media: i2c: Switch control to V4L2_CID_ANALOGUE_GAIN Daniel Scally
2021-08-10 13:48 ` Sakari Ailus
2021-08-09 22:58 ` [PATCH v2 07/12] media: i2c: Add vblank control to ov8865 Daniel Scally
2021-08-09 22:58 ` [PATCH v2 08/12] media: i2c: Add hblank " Daniel Scally
2021-08-10 13:10 ` Andy Shevchenko
2021-08-10 14:29 ` Sakari Ailus
2021-08-10 22:07 ` Daniel Scally
2021-08-13 3:05 ` Laurent Pinchart
2021-08-13 9:45 ` Daniel Scally
2021-08-14 20:56 ` Laurent Pinchart
2021-09-09 22:36 ` Daniel Scally
2021-10-09 23:10 ` Daniel Scally
2021-08-09 22:58 ` [PATCH v2 09/12] media: i2c: cap exposure at height + vblank in ov8865 Daniel Scally
2021-08-10 14:30 ` Sakari Ailus
2021-08-09 22:58 ` [PATCH v2 10/12] media: i2c: Add controls from fwnode to ov8865 Daniel Scally
2021-08-09 22:58 ` [PATCH v2 11/12] media: i2c: Switch exposure control unit to lines Daniel Scally
2021-08-09 22:58 ` [PATCH v2 12/12] media: ipu3-cio2: Add INT347A to cio2-bridge Daniel Scally
2021-08-10 13:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4c5592a-2350-9abb-b9c0-143ee6a028af@gmail.com \
--to=djrscally@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=ezequiel@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kevin.lhopital@bootlin.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox