Linux Media Controller development
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Andy Shevchenko <andy@kernel.org>,
	linux-media@vger.kernel.org
Subject: [PATCH 0/3] media: Add MIPI CCI register access helper functions
Date: Tue,  6 Jun 2023 18:58:05 +0200	[thread overview]
Message-ID: <20230606165808.70751-1-hdegoede@redhat.com> (raw)

Hi Laurent, Sakari, et al.,

The CSI2 specification specifies a standard method to access camera sensor
registers called "Camera Control Interface (CCI)".

Currently a lot of Linux camera sensor drivers all have their own custom
helpers for this, often copy and pasted from other drivers.

This adds a set of generic helpers for this so that all sensor drivers can
switch to a single common implementation.

This is based on / the result of our previous discussion on this here:
Link: https://lore.kernel.org/linux-media/59aefa7f-7bf9-6736-6040-39551329cd0a@redhat.com/

Patch 2/3 is an example of how these helpers can be used and 3/3 removes
the now no longer necessary ov_16bit_addr_reg_helpers.h which was
the previous attempt to add common CCI access helpers. As such
patch 2/3 and 3/3 are more of a RFC really. Please focus on reviewing
patch 1/3.

Regards,

Hans


Hans de Goede (3):
  media: Add MIPI CCI register access helper functions
  media: atomisp: ov2680: Convert to new CCI register access helpers
  media: Remove ov_16bit_addr_reg_helpers.h

 Documentation/driver-api/media/v4l2-cci.rst   |   5 +
 Documentation/driver-api/media/v4l2-core.rst  |   1 +
 drivers/media/v4l2-core/Kconfig               |   5 +
 drivers/media/v4l2-core/Makefile              |   1 +
 drivers/media/v4l2-core/v4l2-cci.c            | 142 +++++++++++
 drivers/staging/media/atomisp/i2c/Kconfig     |   1 +
 .../media/atomisp/i2c/atomisp-ov2680.c        | 233 ++++++++----------
 drivers/staging/media/atomisp/i2c/ov2680.h    |  73 +-----
 include/media/ov_16bit_addr_reg_helpers.h     |  92 -------
 include/media/v4l2-cci.h                      | 109 ++++++++
 10 files changed, 367 insertions(+), 295 deletions(-)
 create mode 100644 Documentation/driver-api/media/v4l2-cci.rst
 create mode 100644 drivers/media/v4l2-core/v4l2-cci.c
 delete mode 100644 include/media/ov_16bit_addr_reg_helpers.h
 create mode 100644 include/media/v4l2-cci.h

-- 
2.40.1


             reply	other threads:[~2023-06-06 16:59 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 16:58 Hans de Goede [this message]
2023-06-06 16:58 ` [PATCH 1/3] media: Add MIPI CCI register access helper functions Hans de Goede
2023-06-06 20:43   ` Andy Shevchenko
2023-06-07  8:40     ` Hans de Goede
2023-06-07 12:01       ` Sakari Ailus
2023-06-07 14:55         ` Laurent Pinchart
2023-06-07 15:40         ` Andy Shevchenko
2023-06-07 15:58           ` Hans de Goede
2023-06-07 16:14             ` Andy Shevchenko
2023-06-07 16:20               ` Hans de Goede
2023-06-07 18:03                 ` Andy Shevchenko
2023-06-07  7:50   ` Sakari Ailus
2023-06-07  8:46     ` Hans de Goede
2023-06-07 11:41       ` Sakari Ailus
2023-06-07 18:18   ` Laurent Pinchart
2023-06-07 19:01     ` Hans de Goede
2023-06-07 20:07       ` Andy Shevchenko
2023-06-08  8:33         ` Hans de Goede
2023-06-08  8:33         ` Sakari Ailus
2023-06-08 10:24           ` Andy Shevchenko
2023-06-08 10:27       ` Laurent Pinchart
2023-06-08 11:01         ` Sakari Ailus
2023-06-12 15:03           ` Laurent Pinchart
2023-06-13  9:57             ` Sakari Ailus
2023-06-12 13:48         ` Hans de Goede
2023-06-12 15:16           ` Laurent Pinchart
2023-06-12 15:33             ` Hans de Goede
2023-06-12 16:02               ` Laurent Pinchart
2023-06-06 16:58 ` [PATCH 2/3] media: atomisp: ov2680: Convert to new CCI register access helpers Hans de Goede
2023-06-06 20:53   ` Andy Shevchenko
2023-06-07  8:53     ` Hans de Goede
2023-06-07 15:51       ` Laurent Pinchart
2023-06-07 15:59         ` Hans de Goede
2023-06-07 16:07           ` Laurent Pinchart
2023-06-07 16:05   ` Laurent Pinchart
2023-06-07 16:18     ` Hans de Goede
2023-06-06 16:58 ` [PATCH 3/3] media: Remove ov_16bit_addr_reg_helpers.h Hans de Goede
2023-06-07 15:57   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230606165808.70751-1-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andy@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox