From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] media: Add MIPI CCI register access helper functions
Date: Wed, 7 Jun 2023 23:07:28 +0300 [thread overview]
Message-ID: <ZIDjgFtZ7qp6YYz1@smile.fi.intel.com> (raw)
In-Reply-To: <b558aac9-0a34-ecca-57b0-d132af8cdefb@redhat.com>
On Wed, Jun 07, 2023 at 09:01:40PM +0200, Hans de Goede wrote:
> On 6/7/23 20:18, Laurent Pinchart wrote:
> > On Tue, Jun 06, 2023 at 06:58:06PM +0200, Hans de Goede wrote:
...
> >> + if (regs[i].delay_us)
> >> + fsleep(regs[i].delay_us);
> >
> > Do you have an immediate need for this ? If not, I'd drop support for
> > the delay, and add it later when and if needed. It will be easier to
> > discuss the API and use cases with a real user.
>
> This is a 1:1 mirror of regmap_multi_reg_write() note this uses
> the existing struct reg_sequence delay_us field and the:
>
> if (regs[i].delay_us)
> fsleep(regs[i].delay_us);
>
> is copied from the implementation of regmap_multi_reg_write()
Reading this I'm wondering if we can actually implement a regmap-cci inside
drivers/base/regmap and use it. It might be that this is impossible, but can
save us from repeating existing code I think.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-07 20:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 16:58 [PATCH 0/3] media: Add MIPI CCI register access helper functions Hans de Goede
2023-06-06 16:58 ` [PATCH 1/3] " Hans de Goede
2023-06-06 20:43 ` Andy Shevchenko
2023-06-07 8:40 ` Hans de Goede
2023-06-07 12:01 ` Sakari Ailus
2023-06-07 14:55 ` Laurent Pinchart
2023-06-07 15:40 ` Andy Shevchenko
2023-06-07 15:58 ` Hans de Goede
2023-06-07 16:14 ` Andy Shevchenko
2023-06-07 16:20 ` Hans de Goede
2023-06-07 18:03 ` Andy Shevchenko
2023-06-07 7:50 ` Sakari Ailus
2023-06-07 8:46 ` Hans de Goede
2023-06-07 11:41 ` Sakari Ailus
2023-06-07 18:18 ` Laurent Pinchart
2023-06-07 19:01 ` Hans de Goede
2023-06-07 20:07 ` Andy Shevchenko [this message]
2023-06-08 8:33 ` Hans de Goede
2023-06-08 8:33 ` Sakari Ailus
2023-06-08 10:24 ` Andy Shevchenko
2023-06-08 10:27 ` Laurent Pinchart
2023-06-08 11:01 ` Sakari Ailus
2023-06-12 15:03 ` Laurent Pinchart
2023-06-13 9:57 ` Sakari Ailus
2023-06-12 13:48 ` Hans de Goede
2023-06-12 15:16 ` Laurent Pinchart
2023-06-12 15:33 ` Hans de Goede
2023-06-12 16:02 ` Laurent Pinchart
2023-06-06 16:58 ` [PATCH 2/3] media: atomisp: ov2680: Convert to new CCI register access helpers Hans de Goede
2023-06-06 20:53 ` Andy Shevchenko
2023-06-07 8:53 ` Hans de Goede
2023-06-07 15:51 ` Laurent Pinchart
2023-06-07 15:59 ` Hans de Goede
2023-06-07 16:07 ` Laurent Pinchart
2023-06-07 16:05 ` Laurent Pinchart
2023-06-07 16:18 ` Hans de Goede
2023-06-06 16:58 ` [PATCH 3/3] media: Remove ov_16bit_addr_reg_helpers.h Hans de Goede
2023-06-07 15:57 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIDjgFtZ7qp6YYz1@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox