From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Cc: Tomasz Sikora <sikora.tomus@gmail.com>,
hverkuil-cisco@xs4all.nl, kernel-dev@igalia.com,
linux-media@vger.kernel.org, mchehab@kernel.org,
ribalda@chromium.org,
syzbot+0584f746fde3d52b4675@syzkaller.appspotmail.com,
syzbot+dd320d114deb3f5bb79b@syzkaller.appspotmail.com
Subject: Re: [PATCH v3 1/1] media: uvcvideo: require entities to have a non-zero unique ID
Date: Wed, 8 Jan 2025 17:36:37 +0200 [thread overview]
Message-ID: <20250108153637.GE32541@pendragon.ideasonboard.com> (raw)
In-Reply-To: <Z36ad0OxZBnQ0Kxx@quatroqueijos.cascardo.eti.br>
On Wed, Jan 08, 2025 at 12:32:07PM -0300, Thadeu Lima de Souza Cascardo wrote:
> On Mon, Jan 06, 2025 at 02:15:24PM +0100, Tomasz Sikora wrote:
> > Error in line 1034 dmesg.log
> > You can see more here https://bbs.archlinux.org/viewtopic.php?id=301737
> >
> > pon., 6 sty 2025 o 11:56 Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
> > napisał(a):
> >
> > > On Sun, Jan 05, 2025 at 07:31:09PM +0100, Tomasz Sikora wrote:
> > > > Issue video camera
> > > > ls -l /dev/video*zsh: no matches found: /dev/video*
> > > >
> > > >
> > > > 01 15:43:24 Linux kernel: usb 3-2: Found multiple Units with ID 5
> > >
> > > Can you attach complete dmesg output? And more importantly, attach the
> > > output of lsusb -vv?
> > >
> > > Thanks.
> > > Cascardo.
> > >
>
> Thanks a lot, Tomasz.
>
> Without this patch (it could be an older kernel), do you see a warning in
> your dmesg? Or messages like:
>
> [ 395.090938] usb 1-1: Failed to create links for entity 5
> [ 395.091385] usb 1-1: Failed to register entities (-22).
>
> Otherwise, it might just be that your kernel is not built with
> CONFIG_MEDIA_CONTROLLER.
>
> I reached that conclusion by emulating a similar uvc device. Yours has the
> entity ID for both the output terminal and processing unit. Though that is
> not valid according to the spec (even UVC 1.0 mentions the IDs should be
> unique), we should keep supporting such devices.
>
> I am currently working on a fix that will restore support for your device
> but improve its support for configs with CONFIG_MEDIA_CONTROLLER.
>
> I appreciate your help on testing such configurations and fixes.
The output of "lsusb -v -d 1c3f:2002" would help (running as root if
possible).
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2025-01-08 15:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADBf=5nJVddk-yPVw3T5GH9JEPOxnO8McPJHaxtnPBvLCnp42Q@mail.gmail.com>
2025-01-06 7:27 ` [PATCH v3 1/1] media: uvcvideo: require entities to have a non-zero unique ID Laurent Pinchart
2025-01-06 10:55 ` Thadeu Lima de Souza Cascardo
[not found] ` <CADBf=5nS8_cQvG3mRnXe_MGYmFMh=Myf_eptPqN9hgNMu73Wjg@mail.gmail.com>
2025-01-08 15:32 ` Thadeu Lima de Souza Cascardo
2025-01-08 15:36 ` Laurent Pinchart [this message]
2025-01-08 15:56 ` Thadeu Lima de Souza Cascardo
2025-01-08 22:14 ` Tomasz Sikora
2025-01-09 10:47 ` Thadeu Lima de Souza Cascardo
2025-01-13 18:50 ` Laurent Pinchart
2025-01-14 3:01 ` Ricardo Ribalda
2025-01-14 12:41 ` Thadeu Lima de Souza Cascardo
2025-01-14 15:20 ` Ricardo Ribalda
2025-01-14 17:26 ` Thadeu Lima de Souza Cascardo
2025-01-14 20:00 ` [PATCH] Revert "media: uvcvideo: Require entities to have a non-zero unique ID" Thadeu Lima de Souza Cascardo
2025-01-20 11:52 ` Ricardo Ribalda
2025-01-31 10:04 ` Ricardo Ribalda
2025-01-31 11:12 ` Hans de Goede
2025-01-31 11:17 ` Ricardo Ribalda
2025-01-31 14:06 ` Mauro Carvalho Chehab
2025-01-31 14:30 ` Hans Verkuil
2025-01-31 16:38 ` Hans de Goede
2025-01-31 16:57 ` Laurent Pinchart
2025-01-31 16:35 ` Hans de Goede
2025-01-31 16:59 ` Laurent Pinchart
2025-01-14 12:37 ` [PATCH v3 1/1] media: uvcvideo: require entities to have a non-zero unique ID Thadeu Lima de Souza Cascardo
2024-09-13 18:06 [PATCH v3 0/1] uvcvideo: require spec compliance to avoid bugs Thadeu Lima de Souza Cascardo
2024-09-13 18:06 ` [PATCH v3 1/1] media: uvcvideo: require entities to have a non-zero unique ID Thadeu Lima de Souza Cascardo
2024-09-25 19:45 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108153637.GE32541@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=cascardo@igalia.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel-dev@igalia.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=sikora.tomus@gmail.com \
--cc=syzbot+0584f746fde3d52b4675@syzkaller.appspotmail.com \
--cc=syzbot+dd320d114deb3f5bb79b@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox