Re: [PATCH] Revert "media: uvcvideo: Require entities to have a non-zero unique ID"

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Fri, Jan 31, 2025 at 05:38:54PM +0100, Hans de Goede wrote:
> On 31-Jan-25 15:06, Mauro Carvalho Chehab wrote:
> > Em Fri, 31 Jan 2025 12:17:25 +0100 Ricardo Ribalda escreveu:
> >> On Fri, 31 Jan 2025 at 12:12, Hans de Goede wrote:
> >>> On 31-Jan-25 11:04 AM, Ricardo Ribalda wrote:  
> >>>> Hi Hans  
> >>>
> >>> Which Hans, me or Hans Verkuil?  Since this needs to go out
> >>> through a fixed pull-request I think it would be best if
> >>> Hans Verkuil picks up the revert directly in the fixes
> >>> branch ?  
> >>
> >> Whoever started in v4l2 later needs to change their name :P.
> >>
> >> I was thinking about you this time :)
> >>
> >>>> We are seeing a spike of reports with the signature:
> >>>>
> >>>> "Found multiple Units with ID XX"
> >>>>
> >>>> Could you take a look at this patch? I agree with Thadeu that the best
> >>>> strategy is to land the revert asap and when the storm disappears work
> >>>> on a different solution.  
> >>>
> >>> Ack, Fedora is getting some bug reports about this too. Since both
> >>> you (Ricardo) and Laurant seemed to be on top of this I didn't take
> >>> a closer look yet. But this definitely is hitting users and we
> >>> need to fix this.
> >>>
> >>> Since we still don't have a fix yet we really should revert the commit
> >>> causing this problem ASAP.  
> >>
> >> Hans (Verkuil) if Hans (de Goede) adds a Reviewed-by or a Acked-by,
> >> could you take this patch to the media-committers/fixes branch ?
> > 
> > I can pick it as well. From what I got, Hans de Goede is also ok
> > with such change.
> 
> Yes I have just replied to the revert patch with my reviewed-by. Mauro
> if you can pick this up and send it to Linus soon(ish) that would be
> great.
> 
> Can you also please add a Cc: stable@vger.kernel.org tag while
> merging it?  This will need to be backported to kernels which have
> the troublesome commit.

I was planning to send a fixes pull request for this once -rc1 comes out
(so basically on Monday). As we're in the middle of the merge window,
the patch couldn't be merged right away.

I'm also fine if Mauro picks it up, that's easier for me. If it hasn't
been merged in the fixes branch on Monday, I'll send the pull request.

-- 
Regards,

Laurent Pinchart