Re: [PATCH] Revert "media: uvcvideo: Require entities to have a non-zero unique ID"

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

Em Fri, 31 Jan 2025 12:17:25 +0100
Ricardo Ribalda <ribalda@chromium.org> escreveu:

> On Fri, 31 Jan 2025 at 12:12, Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > Hi Ricardo,
> >
> > On 31-Jan-25 11:04 AM, Ricardo Ribalda wrote:  
> > > Hi Hans  
> >
> > Which Hans, me or Hans Verkuil?  Since this needs to go out
> > through a fixed pull-request I think it would be best if
> > Hans Verkuil picks up the revert directly in the fixes
> > branch ?  
> 
> Whoever started in v4l2 later needs to change their name :P.
> 
> I was thinking about you this time :)
> 
> >  
> > > We are seeing a spike of reports with the signature:
> > >
> > > "Found multiple Units with ID XX"
> > >
> > > Could you take a look at this patch? I agree with Thadeu that the best
> > > strategy is to land the revert asap and when the storm disappears work
> > > on a different solution.  
> >
> > Ack, Fedora is getting some bug reports about this too. Since both
> > you (Ricardo) and Laurant seemed to be on top of this I didn't take
> > a closer look yet. But this definitely is hitting users and we
> > need to fix this.
> >
> > Since we still don't have a fix yet we really should revert the commit
> > causing this problem ASAP.  
> 
> Hans (Verkuil) if Hans (de Goede) adds a Reviewed-by or a Acked-by,
> could you take this patch to the media-committers/fixes branch ?

I can pick it as well. From what I got, Hans de Goede is also ok
with such change.


Thanks,
Mauro