* [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
@ 2026-04-04 14:12 Sunny Patel
2026-04-05 21:20 ` Laurent Pinchart
0 siblings, 1 reply; 8+ messages in thread
From: Sunny Patel @ 2026-04-04 14:12 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Laurent Pinchart, Sakari Ailus, Jacopo Mondi, linux-media,
linux-kernel, Sunny Patel
---
drivers/media/v4l2-core/v4l2-subdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index 32e6f60e26c7..4616e9280a28 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
if (WARN_ON(!state))
return NULL;
- lockdep_assert_held(state->lock);
-
if (state->pads) {
if (stream)
return NULL;
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
2026-04-04 14:12 [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion Sunny Patel
@ 2026-04-05 21:20 ` Laurent Pinchart
2026-04-06 9:58 ` Sunny Patel
0 siblings, 1 reply; 8+ messages in thread
From: Laurent Pinchart @ 2026-04-05 21:20 UTC (permalink / raw)
To: Sunny Patel
Cc: Mauro Carvalho Chehab, Sakari Ailus, Jacopo Mondi, linux-media,
linux-kernel
On Sat, Apr 04, 2026 at 07:42:26PM +0530, Sunny Patel wrote:
Missing commit message. Please read
Documentation/process/submitting-patches.rst
> ---
> drivers/media/v4l2-core/v4l2-subdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index 32e6f60e26c7..4616e9280a28 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
> if (WARN_ON(!state))
> return NULL;
>
> - lockdep_assert_held(state->lock);
> -
> if (state->pads) {
> if (stream)
> return NULL;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
2026-04-05 21:20 ` Laurent Pinchart
@ 2026-04-06 9:58 ` Sunny Patel
2026-04-06 12:23 ` Laurent Pinchart
0 siblings, 1 reply; 8+ messages in thread
From: Sunny Patel @ 2026-04-06 9:58 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Laurent Pinchart, Sakari Ailus, Jacopo Mondi, linux-media,
linux-kernel, Sunny Patel
The __v4l2_subdev_state_get_interval() function has a duplicate
lockdep_assert_held() call. Removed the redundant assertion.
Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
---
drivers/media/v4l2-core/v4l2-subdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index 32e6f60e26c7..4616e9280a28 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
if (WARN_ON(!state))
return NULL;
- lockdep_assert_held(state->lock);
-
if (state->pads) {
if (stream)
return NULL;
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
2026-04-06 9:58 ` Sunny Patel
@ 2026-04-06 12:23 ` Laurent Pinchart
2026-04-07 5:39 ` [PATCH v2] media: v4l2-core: " Sunny Patel
2026-04-09 17:15 ` [PATCH] media: v4l2-core: v4l2-subdev: " Sunny Patel
0 siblings, 2 replies; 8+ messages in thread
From: Laurent Pinchart @ 2026-04-06 12:23 UTC (permalink / raw)
To: Sunny Patel
Cc: Mauro Carvalho Chehab, Sakari Ailus, Jacopo Mondi, linux-media,
linux-kernel
When submitting new versions of a patch (or patch series), please
remember to indicate the version in the subject line. The -v option to
git-format-patch helps.
On Mon, Apr 06, 2026 at 03:28:50PM +0530, Sunny Patel wrote:
> The __v4l2_subdev_state_get_interval() function has a duplicate
> lockdep_assert_held() call. Removed the redundant assertion.
>
> Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
> ---
> drivers/media/v4l2-core/v4l2-subdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index 32e6f60e26c7..4616e9280a28 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
> if (WARN_ON(!state))
> return NULL;
>
> - lockdep_assert_held(state->lock);
> -
Why do you remove this assertion and not the next one ?
> if (state->pads) {
> if (stream)
> return NULL;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2] media: v4l2-core: Removed duplicate lockdep assertion
2026-04-06 12:23 ` Laurent Pinchart
@ 2026-04-07 5:39 ` Sunny Patel
2026-04-07 7:46 ` Laurent Pinchart
2026-04-09 17:15 ` [PATCH] media: v4l2-core: v4l2-subdev: " Sunny Patel
1 sibling, 1 reply; 8+ messages in thread
From: Sunny Patel @ 2026-04-07 5:39 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Laurent Pinchart, Sakari Ailus, Jacopo Mondi, linux-media,
linux-kernel, Sunny Patel
The __v4l2_subdev_state_get_interval() function has a duplicate
lockdep_assert_held() call. Removed the redundant assertion.
Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
---
drivers/media/v4l2-core/v4l2-subdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index 32e6f60e26c7..4616e9280a28 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
if (WARN_ON(!state))
return NULL;
- lockdep_assert_held(state->lock);
-
if (state->pads) {
if (stream)
return NULL;
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] media: v4l2-core: Removed duplicate lockdep assertion
2026-04-07 5:39 ` [PATCH v2] media: v4l2-core: " Sunny Patel
@ 2026-04-07 7:46 ` Laurent Pinchart
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2026-04-07 7:46 UTC (permalink / raw)
To: Sunny Patel
Cc: Mauro Carvalho Chehab, Sakari Ailus, Jacopo Mondi, linux-media,
linux-kernel
There was a review comment in the previous version of this patch and you
didn't take it into account. Please reply to it and explain why.
On Tue, Apr 07, 2026 at 11:09:46AM +0530, Sunny Patel wrote:
> The __v4l2_subdev_state_get_interval() function has a duplicate
> lockdep_assert_held() call. Removed the redundant assertion.
>
> Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
> ---
> drivers/media/v4l2-core/v4l2-subdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index 32e6f60e26c7..4616e9280a28 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
> if (WARN_ON(!state))
> return NULL;
>
> - lockdep_assert_held(state->lock);
> -
> if (state->pads) {
> if (stream)
> return NULL;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
2026-04-06 12:23 ` Laurent Pinchart
2026-04-07 5:39 ` [PATCH v2] media: v4l2-core: " Sunny Patel
@ 2026-04-09 17:15 ` Sunny Patel
2026-04-21 16:37 ` Sakari Ailus
1 sibling, 1 reply; 8+ messages in thread
From: Sunny Patel @ 2026-04-09 17:15 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Laurent Pinchart, Sakari Ailus, Jacopo Mondi, linux-media,
linux-kernel, Sunny Patel
Removal is only required afte state->pads for stream_configs since
state->pads only represents the static array so not required locking for
it.
The __v4l2_subdev_state_get_interval() function has a duplicate
lockdep_assert_held() call. Removed the redundant assertion.
Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
---
drivers/media/v4l2-core/v4l2-subdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index 32e6f60e26c7..4616e9280a28 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
if (WARN_ON(!state))
return NULL;
- lockdep_assert_held(state->lock);
-
if (state->pads) {
if (stream)
return NULL;
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
2026-04-09 17:15 ` [PATCH] media: v4l2-core: v4l2-subdev: " Sunny Patel
@ 2026-04-21 16:37 ` Sakari Ailus
0 siblings, 0 replies; 8+ messages in thread
From: Sakari Ailus @ 2026-04-21 16:37 UTC (permalink / raw)
To: Sunny Patel
Cc: Mauro Carvalho Chehab, Laurent Pinchart, Jacopo Mondi,
linux-media, linux-kernel
Hi Sunny,
Thanks for the update.
Please always set the version of the patch if not the first.
On Thu, Apr 09, 2026 at 10:45:23PM +0530, Sunny Patel wrote:
> Removal is only required afte state->pads for stream_configs since
> state->pads only represents the static array so not required locking for
> it.
>
>
Extra newline.
> The __v4l2_subdev_state_get_interval() function has a duplicate
> lockdep_assert_held() call. Removed the redundant assertion.
Please use imperative when describing what the patch does.
>
> Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
> ---
Please describe changes across versions, at least from the previous one.
> drivers/media/v4l2-core/v4l2-subdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
> index 32e6f60e26c7..4616e9280a28 100644
> --- a/drivers/media/v4l2-core/v4l2-subdev.c
> +++ b/drivers/media/v4l2-core/v4l2-subdev.c
> @@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,
> if (WARN_ON(!state))
> return NULL;
>
> - lockdep_assert_held(state->lock);
> -
> if (state->pads) {
> if (stream)
> return NULL;
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-04-21 16:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-04 14:12 [PATCH] media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion Sunny Patel
2026-04-05 21:20 ` Laurent Pinchart
2026-04-06 9:58 ` Sunny Patel
2026-04-06 12:23 ` Laurent Pinchart
2026-04-07 5:39 ` [PATCH v2] media: v4l2-core: " Sunny Patel
2026-04-07 7:46 ` Laurent Pinchart
2026-04-09 17:15 ` [PATCH] media: v4l2-core: v4l2-subdev: " Sunny Patel
2026-04-21 16:37 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox