Linux Media Controller development
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Jai Luthra <jai.luthra@ideasonboard.com>,
	Mehdi Djait <mehdi.djait@linux.intel.com>
Subject: [PATCH 09/17] media: bcm2835-unicam: Use v4l2_subdev_get_frame_desc()
Date: Wed, 13 May 2026 13:43:50 +0300	[thread overview]
Message-ID: <20260513104358.2252605-10-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20260513104358.2252605-1-sakari.ailus@linux.intel.com>

Call v4l2_subdev_get_frame_desc() to obtain the frame descriptor. This is
preferred over calling the get_frame_desc() pad operation directly.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 .../media/platform/broadcom/bcm2835-unicam.c  | 20 +++++++++----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
index 8d28ba0b59a3..2e78b16bf18c 100644
--- a/drivers/media/platform/broadcom/bcm2835-unicam.c
+++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
@@ -888,7 +888,8 @@ static int unicam_get_image_vc_dt(struct unicam_device *unicam,
 				  struct v4l2_subdev_state *state,
 				  u8 *vc, u8 *dt)
 {
-	struct v4l2_mbus_frame_desc fd;
+	struct v4l2_mbus_frame_desc *fd __free(v4l2_subdev_free_frame_desc) =
+		NULL;
 	u32 stream;
 	int ret;
 
@@ -898,17 +899,14 @@ static int unicam_get_image_vc_dt(struct unicam_device *unicam,
 	if (ret)
 		return ret;
 
-	ret = v4l2_subdev_call(unicam->sensor.subdev, pad, get_frame_desc,
-			       unicam->sensor.pad->index, &fd);
-	if (ret)
-		return ret;
-
-	/* Only CSI-2 supports DTs. */
-	if (fd.type != V4L2_MBUS_FRAME_DESC_TYPE_CSI2)
-		return -EINVAL;
+	fd = v4l2_subdev_get_frame_desc(unicam->sensor.subdev,
+					unicam->sensor.pad->index,
+					V4L2_MBUS_FRAME_DESC_TYPE_CSI2);
+	if (IS_ERR(fd))
+		return PTR_ERR(fd);
 
-	for (unsigned int i = 0; i < fd.num_entries; ++i) {
-		const struct v4l2_mbus_frame_desc_entry *fde = &fd.entry[i];
+	for (unsigned int i = 0; i < fd->num_entries; ++i) {
+		const struct v4l2_mbus_frame_desc_entry *fde = &fd->entry[i];
 
 		if (fde->stream == stream) {
 			*vc = fde->bus.csi2.vc;
-- 
2.47.3


  parent reply	other threads:[~2026-05-13 10:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 10:43 [PATCH 00/17] Rework frame descriptors Sakari Ailus
2026-05-13 10:43 ` [PATCH 01/17] media: v4l2-common: Add mipi_csi2_dt_for_mbus() Sakari Ailus
2026-05-13 10:43 ` [PATCH 02/17] media: v4l2-subdev: Align frame descriptor error codes with routing Sakari Ailus
2026-05-13 10:43 ` [PATCH 03/17] media: v4l2-subdev: Prepare for changes in getting frame descriptors Sakari Ailus
2026-05-13 10:43 ` [PATCH 04/17] media: v4l2-subdev: Allocate frame descriptors based on the need Sakari Ailus
2026-05-13 10:43 ` [PATCH 05/17] media: v4l2-subdev: Provide a cleanup-friendly get_frame_desc Sakari Ailus
2026-05-13 10:43 ` [PATCH 06/17] media: v4l2-subdev: Change the maximum number of routes Sakari Ailus
2026-05-13 10:43 ` [PATCH 07/17] media: v4l2-subdev: Return dynamically allocated pass-through routes Sakari Ailus
2026-05-13 10:43 ` [PATCH 08/17] media: v4l2-subdev: Always return at least one frame descriptor Sakari Ailus
2026-05-13 10:43 ` Sakari Ailus [this message]
2026-05-13 10:43 ` [PATCH 10/17] media: nxp: imx8-isi: Use v4l2_subdev_get_frame_desc() Sakari Ailus
2026-05-13 10:43 ` [PATCH 11/17] media: raspberrypi: cfe: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 12/17] media: rzg2l-cru: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 13/17] media: rkisp1: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 14/17] media: exynos4-is: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 15/17] media: ti: cal: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 16/17] media: ipu6: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 17/17] staging: media: ipu7: " Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260513104358.2252605-10-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=jai.luthra@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox