From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Jai Luthra <jai.luthra@ideasonboard.com>,
Mehdi Djait <mehdi.djait@linux.intel.com>
Subject: [PATCH 13/17] media: rkisp1: Use v4l2_subdev_get_frame_desc()
Date: Wed, 13 May 2026 13:43:54 +0300 [thread overview]
Message-ID: <20260513104358.2252605-14-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20260513104358.2252605-1-sakari.ailus@linux.intel.com>
Call v4l2_subdev_get_frame_desc() to obtain the frame descriptor. This is
preferred over calling the get_frame_desc() pad operation directly.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
index 2311672cedb1..7e94ff2037a6 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
@@ -8,6 +8,7 @@
* Copyright (C) 2017 Rockchip Electronics Co., Ltd.
*/
+#include <linux/cleanup.h>
#include <linux/iopoll.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
@@ -87,7 +88,8 @@ static int rkisp1_gasket_enable(struct rkisp1_device *rkisp1,
struct media_pad *source)
{
struct v4l2_subdev *source_sd;
- struct v4l2_mbus_frame_desc fd;
+ struct v4l2_mbus_frame_desc *fd = __free(v4l2_subdev_free_frame_desc) =
+ NULL;
unsigned int dt;
u32 mask;
u32 val;
@@ -101,8 +103,8 @@ static int rkisp1_gasket_enable(struct rkisp1_device *rkisp1,
*/
source_sd = media_entity_to_v4l2_subdev(source->entity);
- ret = v4l2_subdev_call(source_sd, pad, get_frame_desc,
- source->index, &fd);
+ fd = v4l2_subdev_get_frame_desc(source_sd, source->index,
+ V4L2_MBUS_FRAME_DESC_TYPE_CSI2);
if (ret) {
dev_err(rkisp1->dev,
"failed to get frame descriptor from '%s':%u: %d\n",
@@ -110,13 +112,13 @@ static int rkisp1_gasket_enable(struct rkisp1_device *rkisp1,
return ret;
}
- if (fd.num_entries != 1) {
+ if (fd->num_entries != 1) {
dev_err(rkisp1->dev, "invalid frame descriptor for '%s':%u\n",
source_sd->name, 0);
return -EINVAL;
}
- dt = fd.entry[0].bus.csi2.dt;
+ dt = fd->entry[0].bus.csi2.dt;
if (rkisp1->gasket_id == 0) {
mask = ISP_DEWARP_CONTROL_MIPI_CSI1_HS_POLARITY
--
2.47.3
next prev parent reply other threads:[~2026-05-13 10:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 10:43 [PATCH 00/17] Rework frame descriptors Sakari Ailus
2026-05-13 10:43 ` [PATCH 01/17] media: v4l2-common: Add mipi_csi2_dt_for_mbus() Sakari Ailus
2026-05-13 10:43 ` [PATCH 02/17] media: v4l2-subdev: Align frame descriptor error codes with routing Sakari Ailus
2026-05-13 10:43 ` [PATCH 03/17] media: v4l2-subdev: Prepare for changes in getting frame descriptors Sakari Ailus
2026-05-13 10:43 ` [PATCH 04/17] media: v4l2-subdev: Allocate frame descriptors based on the need Sakari Ailus
2026-05-13 10:43 ` [PATCH 05/17] media: v4l2-subdev: Provide a cleanup-friendly get_frame_desc Sakari Ailus
2026-05-13 10:43 ` [PATCH 06/17] media: v4l2-subdev: Change the maximum number of routes Sakari Ailus
2026-05-13 10:43 ` [PATCH 07/17] media: v4l2-subdev: Return dynamically allocated pass-through routes Sakari Ailus
2026-05-13 10:43 ` [PATCH 08/17] media: v4l2-subdev: Always return at least one frame descriptor Sakari Ailus
2026-05-13 10:43 ` [PATCH 09/17] media: bcm2835-unicam: Use v4l2_subdev_get_frame_desc() Sakari Ailus
2026-05-13 10:43 ` [PATCH 10/17] media: nxp: imx8-isi: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 11/17] media: raspberrypi: cfe: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 12/17] media: rzg2l-cru: " Sakari Ailus
2026-05-13 10:43 ` Sakari Ailus [this message]
2026-05-13 10:43 ` [PATCH 14/17] media: exynos4-is: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 15/17] media: ti: cal: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 16/17] media: ipu6: " Sakari Ailus
2026-05-13 10:43 ` [PATCH 17/17] staging: media: ipu7: " Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513104358.2252605-14-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jai.luthra@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox