linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	Jai Luthra <jai.luthra@ideasonboard.com>,
	Mehdi Djait <mehdi.djait@linux.intel.com>,
	Frank Li <Frank.li@nxp.com>
Subject: [PATCH v2 08/17] media: v4l2-subdev: Always return at least one frame descriptor
Date: Mon, 18 May 2026 19:43:08 +0300	[thread overview]
Message-ID: <20260518164318.3367888-9-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20260518164318.3367888-1-sakari.ailus@linux.intel.com>

Make v4l2_subdev_get_frame_desc() return at least one frame descriptor
entry or an error. Empty frame descriptors aren't useful for callers so
callers can now omit this check.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/v4l2-core/v4l2-subdev.c | 6 ++++++
 include/media/v4l2-subdev.h           | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index b5eef0baa237..dc4ac08c210f 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -2732,6 +2732,12 @@ v4l2_subdev_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
 			goto err_free;
 		}
 
+		if (!desc->num_entries) {
+			dev_dbg(sd->dev, "no frame descriptor entries\n");
+			ret = -EINVAL;
+			goto err_free;
+		}
+
 		return desc;
 	}
 
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index f9b121eefa92..0361c8bbee38 100644
--- a/include/media/v4l2-subdev.h
+++ b/include/media/v4l2-subdev.h
@@ -1817,6 +1817,8 @@ int v4l2_subdev_get_frame_desc_passthrough(struct v4l2_subdev *sd,
  *    struct v4l2_mbus_frame_desc *desc __free(v4l2_subdev_free_frame_desc) =
  *            v4l2_subdev_get_frame_desc(sd, pad, desc);
  *
+ * The returned frame descriptor will contain at least one entry.
+ *
  * Return: The frame descriptor on success or a negative error code on failure.
  */
 struct v4l2_mbus_frame_desc *
-- 
2.47.3


  parent reply	other threads:[~2026-05-18 16:43 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 16:43 [PATCH v2 00/17] Rework frame descriptors Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 01/17] media: v4l2-common: Add helper function media_bus_fmt_to_csi2_(bpp|dt)() Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 02/17] media: v4l2-subdev: Align frame descriptor error codes with routing Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 03/17] media: v4l2-subdev: Prepare for changes in getting frame descriptors Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 04/17] media: v4l2-subdev: Allow releasing frame descriptors on return Sakari Ailus
2026-05-19 21:34   ` Frank Li
2026-05-20 12:56     ` Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 05/17] media: v4l2-subdev: Allocate frame descriptors based on the need Sakari Ailus
2026-05-19 21:53   ` Frank Li
2026-05-19 22:18     ` Frank Li
2026-05-18 16:43 ` [PATCH v2 06/17] media: v4l2-subdev: Change the maximum number of routes Sakari Ailus
2026-05-19 21:55   ` Frank Li
2026-05-18 16:43 ` [PATCH v2 07/17] media: v4l2-subdev: Return dynamically allocated pass-through routes Sakari Ailus
2026-05-19 22:33   ` Frank Li
2026-05-20 12:59     ` Sakari Ailus
2026-05-18 16:43 ` Sakari Ailus [this message]
2026-05-19 22:35   ` [PATCH v2 08/17] media: v4l2-subdev: Always return at least one frame descriptor Frank Li
2026-05-18 16:43 ` [PATCH v2 09/17] media: bcm2835-unicam: Use v4l2_subdev_get_frame_desc() Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 10/17] media: nxp: imx8-isi: " Sakari Ailus
2026-05-19 22:36   ` Frank Li
2026-05-18 16:43 ` [PATCH v2 11/17] media: raspberrypi: cfe: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 12/17] media: rzg2l-cru: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 13/17] media: rkisp1: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 14/17] media: exynos4-is: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 15/17] media: ti: cal: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 16/17] media: ipu6: " Sakari Ailus
2026-05-18 16:43 ` [PATCH v2 17/17] staging: media: ipu7: " Sakari Ailus
2026-06-11 12:49 ` [PATCH v2 00/17] Rework frame descriptors Tomi Valkeinen
2026-06-12  8:28   ` Sakari Ailus
2026-06-23  7:39   ` Sakari Ailus
2026-08-14  8:17 ` Mattijs Korpershoek
2026-08-14  8:21   ` Tomi Valkeinen
2026-08-14  9:26     ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260518164318.3367888-9-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=Frank.li@nxp.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=jai.luthra@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).