Linux Media Controller development
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Jan Kara  <jack@suse.cz>, Theodore Tso <tytso@mit.edu>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Derek Barbosa <debarbos@redhat.com>,
	Matthieu Baerts <matttbe@kernel.org>,
	Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Steven Rostedt <rostedt@goodmis.org>,
	users@kernel.org,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Stephen Finucane <stephenfin@redhat.com>
Subject: Re: Linking Patchwork with Sashiko?
Date: Thu, 16 Jul 2026 09:04:01 +0200	[thread overview]
Message-ID: <20260716090401.193720d2@foz.lan> (raw)
In-Reply-To: <7b8e735092ecd25c61e79d8291b2edf5e54dfb15.camel@HansenPartnership.com>

On Wed, 15 Jul 2026 16:36:42 -0400
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> On Wed, 2026-07-15 at 23:28 +0300, Laurent Pinchart wrote:
> [...]
> > No later than yesterday a friend of mine pointed me to a mail thread
> > where sashiko referenced code that has never existed in the kernel,
> > and the maintainer blindly trusted the comment and asked the patch
> > author to fix that issue, seemingly doubling down when told the code
> > didn't exist.  

I saw the same more than once in the past where humans did about the same
by assuming a previous implementation of some code.

> We can definitely do maintainer education if you point me (or the TAB)
> at the thread.  Sashiko as a tool can absolutely get things wrong so,
> as maintainers, we do need to accept a reasoned answer that shows the
> review is wrong.

As already pointed on this thread, the author is the one that has more
time to dedicate to his proposed changes. A simply reply to a Sashiko's
email telling that the referenced code there was an hallucination would
be enough for maintainers to ignore such particular issue. 

Thanks,
Mauro

  parent reply	other threads:[~2026-07-16  7:04 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260528144627.1ae09ff2@foz.lan>
     [not found] ` <1372F826-5513-4EB2-AE27-1DC0D2DE0AEB@linux.dev>
     [not found]   ` <20260529083100.6710b6cd@foz.lan>
     [not found]     ` <20260529083801.2c7e8990@foz.lan>
     [not found]       ` <ahmwUk0uXTkdwohf@debarbos-thinkpadt14gen5.rmtusma.csb>
2026-05-30  8:30         ` Linking Patchwork with Sashiko? Mauro Carvalho Chehab
2026-05-30 15:57           ` Roman Gushchin
2026-05-30 18:00             ` Mauro Carvalho Chehab
2026-05-30 18:49               ` Mauro Carvalho Chehab
2026-05-30 18:53                 ` Mauro Carvalho Chehab
2026-06-02 15:51                   ` Derek Barbosa
2026-06-02 16:51                     ` Mauro Carvalho Chehab
2026-06-02 18:39                       ` Jason Gunthorpe
2026-06-02 20:29                         ` Mauro Carvalho Chehab
2026-06-02 20:13                     ` Roman Gushchin
2026-06-02 20:39                       ` Mauro Carvalho Chehab
2026-06-02 20:44                         ` Roman Gushchin
2026-06-02 23:50                         ` Matthieu Baerts
2026-06-03  3:35                           ` Mauro Carvalho Chehab
2026-06-03  3:49                             ` Roman Gushchin
2026-06-04  6:52                           ` Mauro Carvalho Chehab
2026-06-07 17:56                             ` Mauro Carvalho Chehab
2026-06-30 20:32                               ` Derek Barbosa
2026-07-10  5:45                                 ` Mauro Carvalho Chehab
2026-07-10  6:39                                   ` Mauro Carvalho Chehab
2026-07-11  1:01                                     ` Roman Gushchin
2026-07-13  7:55                                       ` Mauro Carvalho Chehab
2026-07-13  9:41                                         ` Laurent Pinchart
2026-07-13 20:04                                           ` Mauro Carvalho Chehab
2026-07-14 22:55                                             ` Roman Gushchin
2026-07-15  0:59                                               ` Laurent Pinchart
2026-07-15  2:00                                                 ` Roman Gushchin
2026-07-15  3:06                                                   ` Linus Torvalds
2026-07-15 12:21                                                     ` Jori Koolstra
2026-07-15 16:50                                                       ` Steven Rostedt
2026-07-15 18:13                                                       ` Nicolas Dufresne
2026-07-15 19:12                                                         ` Laurent Pinchart
2026-07-15 19:27                                                           ` Nicolas Dufresne
2026-07-15 20:03                                                             ` Laurent Pinchart
2026-07-15 16:43                                                     ` Laurent Pinchart
2026-07-15 23:28                                                     ` lyude
2026-07-15  7:59                                                   ` Jacopo Mondi
2026-07-15  8:40                                                     ` Mauro Carvalho Chehab
2026-07-15 17:31                                                     ` Theodore Tso
2026-07-16  8:07                                                       ` Jacopo Mondi
2026-07-15 12:38                                                   ` Mark Brown
2026-07-15 16:28                                                   ` Laurent Pinchart
2026-07-15 21:08                                                     ` Roman Gushchin
2026-07-15 23:20                                                       ` Steven Rostedt
2026-07-16  0:09                                                         ` Roman Gushchin
2026-07-15  3:54                                                 ` Theodore Tso
2026-07-15  7:13                                                   ` Mauro Carvalho Chehab
2026-07-15 12:42                                                     ` James Bottomley
2026-07-15 16:18                                                       ` Laurent Pinchart
2026-07-15 16:53                                                         ` James Bottomley
2026-07-15 17:09                                                           ` Laurent Pinchart
2026-07-15 16:11                                                   ` Laurent Pinchart
2026-07-15 17:00                                                     ` Jan Kara
2026-07-15 20:28                                                       ` Laurent Pinchart
2026-07-15 20:36                                                         ` James Bottomley
2026-07-15 20:42                                                           ` Laurent Pinchart
2026-07-16  0:14                                                             ` Roman Gushchin
2026-07-16  7:04                                                           ` Mauro Carvalho Chehab [this message]
2026-07-15 23:32                                                         ` Steven Rostedt
2026-07-16  0:03                                                           ` Roman Gushchin
2026-07-16  7:21                                                         ` Mauro Carvalho Chehab
2026-07-15 17:14                                                     ` Theodore Tso
2026-07-15 17:35                                                       ` Miguel Ojeda
2026-07-15 17:41                                                       ` Laurent Pinchart
2026-07-15 18:18                                                         ` Linus Torvalds
2026-07-15 18:51                                                           ` Laurent Pinchart
2026-07-15 19:14                                                             ` Linus Torvalds
2026-07-15 20:13                                                               ` Laurent Pinchart
2026-07-15 16:28                                                 ` Ihor Solodrai
2026-07-15 16:39                                                   ` Laurent Pinchart
2026-07-15 17:12                                                     ` Ihor Solodrai
2026-07-15 17:35                                                       ` Mark Brown
2026-07-15 18:39                                                         ` Ihor Solodrai
2026-07-15 20:32                                                           ` Mark Brown
2026-07-15 19:06                                                       ` Laurent Pinchart
2026-07-15 21:13                                                         ` Theodore Tso
2026-07-16  3:00                                                           ` Nicolas Dufresne
2026-07-16  3:53                                                             ` Theodore Tso
2026-07-16  7:55                                                               ` Mauro Carvalho Chehab
2026-07-16  6:23                                                           ` Jai Luthra
2026-07-15 17:41                                                     ` Jason Gunthorpe
2026-07-15 19:10                                                       ` Laurent Pinchart
2026-07-15 19:55                                                         ` Mark Brown
2026-07-15 19:38                                                       ` Dmitry Torokhov
2026-07-15 21:27 voste62ocr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260716090401.193720d2@foz.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=debarbos@redhat.com \
    --cc=jack@suse.cz \
    --cc=jgg@ziepe.ca \
    --cc=konstantin@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=roman.gushchin@linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=stephenfin@redhat.com \
    --cc=tytso@mit.edu \
    --cc=users@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox