From: Antti Palosaari <crope@iki.fi>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: linux-media@vger.kernel.org, Nibble Max <nibble.max@gmail.com>,
Olli Salonen <olli.salonen@iki.fi>,
Evgeny Plehov <EvgenyPlehov@ukr.net>
Subject: Re: [GIT PULL FINAL 01/21] si2168: clean logging
Date: Fri, 22 Aug 2014 15:50:03 +0300 [thread overview]
Message-ID: <53F73C7B.3080901@iki.fi> (raw)
In-Reply-To: <20140822072856.47b021e5.m.chehab@samsung.com>
On 08/22/2014 03:28 PM, Mauro Carvalho Chehab wrote:
> Em Fri, 22 Aug 2014 15:13:47 +0300
> Antti Palosaari <crope@iki.fi> escreveu:
>
>> On 08/22/2014 02:47 PM, Mauro Carvalho Chehab wrote:
>>> Hi Antti,
>>>
>>> Please don't add "GIT PULL" on patches. That breaks my scripts, as they
>>> will run a completely different logic when those magic words are there
>>> on a message at patchwork.
>>>
>>> Also, the word "FINAL" makes me nervous... That means that you sent me
>>> a non-final pull request?
>>
>> I didn't find better term. Also for eyes it wasn't proper term, but
>> there is no such prefix which fits that case:
>> http://lwn.net/Articles/529490/
>
> What is written there is:
>
> Once your patches have been reviewed/acked you can post either a pull request
> ("[GIT PULL]") or use the "[FINAL PATCH x/y]" tag if you don't have a public
> git tree.
>
> E. g. either send git pull or tag the patches as final, *if* the person
> sending the patches doesn't have a public git tree (although, in practice,
> I think that nobody is using FINAL on patches nowadays).
>
> I don't have any issue if someone uses "FINAL" on patches, but what
> turns on a red flag is when someone uses "FINAL" on a git pull request,
> because a pull request should be sent only when the patches are already ok.
>
> In other words, a FINAL word on a GIT PULL makes me wander that there
> is a previous pull request that is bad, but it doesn't give any glue
> about what pull request is broken.
>
> Is it the case of this pull request? If so, what previous pull
> request is broken?
>
> I would rather strongly prefer that, in the case that you sent a previous
> pull request that should be discarded, that you would reply to the
> original GIT PULL request thread with a NACK for me to be aware that
> I should discard it at patchwork.
There was no previous pull request. I just decided to send whole pull
request to mailing list for last minute review, like they do on stable
cases. But sure I could next time just pick patches and send pull
request only.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-08-22 12:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 10:57 [GIT PULL FINAL 00/21] misc DTV stuff for 3.18 Antti Palosaari
2014-08-22 10:57 ` [GIT PULL FINAL 01/21] si2168: clean logging Antti Palosaari
2014-08-22 11:47 ` Mauro Carvalho Chehab
2014-08-22 12:13 ` Antti Palosaari
2014-08-22 12:28 ` Mauro Carvalho Chehab
2014-08-22 12:50 ` Antti Palosaari [this message]
2014-08-22 13:41 ` Mauro Carvalho Chehab
2014-08-22 10:57 ` [GIT PULL FINAL 02/21] si2157: " Antti Palosaari
2014-08-22 10:57 ` [GIT PULL FINAL 03/21] m88ds3103: implement set voltage and TS clock Antti Palosaari
2014-08-22 10:57 ` [GIT PULL FINAL 04/21] si2168: add ts_mode setting and move to si2168_init Antti Palosaari
2014-08-22 10:57 ` [GIT PULL FINAL 05/21] em28xx: add ts mode setting for PCTV 292e Antti Palosaari
2014-08-22 10:57 ` [GIT PULL FINAL 06/21] cxusb: add ts mode setting for TechnoTrend CT2-4400 Antti Palosaari
2014-08-22 10:57 ` [GIT PULL FINAL 07/21] sp2: Add I2C driver for CIMaX SP2 common interface module Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 08/21] cxusb: Add support for TechnoTrend TT-connect CT2-4650 CI Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 09/21] cxusb: Add read_mac_address for TT CT2-4400 and CT2-4650 Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 10/21] si2168: DVB-T2 PLP selection implemented Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 11/21] si2157: Add support for delivery system SYS_ATSC Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 12/21] dvb-usb-v2: remove dvb_usb_device NULL check Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 13/21] msi2500: remove unneeded local pointer on msi2500_isoc_init() Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 14/21] m88ts2022: fix 32bit overflow on filter calc Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 15/21] m88ts2022: fix coding style issues Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 16/21] m88ts2022: rename device state (priv => s) Antti Palosaari
2014-09-02 18:51 ` Mauro Carvalho Chehab
2014-09-03 2:26 ` Antti Palosaari
2014-09-03 10:38 ` Mauro Carvalho Chehab
2014-09-03 10:50 ` Antti Palosaari
2014-09-03 11:47 ` Mauro Carvalho Chehab
2014-08-22 10:58 ` [GIT PULL FINAL 17/21] m88ts2022: clean up logging Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 18/21] m88ts2022: convert to RegMap I2C API Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 19/21] m88ts2022: change parameter type of m88ts2022_cmd Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 20/21] m88ds3103: change .set_voltage() implementation Antti Palosaari
2014-08-22 10:58 ` [GIT PULL FINAL 21/21] m88ds3103: fix coding style issues Antti Palosaari
2014-08-22 11:08 ` [GIT PULL FINAL 00/21] misc DTV stuff for 3.18 Antti Palosaari
2014-09-02 18:59 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F73C7B.3080901@iki.fi \
--to=crope@iki.fi \
--cc=EvgenyPlehov@ukr.net \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=nibble.max@gmail.com \
--cc=olli.salonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox