From: Vijay Kumar Tumati <vijay.tumati@oss.qualcomm.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com,
Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
Atiya Kailany <atiya.kailany@oss.qualcomm.com>
Subject: Re: [PATCH v6 4/5] media: qcom: camss: csid: Add support for CSID 1080
Date: Tue, 18 Nov 2025 14:00:54 -0800 [thread overview]
Message-ID: <5fee98e6-019c-41f1-b13b-ce06c736147d@oss.qualcomm.com> (raw)
In-Reply-To: <ced2ad99-fe9a-4794-be2f-f8760deed0a1@linaro.org>
On 11/18/2025 1:41 AM, Bryan O'Donoghue wrote:
> On 14/11/2025 03:29, Hangxiang Ma wrote:
>> + /* note: for non-RDI path, this should be format->decode_format */
>> + val |= DECODE_FORMAT_PAYLOAD_ONLY << RDI_CFG0_DECODE_FORMAT;
>> + val |= vc << RDI_CFG0_VC;
>> + val |= format->data_type << RDI_CFG0_DT;
>> + writel(val, csid->base + CSID_RDI_CFG0(vc));
>
> Why not just add that code now ?
>
> ---
> bod
Hi Bryan, I think this has been carried over from previous versions and
the comment is trying to say that, for RDI path alone we can just dump
the data into the buffer without any decoding and the format becomes
more relevant for pixel processing as CSID needs to decode the input
byte stream first. Either way, if this is a stand alone entity, we can
discuss offline and push another patch series to handle this? Please
advise. Thanks.
next prev parent reply other threads:[~2025-11-18 22:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 3:29 [PATCH v6 0/5] media: qcom: camss: Add Kaanapali support Hangxiang Ma
2025-11-14 3:29 ` [PATCH v6 1/5] media: dt-bindings: Add CAMSS device for Kaanapali Hangxiang Ma
2025-11-15 11:25 ` Krzysztof Kozlowski
2025-11-16 13:50 ` Bryan O'Donoghue
2025-11-18 15:00 ` Bryan O'Donoghue
2025-11-18 18:25 ` Vijay Kumar Tumati
2025-11-18 18:44 ` Konrad Dybcio
2025-11-18 21:45 ` Vijay Kumar Tumati
2025-11-19 9:21 ` Bryan O'Donoghue
2025-11-19 13:29 ` Vijay Kumar Tumati
2025-12-12 12:49 ` Vladimir Zapolskiy
2025-12-16 17:55 ` Vijay Kumar Tumati
2025-12-17 0:02 ` Vladimir Zapolskiy
2025-12-17 0:46 ` Vijay Kumar Tumati
2025-12-17 3:29 ` Bryan O'Donoghue
2025-12-20 16:04 ` Vijay Kumar Tumati
2025-12-17 3:22 ` Bryan O'Donoghue
2025-12-17 3:20 ` Bryan O'Donoghue
2025-11-14 3:29 ` [PATCH v6 2/5] media: qcom: camss: Add Kaanapali compatible camss driver Hangxiang Ma
2025-11-16 13:50 ` Bryan O'Donoghue
2025-11-14 3:29 ` [PATCH v6 3/5] media: qcom: camss: csiphy: Add support for v2.4.0 two-phase CSIPHY Hangxiang Ma
2025-11-16 13:50 ` Bryan O'Donoghue
2025-11-14 3:29 ` [PATCH v6 4/5] media: qcom: camss: csid: Add support for CSID 1080 Hangxiang Ma
2025-11-18 9:41 ` Bryan O'Donoghue
2025-11-18 22:00 ` Vijay Kumar Tumati [this message]
2025-11-18 9:43 ` Bryan O'Donoghue
2025-11-19 0:23 ` Vijay Kumar Tumati
2025-11-14 3:29 ` [PATCH v6 5/5] media: qcom: camss: vfe: Add support for VFE 1080 Hangxiang Ma
2025-11-18 9:58 ` Bryan O'Donoghue
2025-11-19 0:31 ` Vijay Kumar Tumati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fee98e6-019c-41f1-b13b-ce06c736147d@oss.qualcomm.com \
--to=vijay.tumati@oss.qualcomm.com \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=andi.shyti@kernel.org \
--cc=atiya.kailany@oss.qualcomm.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hangxiang.ma@oss.qualcomm.com \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=todor.too@gmail.com \
--cc=trilok.soni@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=yijie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox