From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Scally <djrscally@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kate Hsuan <hpa@redhat.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
libcamera-devel@lists.libcamera.org
Subject: Re: Fwd: Surface Go VCM type (was: Need to pass acpi_enforce_resources=lax on the Surface Go (version1))
Date: Thu, 4 Nov 2021 20:14:19 +0200 [thread overview]
Message-ID: <YYQi+zpAxPDvdCHx@smile.fi.intel.com> (raw)
In-Reply-To: <8d0470d3-7356-b476-6807-5c8606ee3545@redhat.com>
On Thu, Nov 04, 2021 at 03:49:48PM +0100, Hans de Goede wrote:
> On 11/2/21 00:43, Daniel Scally wrote:
...
> Ok, I've figured this out now, with the attached patch (which also
> explains what is going on) as well as an updated tps68470_board_data.c
> with updated regulator_init_data for the VCM (also attached), the driver
> can now successfully talk to the VCM in probe() while we are NOT
> streaming from the ov8865.
Thanks, Hans.
...
> const struct int3472_tps68470_board_data *int3472_tps68470_get_board_data(const char *dev_name)
> {
> const struct int3472_tps68470_board_data *board_data;
> const struct dmi_system_id *match;
>
> match = dmi_first_match(int3472_tps68470_board_data_table);
> while (match) {
> board_data = match->driver_data;
> if (strcmp(board_data->dev_name, dev_name) == 0)
> return board_data;
> dmi_first_match(++match);
Not sure I understood the purpose of the call.
> }
> return NULL;
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-04 18:14 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e2312277-f967-7d3f-5ce9-fbb197d35fd6@gmail.com>
2021-10-29 11:50 ` Fwd: Surface Go VCM type (was: Need to pass acpi_enforce_resources=lax on the Surface Go (version1)) Daniel Scally
2021-11-01 15:55 ` Andy Shevchenko
2021-11-01 15:59 ` Andy Shevchenko
2021-11-01 23:26 ` Daniel Scally
2021-11-01 16:02 ` Hans de Goede
2021-11-01 19:18 ` Andy Shevchenko
2021-11-01 19:51 ` Hans de Goede
2021-11-01 23:43 ` Daniel Scally
2021-11-04 14:49 ` Hans de Goede
2021-11-04 18:14 ` Andy Shevchenko [this message]
2021-11-06 14:12 ` Hans de Goede
2021-11-06 18:39 ` Andy Shevchenko
2021-11-04 23:20 ` Daniel Scally
2021-11-08 13:12 ` Hans de Goede
2021-11-08 14:12 ` Andy Shevchenko
2021-11-16 9:54 ` Hans de Goede
2021-11-16 12:26 ` Andy Shevchenko
2021-11-09 0:43 ` Daniel Scally
2021-11-09 12:09 ` Daniel Scally
2021-11-09 16:02 ` Hans de Goede
2021-11-09 16:35 ` Daniel Scally
2021-11-10 0:01 ` Daniel Scally
2021-11-10 8:15 ` Andy Shevchenko
2021-11-11 10:35 ` Hans de Goede
2021-11-11 11:18 ` Daniel Scally
2021-11-11 15:23 ` Hans de Goede
2021-11-11 15:51 ` Dave Stevenson
2021-11-11 16:50 ` Hans de Goede
2021-11-11 19:30 ` Dave Stevenson
2021-11-11 22:04 ` Laurent Pinchart
2021-11-12 10:32 ` Dave Stevenson
2021-11-12 10:46 ` Laurent Pinchart
2021-11-12 11:37 ` Andy Shevchenko
2021-11-15 13:33 ` Laurent Pinchart
2021-11-15 15:03 ` Andy Shevchenko
2021-11-12 11:43 ` Dave Stevenson
2021-11-15 13:21 ` Laurent Pinchart
2021-11-12 12:23 ` Sakari Ailus
2021-11-15 12:00 ` Laurent Pinchart
2021-11-12 17:51 ` [libcamera-devel] " Kieran Bingham
2021-11-15 13:08 ` Laurent Pinchart
2021-11-11 15:51 ` Laurent Pinchart
2021-11-23 12:10 ` Daniel Scally
2021-11-23 19:02 ` Hans de Goede
2021-11-11 15:59 ` Hans de Goede
2021-11-15 23:43 ` Daniel Scally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYQi+zpAxPDvdCHx@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=libcamera-devel@lists.libcamera.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox