From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hans Verkuil <hverkuil+cisco@kernel.org>
Cc: linux-media@vger.kernel.org, Mauricio Faria de Oliveira <mfo@igalia.com>
Subject: Re: [PATCHv3 5/6] media: em28xx: dev_info->pr_info since dev has been freed
Date: Tue, 30 Jun 2026 15:57:02 +0300 [thread overview]
Message-ID: <akO9Hoe-2nYjVY7c@kekkonen.localdomain> (raw)
In-Reply-To: <6a8b16c4ba53cf18f2f175313ccbcb2c3aad786f.1782716154.git.hverkuil+cisco@kernel.org>
Hi Hans,
On Mon, Jun 29, 2026 at 08:55:53AM +0200, Hans Verkuil wrote:
> In em28xx_free_device() dev_info passed &dev->intf->dev,
> but that device can be freed already.
>
> Just use pr_info instead.
>
> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
> ---
> drivers/media/usb/em28xx/em28xx-cards.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
> index fbfb74eab475..4d1e48c86ce8 100644
> --- a/drivers/media/usb/em28xx/em28xx-cards.c
> +++ b/drivers/media/usb/em28xx/em28xx-cards.c
> @@ -3758,7 +3758,7 @@ void em28xx_free_device(struct kref *ref)
> {
> struct em28xx *dev = kref_to_dev(ref);
>
> - dev_info(&dev->intf->dev, "Freeing device\n");
> + pr_info("%s: Freeing device\n", dev->name);
Is there a need to print anything at this point? I'd use pr_debug() here,
if not nothing at all.
>
> if (!dev->disconnected)
> em28xx_release_resources(dev);
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2026-06-30 12:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 6:55 [PATCHv3 0/6] media: em28xx: fix lifecycle issues Hans Verkuil
2026-06-29 6:55 ` [PATCHv3 1/6] media: core: v4l2-async.c: unreg subdev if asc_list is empty Hans Verkuil
2026-06-30 7:58 ` Sakari Ailus
2026-06-30 8:32 ` Hans Verkuil
2026-06-30 8:45 ` Sakari Ailus
2026-06-30 9:38 ` Hans Verkuil
2026-06-30 10:02 ` [PATCHv4 1/6] media: core: v4l2-async.c: unreg subdev if asc_list is, empty Hans Verkuil
2026-06-30 10:13 ` Sakari Ailus
2026-06-30 12:52 ` Hans Verkuil
2026-06-29 6:55 ` [PATCHv3 2/6] media: em28xx: use v4l2_device release callback Hans Verkuil
2026-06-29 6:55 ` [PATCHv3 3/6] media: em28xx: drop 'users' field Hans Verkuil
2026-06-29 6:55 ` [PATCHv3 4/6] media: em28xx: use vb2_video_unregister_device Hans Verkuil
2026-06-29 6:55 ` [PATCHv3 5/6] media: em28xx: dev_info->pr_info since dev has been freed Hans Verkuil
2026-06-30 12:57 ` Sakari Ailus [this message]
2026-06-29 6:55 ` [PATCHv3 6/6] media: em28xx: requeue buffers if start_streaming fails Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akO9Hoe-2nYjVY7c@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil+cisco@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mfo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox