Linux Media Controller development
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hans Verkuil <hverkuil+cisco@kernel.org>
Cc: linux-media@vger.kernel.org, Mauricio Faria de Oliveira <mfo@igalia.com>
Subject: Re: [PATCHv4 1/6] media: core: v4l2-async.c: unreg subdev if asc_list is, empty
Date: Tue, 30 Jun 2026 13:13:38 +0300	[thread overview]
Message-ID: <akOW0ioLKG7WxFHH@kekkonen.localdomain> (raw)
In-Reply-To: <05d38e6d-5f18-4d70-983b-1a28ddd22535@kernel.org>

Hi Hans,

Thanks for the update.

Did you notice my comment on the subject?

On Tue, Jun 30, 2026 at 12:02:53PM +0200, Hans Verkuil wrote:
> When my em28xx USB device that uses the i2c tvp5150 driver is
> disconnected, it crashes.
> 
> The cause is that the tvp5150 i2c module uses v4l2_async, but
> the em28xx driver does not since it predates v4l2_async.
> 
> In that corner case sd->asc_list is empty, so
> v4l2_async_unregister_subdev() never calls v4l2_device_unregister_subdev().
> 
> Modify the code so that, if sd->asc_list is empty,
> v4l2_device_unregister_subdev() is still called.
> 
> Fixes: 28a1295795d8 ("media: v4l: async: Allow multiple connections between entities")
> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Kind regards,

Sakari Ailus

  reply	other threads:[~2026-06-30 10:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  6:55 [PATCHv3 0/6] media: em28xx: fix lifecycle issues Hans Verkuil
2026-06-29  6:55 ` [PATCHv3 1/6] media: core: v4l2-async.c: unreg subdev if asc_list is empty Hans Verkuil
2026-06-30  7:58   ` Sakari Ailus
2026-06-30  8:32     ` Hans Verkuil
2026-06-30  8:45       ` Sakari Ailus
2026-06-30  9:38         ` Hans Verkuil
2026-06-30 10:02   ` [PATCHv4 1/6] media: core: v4l2-async.c: unreg subdev if asc_list is, empty Hans Verkuil
2026-06-30 10:13     ` Sakari Ailus [this message]
2026-06-30 12:52       ` Hans Verkuil
2026-06-29  6:55 ` [PATCHv3 2/6] media: em28xx: use v4l2_device release callback Hans Verkuil
2026-06-29  6:55 ` [PATCHv3 3/6] media: em28xx: drop 'users' field Hans Verkuil
2026-06-29  6:55 ` [PATCHv3 4/6] media: em28xx: use vb2_video_unregister_device Hans Verkuil
2026-06-29  6:55 ` [PATCHv3 5/6] media: em28xx: dev_info->pr_info since dev has been freed Hans Verkuil
2026-06-30 12:57   ` Sakari Ailus
2026-06-29  6:55 ` [PATCHv3 6/6] media: em28xx: requeue buffers if start_streaming fails Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akOW0ioLKG7WxFHH@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mfo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox