Re: [PATCHv4 1/6] media: core: v4l2-async.c: unreg subdev if asc_list is, empty

[Hans Verkuil <hverkuil+cisco@kernel.org>]

On 6/30/26 12:13, Sakari Ailus wrote:
> Hi Hans,
> 
> Thanks for the update.
> 
> Did you notice my comment on the subject?

No, I missed that :-)

Fixed in my branch.

> 
> On Tue, Jun 30, 2026 at 12:02:53PM +0200, Hans Verkuil wrote:
>> When my em28xx USB device that uses the i2c tvp5150 driver is
>> disconnected, it crashes.
>>
>> The cause is that the tvp5150 i2c module uses v4l2_async, but
>> the em28xx driver does not since it predates v4l2_async.
>>
>> In that corner case sd->asc_list is empty, so
>> v4l2_async_unregister_subdev() never calls v4l2_device_unregister_subdev().
>>
>> Modify the code so that, if sd->asc_list is empty,
>> v4l2_device_unregister_subdev() is still called.
>>
>> Fixes: 28a1295795d8 ("media: v4l: async: Allow multiple connections between entities")
>> Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
> 
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> 

Much appreciated!

Hopefully once this patch series lands it will finally stop people from posting
bad em28xx patches 'fixing' the syzkaller issues due to this.

That reminds me, I need to add a:

Tested-by: Hans Verkuil <hverkuil+cisco@kernel.org>

to this series.

Regards,

	Hans