* [PATCH 2/3] mt76: mt7615: add 4 WMM sets support [not found] ` <50d28c9b0f9e7d6b277d36fc93f55142d7535259.1563518381.git.ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> @ 2019-07-19 6:55 ` Ryder Lee [not found] ` <CA+zupgwyz2hdVRmnGr+4vzeEfvTfxYkLmu6jD_jFNjrPAdbvCQ@mail.gmail.com> 2019-07-19 6:55 ` [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values Ryder Lee 1 sibling, 1 reply; 7+ messages in thread From: Ryder Lee @ 2019-07-19 6:55 UTC (permalink / raw) To: Felix Fietkau, Lorenzo Bianconi Cc: Roy Luo, YF Luo, Yiwei Chung, Sean Wang, linux-wireless-u79uwXL29TY76Z2rM5mHXA, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Ryder Lee MT7615 hardware supoorts 4 WMM sets, so this patch adds them accordingly. Also remove incorrect queue mapping in .conf_tx Signed-off-by: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> --- drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 5 +++-- drivers/net/wireless/mediatek/mt76/mt7615/main.c | 16 ++++++---------- .../net/wireless/mediatek/mt76/mt7615/mt7615.h | 1 + 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c index 8f9a2bb68ded..d85b3904f33a 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c @@ -314,7 +314,7 @@ int mt7615_mac_write_txwi(struct mt7615_dev *dev, __le32 *txwi, struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; struct ieee80211_vif *vif = info->control.vif; int tx_count = 8; - u8 fc_type, fc_stype, p_fmt, q_idx, omac_idx = 0; + u8 fc_type, fc_stype, p_fmt, q_idx, omac_idx = 0, wmm_idx = 0; __le16 fc = hdr->frame_control; u16 seqno = 0; u32 val; @@ -323,6 +323,7 @@ int mt7615_mac_write_txwi(struct mt7615_dev *dev, __le32 *txwi, struct mt7615_vif *mvif = (struct mt7615_vif *)vif->drv_priv; omac_idx = mvif->omac_idx; + wmm_idx = mvif->wmm_idx; } if (sta) { @@ -335,7 +336,7 @@ int mt7615_mac_write_txwi(struct mt7615_dev *dev, __le32 *txwi, fc_stype = (le16_to_cpu(fc) & IEEE80211_FCTL_STYPE) >> 4; if (ieee80211_is_data(fc) || ieee80211_is_bufferable_mmpdu(fc)) { - q_idx = skb_get_queue_mapping(skb); + q_idx = skb_get_queue_mapping(skb) + wmm_idx * MT7615_MAX_WMM_SETS; p_fmt = MT_TX_TYPE_CT; } else if (ieee80211_is_beacon(fc)) { q_idx = MT_LMAC_BCN0; diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/main.c b/drivers/net/wireless/mediatek/mt76/mt7615/main.c index 2c702b31d55f..ea48dcdb65c0 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/main.c @@ -85,9 +85,9 @@ static int mt7615_add_interface(struct ieee80211_hw *hw, } mvif->omac_idx = idx; - /* TODO: DBDC support. Use band 0 and wmm 0 for now */ + /* TODO: DBDC support. Use band 0 for now */ mvif->band_idx = 0; - mvif->wmm_idx = 0; + mvif->wmm_idx = mvif->idx % MT7615_MAX_WMM_SETS; ret = mt7615_mcu_set_dev_info(dev, vif, 1); if (ret) @@ -241,16 +241,12 @@ static int mt7615_conf_tx(struct ieee80211_hw *hw, struct ieee80211_vif *vif, u16 queue, const struct ieee80211_tx_queue_params *params) { + struct mt7615_vif *mvif = (struct mt7615_vif *)vif->drv_priv; struct mt7615_dev *dev = hw->priv; - static const u8 wmm_queue_map[] = { - [IEEE80211_AC_BK] = 0, - [IEEE80211_AC_BE] = 1, - [IEEE80211_AC_VI] = 2, - [IEEE80211_AC_VO] = 3, - }; - /* TODO: hw wmm_set 1~3 */ - return mt7615_mcu_set_wmm(dev, wmm_queue_map[queue], params); + queue += mvif->wmm_idx * MT7615_MAX_WMM_SETS; + + return mt7615_mcu_set_wmm(dev, queue, params); } static void mt7615_configure_filter(struct ieee80211_hw *hw, diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h b/drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h index 2f43101343c3..f3f1738a01e7 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h @@ -10,6 +10,7 @@ #include "regs.h" #define MT7615_MAX_INTERFACES 4 +#define MT7615_MAX_WMM_SETS 4 #define MT7615_WTBL_SIZE 128 #define MT7615_WTBL_RESERVED (MT7615_WTBL_SIZE - 1) #define MT7615_WTBL_STA (MT7615_WTBL_RESERVED - \ -- 2.18.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <CA+zupgwyz2hdVRmnGr+4vzeEfvTfxYkLmu6jD_jFNjrPAdbvCQ@mail.gmail.com>]
[parent not found: <CA+zupgwyz2hdVRmnGr+4vzeEfvTfxYkLmu6jD_jFNjrPAdbvCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 2/3] mt76: mt7615: add 4 WMM sets support [not found] ` <CA+zupgwyz2hdVRmnGr+4vzeEfvTfxYkLmu6jD_jFNjrPAdbvCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2019-07-19 7:27 ` Ryder Lee 0 siblings, 0 replies; 7+ messages in thread From: Ryder Lee @ 2019-07-19 7:27 UTC (permalink / raw) To: Roy Luo Cc: Sean Wang, YF Luo, linux-wireless-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Yiwei Chung, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Lorenzo Bianconi, Felix Fietkau On Fri, 2019-07-19 at 15:05 +0800, Roy Luo wrote: > > > > On Fri, Jul 19, 2019 at 2:55 PM Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> > wrote: > > MT7615 hardware supoorts 4 WMM sets, so this patch adds them > accordingly. > Also remove incorrect queue mapping in .conf_tx > > Signed-off-by: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> > --- > drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 5 +++-- > drivers/net/wireless/mediatek/mt76/mt7615/main.c | 16 > ++++++---------- > .../net/wireless/mediatek/mt76/mt7615/mt7615.h | 1 + > 3 files changed, 10 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c > b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c > index 8f9a2bb68ded..d85b3904f33a 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c > @@ -314,7 +314,7 @@ int mt7615_mac_write_txwi(struct > mt7615_dev *dev, __le32 *txwi, > struct ieee80211_hdr *hdr = (struct ieee80211_hdr > *)skb->data; > struct ieee80211_vif *vif = info->control.vif; > int tx_count = 8; > - u8 fc_type, fc_stype, p_fmt, q_idx, omac_idx = 0; > + u8 fc_type, fc_stype, p_fmt, q_idx, omac_idx = 0, > wmm_idx = 0; > __le16 fc = hdr->frame_control; > u16 seqno = 0; > u32 val; > @@ -323,6 +323,7 @@ int mt7615_mac_write_txwi(struct > mt7615_dev *dev, __le32 *txwi, > struct mt7615_vif *mvif = (struct mt7615_vif > *)vif->drv_priv; > > omac_idx = mvif->omac_idx; > + wmm_idx = mvif->wmm_idx; > } > > if (sta) { > @@ -335,7 +336,7 @@ int mt7615_mac_write_txwi(struct > mt7615_dev *dev, __le32 *txwi, > fc_stype = (le16_to_cpu(fc) & IEEE80211_FCTL_STYPE) >> > 4; > > if (ieee80211_is_data(fc) || > ieee80211_is_bufferable_mmpdu(fc)) { > - q_idx = skb_get_queue_mapping(skb); > + q_idx = skb_get_queue_mapping(skb) + wmm_idx * > MT7615_MAX_WMM_SETS; > p_fmt = MT_TX_TYPE_CT; > } else if (ieee80211_is_beacon(fc)) { > q_idx = MT_LMAC_BCN0; > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/main.c > b/drivers/net/wireless/mediatek/mt76/mt7615/main.c > index 2c702b31d55f..ea48dcdb65c0 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7615/main.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/main.c > @@ -85,9 +85,9 @@ static int mt7615_add_interface(struct > ieee80211_hw *hw, > } > mvif->omac_idx = idx; > > - /* TODO: DBDC support. Use band 0 and wmm 0 for now */ > + /* TODO: DBDC support. Use band 0 for now */ > mvif->band_idx = 0; > - mvif->wmm_idx = 0; > + mvif->wmm_idx = mvif->idx % MT7615_MAX_WMM_SETS; > > > > IIUC, vifs with the same wmm_idx will share the same WMM HW, thus the > same WMM parameter. > Shouldn't we assign wmm_idx based on that? I think that's what I did here. vif0 <-> wmm0, vif1 <->wmm1 ... > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values [not found] ` <50d28c9b0f9e7d6b277d36fc93f55142d7535259.1563518381.git.ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> 2019-07-19 6:55 ` [PATCH 2/3] mt76: mt7615: add 4 WMM sets support Ryder Lee @ 2019-07-19 6:55 ` Ryder Lee 2019-07-19 10:17 ` Ryder Lee 2019-07-21 10:28 ` Kalle Valo 1 sibling, 2 replies; 7+ messages in thread From: Ryder Lee @ 2019-07-19 6:55 UTC (permalink / raw) To: Felix Fietkau, Lorenzo Bianconi Cc: Sean Wang, YF Luo, linux-wireless-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Ryder Lee, Yiwei Chung, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Roy Luo Add initial values in mt7615_mcu_set_wmm() to cleanup setup flow. Signed-off-by: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> --- drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c index 5fd162be3654..154c09428b69 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c @@ -622,10 +622,7 @@ int mt7615_mcu_set_rts_thresh(struct mt7615_dev *dev, u32 val) int mt7615_mcu_set_wmm(struct mt7615_dev *dev, u8 queue, const struct ieee80211_tx_queue_params *params) { -#define WMM_AIFS_SET BIT(0) -#define WMM_CW_MIN_SET BIT(1) -#define WMM_CW_MAX_SET BIT(2) -#define WMM_TXOP_SET BIT(3) +#define WMM_PARAM_SET GENMASK(3, 0) struct req_data { u8 number; u8 rsv[3]; @@ -638,19 +635,17 @@ int mt7615_mcu_set_wmm(struct mt7615_dev *dev, u8 queue, } __packed req = { .number = 1, .queue = queue, - .valid = WMM_AIFS_SET | WMM_TXOP_SET, + .valid = WMM_PARAM_SET, .aifs = params->aifs, + .cw_min = BIT(5) - 1, + .cw_max = cpu_to_le16(BIT(10) - 1), .txop = cpu_to_le16(params->txop), }; - if (params->cw_min) { - req.valid |= WMM_CW_MIN_SET; + if (params->cw_min) req.cw_min = params->cw_min; - } - if (params->cw_max) { - req.valid |= WMM_CW_MAX_SET; + if (params->cw_max) req.cw_max = cpu_to_le16(params->cw_max); - } return __mt76_mcu_send_msg(&dev->mt76, MCU_EXT_CMD_EDCA_UPDATE, &req, sizeof(req), true); -- 2.18.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values 2019-07-19 6:55 ` [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values Ryder Lee @ 2019-07-19 10:17 ` Ryder Lee 2019-07-21 10:28 ` Kalle Valo 1 sibling, 0 replies; 7+ messages in thread From: Ryder Lee @ 2019-07-19 10:17 UTC (permalink / raw) To: Felix Fietkau Cc: Lorenzo Bianconi, Roy Luo, YF Luo, Yiwei Chung, Sean Wang, linux-wireless, linux-mediatek, linux-kernel On Fri, 2019-07-19 at 14:55 +0800, Ryder Lee wrote: > Add initial values in mt7615_mcu_set_wmm() to cleanup setup flow. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- > drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c > index 5fd162be3654..154c09428b69 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c > @@ -622,10 +622,7 @@ int mt7615_mcu_set_rts_thresh(struct mt7615_dev *dev, u32 val) > int mt7615_mcu_set_wmm(struct mt7615_dev *dev, u8 queue, > const struct ieee80211_tx_queue_params *params) > { > -#define WMM_AIFS_SET BIT(0) > -#define WMM_CW_MIN_SET BIT(1) > -#define WMM_CW_MAX_SET BIT(2) > -#define WMM_TXOP_SET BIT(3) > +#define WMM_PARAM_SET GENMASK(3, 0) > struct req_data { > u8 number; > u8 rsv[3]; > @@ -638,19 +635,17 @@ int mt7615_mcu_set_wmm(struct mt7615_dev *dev, u8 queue, > } __packed req = { > .number = 1, > .queue = queue, > - .valid = WMM_AIFS_SET | WMM_TXOP_SET, > + .valid = WMM_PARAM_SET, > .aifs = params->aifs, > + .cw_min = BIT(5) - 1, > + .cw_max = cpu_to_le16(BIT(10) - 1), > .txop = cpu_to_le16(params->txop), > }; > > - if (params->cw_min) { > - req.valid |= WMM_CW_MIN_SET; > + if (params->cw_min) > req.cw_min = params->cw_min; > - } > - if (params->cw_max) { > - req.valid |= WMM_CW_MAX_SET; > + if (params->cw_max) > req.cw_max = cpu_to_le16(params->cw_max); > - } I should use fls() here and will send a v2 > return __mt76_mcu_send_msg(&dev->mt76, MCU_EXT_CMD_EDCA_UPDATE, > &req, sizeof(req), true); ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values 2019-07-19 6:55 ` [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values Ryder Lee 2019-07-19 10:17 ` Ryder Lee @ 2019-07-21 10:28 ` Kalle Valo 1 sibling, 0 replies; 7+ messages in thread From: Kalle Valo @ 2019-07-21 10:28 UTC (permalink / raw) To: Ryder Lee Cc: Felix Fietkau, Lorenzo Bianconi, Roy Luo, YF Luo, Yiwei Chung, Sean Wang, linux-wireless, linux-mediatek, linux-kernel Ryder Lee <ryder.lee@mediatek.com> writes: > Add initial values in mt7615_mcu_set_wmm() to cleanup setup flow. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> [...] > -#define WMM_AIFS_SET BIT(0) > -#define WMM_CW_MIN_SET BIT(1) > -#define WMM_CW_MAX_SET BIT(2) > -#define WMM_TXOP_SET BIT(3) > +#define WMM_PARAM_SET GENMASK(3, 0) I don't see how this is any better? IMHO you just hide what is the meaning of each bit. -- Kalle Valo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] mt76: fix checkpatch warnings and errors [not found] <50d28c9b0f9e7d6b277d36fc93f55142d7535259.1563518381.git.ryder.lee@mediatek.com> [not found] ` <50d28c9b0f9e7d6b277d36fc93f55142d7535259.1563518381.git.ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> @ 2019-07-21 10:26 ` Kalle Valo 2019-07-21 16:56 ` Joe Perches 1 sibling, 1 reply; 7+ messages in thread From: Kalle Valo @ 2019-07-21 10:26 UTC (permalink / raw) To: Ryder Lee Cc: Felix Fietkau, Lorenzo Bianconi, Roy Luo, YF Luo, Yiwei Chung, Sean Wang, linux-wireless, linux-mediatek, linux-kernel Ryder Lee <ryder.lee@mediatek.com> writes: > Fix warnings and errors as much as possible. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- > drivers/net/wireless/mediatek/mt76/agg-rx.c | 21 +++++---- > drivers/net/wireless/mediatek/mt76/dma.c | 2 +- > drivers/net/wireless/mediatek/mt76/mac80211.c | 30 ++++++------ > drivers/net/wireless/mediatek/mt76/mt76.h | 46 +++++++++---------- > .../wireless/mediatek/mt76/mt7603/beacon.c | 2 +- > .../net/wireless/mediatek/mt76/mt7603/core.c | 2 +- > .../wireless/mediatek/mt76/mt7603/debugfs.c | 2 +- > .../net/wireless/mediatek/mt76/mt7603/dma.c | 7 +-- > .../wireless/mediatek/mt76/mt7603/eeprom.c | 2 +- > .../net/wireless/mediatek/mt76/mt7603/init.c | 3 +- > .../net/wireless/mediatek/mt76/mt7603/mac.c | 6 +-- > .../net/wireless/mediatek/mt76/mt7603/main.c | 7 +-- > .../net/wireless/mediatek/mt76/mt7603/mcu.c | 2 +- > .../net/wireless/mediatek/mt76/mt7603/pci.c | 2 +- > .../net/wireless/mediatek/mt76/mt7603/soc.c | 2 +- > .../wireless/mediatek/mt76/mt7615/debugfs.c | 2 +- > .../net/wireless/mediatek/mt76/mt7615/mac.c | 5 +- > .../net/wireless/mediatek/mt76/mt7615/mcu.c | 2 - > .../wireless/mediatek/mt76/mt76x0/mt76x0.h | 2 +- > .../net/wireless/mediatek/mt76/mt76x0/phy.c | 23 ++++++---- > .../net/wireless/mediatek/mt76/mt76x0/phy.h | 10 ++-- > .../net/wireless/mediatek/mt76/mt76x0/usb.c | 6 +-- > drivers/net/wireless/mediatek/mt76/mt76x02.h | 24 +++++----- > .../wireless/mediatek/mt76/mt76x02_beacon.c | 3 +- > .../net/wireless/mediatek/mt76/mt76x02_mac.c | 16 +++---- > .../net/wireless/mediatek/mt76/mt76x02_mcu.c | 13 +++--- > .../net/wireless/mediatek/mt76/mt76x02_mmio.c | 11 +++-- > .../net/wireless/mediatek/mt76/mt76x02_phy.c | 3 +- > .../net/wireless/mediatek/mt76/mt76x02_regs.h | 18 ++++---- > .../wireless/mediatek/mt76/mt76x02_trace.h | 3 +- > .../wireless/mediatek/mt76/mt76x02_usb_core.c | 2 +- > .../net/wireless/mediatek/mt76/mt76x02_util.c | 20 ++++---- > .../wireless/mediatek/mt76/mt76x2/eeprom.c | 10 ++-- > .../wireless/mediatek/mt76/mt76x2/pci_init.c | 1 - > .../wireless/mediatek/mt76/mt76x2/pci_mcu.c | 4 +- > .../net/wireless/mediatek/mt76/mt76x2/phy.c | 3 +- > drivers/net/wireless/mediatek/mt76/trace.h | 9 ++-- > drivers/net/wireless/mediatek/mt76/tx.c | 14 +++--- > drivers/net/wireless/mediatek/mt76/usb.c | 31 +++++++------ > .../net/wireless/mediatek/mt76/usb_trace.h | 11 +++-- > drivers/net/wireless/mediatek/mt76/util.h | 4 +- > 41 files changed, 201 insertions(+), 185 deletions(-) This is way too big and the commit log is too vague, please fix one problem at a time and describe in the commit log what you fixed. -- Kalle Valo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] mt76: fix checkpatch warnings and errors 2019-07-21 10:26 ` [PATCH 1/3] mt76: fix checkpatch warnings and errors Kalle Valo @ 2019-07-21 16:56 ` Joe Perches 0 siblings, 0 replies; 7+ messages in thread From: Joe Perches @ 2019-07-21 16:56 UTC (permalink / raw) To: Kalle Valo, Ryder Lee Cc: Felix Fietkau, Lorenzo Bianconi, Roy Luo, YF Luo, Yiwei Chung, Sean Wang, linux-wireless, linux-mediatek, linux-kernel On Sun, 2019-07-21 at 13:26 +0300, Kalle Valo wrote: > Ryder Lee <ryder.lee@mediatek.com> writes: > > Fix warnings and errors as much as possible. [] > This is way too big and the commit log is too vague, please fix one > problem at a time and describe in the commit log what you fixed. Hello Ryder. One option is to perform all the whitespace corrections in a single patch and then show that the object files have not changed. I posted a trivial script several years ago that might be of some help here. https://lore.kernel.org/lkml/1405128087.6751.12.camel@joe-AO725/ It trivially reformats using checkpatch and produces a possible set of changes that can be used to update a git tree. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-07-21 16:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <50d28c9b0f9e7d6b277d36fc93f55142d7535259.1563518381.git.ryder.lee@mediatek.com>
[not found] ` <50d28c9b0f9e7d6b277d36fc93f55142d7535259.1563518381.git.ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-07-19 6:55 ` [PATCH 2/3] mt76: mt7615: add 4 WMM sets support Ryder Lee
[not found] ` <CA+zupgwyz2hdVRmnGr+4vzeEfvTfxYkLmu6jD_jFNjrPAdbvCQ@mail.gmail.com>
[not found] ` <CA+zupgwyz2hdVRmnGr+4vzeEfvTfxYkLmu6jD_jFNjrPAdbvCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-07-19 7:27 ` Ryder Lee
2019-07-19 6:55 ` [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values Ryder Lee
2019-07-19 10:17 ` Ryder Lee
2019-07-21 10:28 ` Kalle Valo
2019-07-21 10:26 ` [PATCH 1/3] mt76: fix checkpatch warnings and errors Kalle Valo
2019-07-21 16:56 ` Joe Perches
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox