Re: [V1,00/12] Enable jpeg enc & dec multi-hardwares for MT8196

["Kyrie Wu (吴晗)" <Kyrie.Wu@mediatek.com>]

On Thu, 2025-01-09 at 09:06 -0500, Nicolas Dufresne wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Hi,
> 
> Le jeudi 09 janvier 2025 à 21:35 +0800, kyrie.wu a écrit :
> > This series adds support for mt8196 multi-hardwares jpeg enc & dec,
> > by first adding mt8196 jpegdec and jpegenc compatible to install
> > kernel driver. Add smmu setting to support smmu and iommu at the
> > same time.
> > Secondly refactor buffer and clock setting to support multi-hw jpeg
> > working.
> > Lastly, fix some bugs, including resolution change handleing, stop
> > streaming sw flow and others.
> > 
> > This series has been tested with MT8196 tast test.
> > Encoding and decoding worked for this chip.
> > 
> > Patches 1-3 Adds jpeg encoder and decoder compatible.
> > Patches 4 add jpeg smmu sid setting.
> > Patches 5 fix jpeg hw count setting to support different chips.
> > Patches 6 refactor jpeg buffer payload setting to handle buffer
> > size bug while resolution changed.
> > Patches 7 reconstruct jpeg dst buffer layout.
> > Patches 8 fix multi-core stop streaming flow
> > Patches 9 refactor multi-core clk suspend/resume setting
> > Patches 10 fix decoding buffer number setting timing issue
> > Patches 11 refactor decoding resolution change operation
> > Patches 12 fix remove buffer operation
> > 
> > ---
> > This series patches dependent on:
> > [1]
> > 
https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20240808092555.12999-1-jianhua.lin@mediatek.com/__;!!CTRNKA9wMg0ARbw!mJmYHl_SoomWL8beP_5XuUZ0bpvhI_TqJVcDjN5mkxOnrNPnEkfu8-JdTfxx3Q6SZIEBU-3CvddOw-3uio1MxA$
> > 
> > kyrie.wu (11):
> 
> would you mind fixing the --author in your configuration, write your
> name
> instead of your user name. UT8 is allowed, many people will use a
> ASCI spelling
> (some approximation) and then add their real name in parenthesis.
> 
> regards,
> Nicolas

Dear Nicolas,

I have resent a new version, but I didn't view this mail in time.
Thanks for your advice, and I will fix it in the next version.

Thanks.

Regards,
Kyrie.
> 
> >   dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
> >   dt-bindings: mediatek: Add mediatek, mt8196-jpgenc compatible
> >   media: mediatek: jpeg: add jpeg compatible
> >   media: mediatek: jpeg: add jpeg smmu sid setting
> >   media: mediatek: jpeg: fix jpeg hw count setting
> >   media: mediatek: jpeg: refactor jpeg buffer payload setting
> >   media: mediatek: jpeg: refactor jpeg dst buffer layout
> >   media: mediatek: jpeg: fix stop streaming flow for multi-core
> >   media: mediatek: jpeg: refactor multi-core clk suspend and resume
> >     setting
> >   media: mediatek: jpeg: fix decoding buffer number setting timing
> > issue
> >   media: mediatek: jpeg: refactor decoding resolution change
> > operation
> >   media: mediatek: jpeg: fix remove buffer operation for multi-core
> > 
> >  ....yaml => mediatek,multi-core-jpegdec.yaml} |  10 +-
> >  ....yaml => mediatek,multi-core-jpegenc.yaml} |  10 +-
> >  .../platform/mediatek/jpeg/mtk_jpeg_core.c    | 126 ++++++++++++
> > ------
> >  .../platform/mediatek/jpeg/mtk_jpeg_core.h    |  17 ++-
> >  .../platform/mediatek/jpeg/mtk_jpeg_dec_hw.c  | 116
> > +++++++++++++++-
> >  .../platform/mediatek/jpeg/mtk_jpeg_dec_hw.h  |   4 +
> >  .../platform/mediatek/jpeg/mtk_jpeg_enc_hw.c  | 113
> > +++++++++++++++-
> >  .../platform/mediatek/jpeg/mtk_jpeg_enc_hw.h  |   4 +
> >  8 files changed, 343 insertions(+), 57 deletions(-)
> >  rename Documentation/devicetree/bindings/media/{mediatek,mt8195-
> > jpegdec.yaml => mediatek,multi-core-jpegdec.yaml} (95%)
> >  rename Documentation/devicetree/bindings/media/{mediatek,mt8195-
> > jpegenc.yaml => mediatek,multi-core-jpegenc.yaml} (94%)
> > 
> 
>