From: kyrie.wu <kyrie.wu@mediatek.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tzung-Bi Shih <tzungbi@chromium.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Bin Liu <bin.liu@mediatek.com>,
kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
kyrie.wu <kyrie.wu@mediatek.com>
Subject: [V1,12/12] media: mediatek: jpeg: fix remove buffer operation for multi-core
Date: Thu, 9 Jan 2025 21:35:12 +0800 [thread overview]
Message-ID: <20250109133513.20151-13-kyrie.wu@mediatek.com> (raw)
In-Reply-To: <20250109133513.20151-1-kyrie.wu@mediatek.com>
move remove buffer code to spinlock protect area for multi-core
Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
---
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
index 2919fdd92d45..065b35122acf 100644
--- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
@@ -1665,9 +1665,6 @@ static void mtk_jpegenc_worker(struct work_struct *work)
goto enc_end;
}
- v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
- v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
-
schedule_delayed_work(&comp_jpeg[hw_id]->job_timeout_work,
msecs_to_jiffies(MTK_JPEG_HW_TIMEOUT_MSEC));
@@ -1688,6 +1685,8 @@ static void mtk_jpegenc_worker(struct work_struct *work)
&src_buf->vb2_buf);
mtk_jpeg_set_enc_params(ctx, comp_jpeg[hw_id]->reg_base);
mtk_jpeg_enc_start(comp_jpeg[hw_id]->reg_base);
+ v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
+ v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
jpeg_buf_queue_inc(ctx);
v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx);
spin_unlock_irqrestore(&comp_jpeg[hw_id]->hw_lock, flags);
@@ -1770,9 +1769,6 @@ static void mtk_jpegdec_worker(struct work_struct *work)
goto dec_end;
}
- v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
- v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
-
mtk_jpeg_set_dec_src(ctx, &src_buf->vb2_buf, &bs);
if (mtk_jpeg_set_dec_dst(ctx,
&jpeg_src_buf->dec_param,
@@ -1800,6 +1796,8 @@ static void mtk_jpegdec_worker(struct work_struct *work)
jpeg_src_buf->bs_size,
&bs,
&fb);
+ v4l2_m2m_src_buf_remove(ctx->fh.m2m_ctx);
+ v4l2_m2m_dst_buf_remove(ctx->fh.m2m_ctx);
mtk_jpeg_dec_start(comp_jpeg[hw_id]->reg_base);
jpeg_buf_queue_inc(ctx);
v4l2_m2m_job_finish(jpeg->m2m_dev, ctx->fh.m2m_ctx);
--
2.46.0
next prev parent reply other threads:[~2025-01-09 13:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 13:35 [V1,00/12] Enable jpeg enc & dec multi-hardwares for MT8196 kyrie.wu
2025-01-09 13:35 ` [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible kyrie.wu
2025-01-09 13:54 ` Krzysztof Kozlowski
2025-04-07 7:13 ` Kyrie Wu (吴晗)
2025-04-07 7:19 ` Krzysztof Kozlowski
2025-04-07 9:39 ` Kyrie Wu (吴晗)
2025-01-09 13:35 ` [V1,02/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgenc compatible kyrie.wu
2025-01-09 13:35 ` [V1,03/12] media: mediatek: jpeg: add jpeg compatible kyrie.wu
2025-01-10 9:46 ` AngeloGioacchino Del Regno
2025-04-07 7:15 ` Kyrie Wu (吴晗)
2025-01-09 13:35 ` [V1,04/12] media: mediatek: jpeg: add jpeg smmu sid setting kyrie.wu
2025-01-10 9:39 ` AngeloGioacchino Del Regno
2025-04-07 7:21 ` Kyrie Wu (吴晗)
2025-01-09 13:35 ` [V1,05/12] media: mediatek: jpeg: fix jpeg hw count setting kyrie.wu
2025-01-10 9:45 ` AngeloGioacchino Del Regno
2025-04-07 7:23 ` Kyrie Wu (吴晗)
2025-01-09 13:35 ` [V1,06/12] media: mediatek: jpeg: refactor jpeg buffer payload setting kyrie.wu
2025-01-09 13:35 ` [V1,07/12] media: mediatek: jpeg: refactor jpeg dst buffer layout kyrie.wu
2025-01-09 13:35 ` [V1,08/12] media: mediatek: jpeg: fix stop streaming flow for multi-core kyrie.wu
2025-01-09 13:35 ` [V1,09/12] media: mediatek: jpeg: refactor multi-core clk suspend and resume setting kyrie.wu
2025-01-09 13:35 ` [V1,10/12] media: mediatek: jpeg: fix decoding buffer number setting timing issue kyrie.wu
2025-01-09 13:35 ` [V1,11/12] media: mediatek: jpeg: refactor decoding resolution change operation kyrie.wu
2025-01-09 13:35 ` kyrie.wu [this message]
2025-01-09 14:06 ` [V1,00/12] Enable jpeg enc & dec multi-hardwares for MT8196 Nicolas Dufresne
2025-01-10 5:31 ` Kyrie Wu (吴晗)
2025-04-07 6:27 ` Kyrie Wu (吴晗)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109133513.20151-13-kyrie.wu@mediatek.com \
--to=kyrie.wu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bin.liu@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=kyrie.wu@mediatek.corp-partner.google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox