From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Kyrie Wu (吴晗)" <Kyrie.Wu@mediatek.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
"tzungbi@chromium.org" <tzungbi@chromium.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"kyrie.wu@mediatek.corp-partner.google.com"
<kyrie.wu@mediatek.corp-partner.google.com>,
"Bin Liu (刘彬)" <bin.liu@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible
Date: Mon, 7 Apr 2025 09:19:10 +0200 [thread overview]
Message-ID: <1dacb76d-c227-4373-93db-4255c3f9ac83@kernel.org> (raw)
In-Reply-To: <df3f73ea3ed1f8394beb31a9c9997679eb36f386.camel@mediatek.com>
On 07/04/2025 09:13, Kyrie Wu (吴晗) wrote:
> On Thu, 2025-01-09 at 14:54 +0100, Krzysztof Kozlowski wrote:
...
>>>
>>> properties:
>>> compatible:
>>> - const: mediatek,mt8195-jpgdec
>>> + enum:
>>> + - mediatek,mt8195-jpgdec
>>> + - mediatek,mt8196-jpgdec
>>
>> Devices look compatible, so express it with fallback.
>>
>> Best regards,
>> Krzysztof
>
> Dear Krzysztof,
>
> The MT8195 and MT8196 are both multi-hardware chips, I renamed the file
> to treat it as a common file, if I don't do that it will need to
> recreate a file with similar contents. Is this acceptable?
No, do not create own rules. I do not see how this is related to my
comment at all.
You responded three months after my review, so entire context including
actual mails in my inbox are gone.
If you disagree with feedback, respond in timely manner. I feel
discussing something after three months like wasting my time.
> If the above description is acceptable, I will apply your request in
> the next version.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-07 7:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 13:35 [V1,00/12] Enable jpeg enc & dec multi-hardwares for MT8196 kyrie.wu
2025-01-09 13:35 ` [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible kyrie.wu
2025-01-09 13:54 ` Krzysztof Kozlowski
2025-04-07 7:13 ` Kyrie Wu (吴晗)
2025-04-07 7:19 ` Krzysztof Kozlowski [this message]
2025-04-07 9:39 ` Kyrie Wu (吴晗)
2025-01-09 13:35 ` [V1,02/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgenc compatible kyrie.wu
2025-01-09 13:35 ` [V1,03/12] media: mediatek: jpeg: add jpeg compatible kyrie.wu
2025-01-10 9:46 ` AngeloGioacchino Del Regno
2025-04-07 7:15 ` Kyrie Wu (吴晗)
2025-01-09 13:35 ` [V1,04/12] media: mediatek: jpeg: add jpeg smmu sid setting kyrie.wu
2025-01-10 9:39 ` AngeloGioacchino Del Regno
2025-04-07 7:21 ` Kyrie Wu (吴晗)
2025-01-09 13:35 ` [V1,05/12] media: mediatek: jpeg: fix jpeg hw count setting kyrie.wu
2025-01-10 9:45 ` AngeloGioacchino Del Regno
2025-04-07 7:23 ` Kyrie Wu (吴晗)
2025-01-09 13:35 ` [V1,06/12] media: mediatek: jpeg: refactor jpeg buffer payload setting kyrie.wu
2025-01-09 13:35 ` [V1,07/12] media: mediatek: jpeg: refactor jpeg dst buffer layout kyrie.wu
2025-01-09 13:35 ` [V1,08/12] media: mediatek: jpeg: fix stop streaming flow for multi-core kyrie.wu
2025-01-09 13:35 ` [V1,09/12] media: mediatek: jpeg: refactor multi-core clk suspend and resume setting kyrie.wu
2025-01-09 13:35 ` [V1,10/12] media: mediatek: jpeg: fix decoding buffer number setting timing issue kyrie.wu
2025-01-09 13:35 ` [V1,11/12] media: mediatek: jpeg: refactor decoding resolution change operation kyrie.wu
2025-01-09 13:35 ` [V1,12/12] media: mediatek: jpeg: fix remove buffer operation for multi-core kyrie.wu
2025-01-09 14:06 ` [V1,00/12] Enable jpeg enc & dec multi-hardwares for MT8196 Nicolas Dufresne
2025-01-10 5:31 ` Kyrie Wu (吴晗)
2025-04-07 6:27 ` Kyrie Wu (吴晗)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dacb76d-c227-4373-93db-4255c3f9ac83@kernel.org \
--to=krzk@kernel.org \
--cc=Kyrie.Wu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bin.liu@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=kyrie.wu@mediatek.corp-partner.google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox