* [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/*
@ 2016-04-03 14:39 Masahiro Yamada
2016-04-03 14:39 ` [RFC PATCH 7/9] ARM: mediatek: move mach-mediatek/ to platforms/mediatek/ Masahiro Yamada
2016-04-03 18:25 ` [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/* Russell King - ARM Linux
0 siblings, 2 replies; 6+ messages in thread
From: Masahiro Yamada @ 2016-04-03 14:39 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Rob Herring, Russell King, Arnd Bergmann, Marcus Cooper,
Emilio López, Russell King,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Masahiro Yamada, Mark Brown,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Olof Johansson,
Maxime Ripard, Matthias Brugger
We have growing number of mach-* directories in arch/arm, and I guess
it might be a good time to discuss moving them into a sub-directory.
I moved 8 mach directories of modern SoCs (uniphier, zynq, sunxi,
socfpga, rockchip, mediatek, highbank, bcm) as examples.
Of course, I do not mean we can take this series soon (that's why it
is an RFC), but I just want to know experts' insight about the idea
and possible problems (at least a bunch of conflicts if applied).
Masahiro Yamada (9):
ARM: prepare arch/arm/platforms for immigration
ARM: uniphier: move mach-uniphier/ to platforms/uniphier/
ARM: zynq: move mach-zynq/ to platforms/zynq/
ARM: sunxi: move mach-sunxi/ to platforms/sunxi/
ARM: socfpga: move mach-socfpga/ to platforms/socfpga/
ARM: rockchip: move mach-rockchip/ to platforms/rockchip/
ARM: mediatek: move mach-mediatek/ to platforms/mediatek/
ARM: highbank: move mach-highbank/ to platforms/highbank/
ARM: bcm: move mach-bcm/ to platforms/bcm/
arch/arm/Kconfig | 18 ++----------------
arch/arm/Makefile | 9 +--------
arch/arm/platforms/Kconfig | 10 ++++++++++
arch/arm/platforms/Makefile | 10 ++++++++++
arch/arm/{mach-bcm => platforms/bcm}/Kconfig | 0
arch/arm/{mach-bcm => platforms/bcm}/Makefile | 0
arch/arm/{mach-bcm => platforms/bcm}/bcm63xx.c | 0
arch/arm/{mach-bcm => platforms/bcm}/bcm63xx_pmb.c | 0
arch/arm/{mach-bcm => platforms/bcm}/bcm63xx_smp.c | 0
arch/arm/{mach-bcm => platforms/bcm}/bcm63xx_smp.h | 0
arch/arm/{mach-bcm => platforms/bcm}/bcm_5301x.c | 0
arch/arm/{mach-bcm => platforms/bcm}/bcm_cygnus.c | 0
arch/arm/{mach-bcm => platforms/bcm}/bcm_kona_smc.c | 0
arch/arm/{mach-bcm => platforms/bcm}/bcm_kona_smc.h | 0
arch/arm/{mach-bcm => platforms/bcm}/bcm_nsp.c | 0
arch/arm/{mach-bcm => platforms/bcm}/board_bcm21664.c | 0
arch/arm/{mach-bcm => platforms/bcm}/board_bcm281xx.c | 0
arch/arm/{mach-bcm => platforms/bcm}/board_bcm2835.c | 0
arch/arm/{mach-bcm => platforms/bcm}/brcmstb.c | 0
arch/arm/{mach-bcm => platforms/bcm}/kona_l2_cache.c | 0
arch/arm/{mach-bcm => platforms/bcm}/kona_l2_cache.h | 0
arch/arm/{mach-bcm => platforms/bcm}/platsmp-brcmstb.c | 0
arch/arm/{mach-bcm => platforms/bcm}/platsmp.c | 0
arch/arm/{mach-highbank => platforms/highbank}/Kconfig | 0
.../arm/{mach-highbank => platforms/highbank}/Makefile | 0
arch/arm/{mach-highbank => platforms/highbank}/core.h | 0
.../{mach-highbank => platforms/highbank}/highbank.c | 0
arch/arm/{mach-highbank => platforms/highbank}/pm.c | 0
arch/arm/{mach-highbank => platforms/highbank}/smc.S | 0
.../{mach-highbank => platforms/highbank}/sysregs.h | 0
.../arm/{mach-highbank => platforms/highbank}/system.c | 0
arch/arm/{mach-mediatek => platforms/mediatek}/Kconfig | 0
.../arm/{mach-mediatek => platforms/mediatek}/Makefile | 0
.../{mach-mediatek => platforms/mediatek}/mediatek.c | 0
.../{mach-mediatek => platforms/mediatek}/platsmp.c | 0
arch/arm/{mach-rockchip => platforms/rockchip}/Kconfig | 0
.../arm/{mach-rockchip => platforms/rockchip}/Makefile | 0
arch/arm/{mach-rockchip => platforms/rockchip}/core.h | 0
.../{mach-rockchip => platforms/rockchip}/headsmp.S | 0
.../{mach-rockchip => platforms/rockchip}/platsmp.c | 0
arch/arm/{mach-rockchip => platforms/rockchip}/pm.c | 0
arch/arm/{mach-rockchip => platforms/rockchip}/pm.h | 0
.../{mach-rockchip => platforms/rockchip}/rockchip.c | 0
arch/arm/{mach-rockchip => platforms/rockchip}/sleep.S | 0
arch/arm/{mach-socfpga => platforms/socfpga}/Kconfig | 0
arch/arm/{mach-socfpga => platforms/socfpga}/Makefile | 0
arch/arm/{mach-socfpga => platforms/socfpga}/core.h | 0
arch/arm/{mach-socfpga => platforms/socfpga}/headsmp.S | 0
.../arm/{mach-socfpga => platforms/socfpga}/l2_cache.c | 0
arch/arm/{mach-socfpga => platforms/socfpga}/ocram.c | 0
arch/arm/{mach-socfpga => platforms/socfpga}/platsmp.c | 0
arch/arm/{mach-socfpga => platforms/socfpga}/pm.c | 0
.../{mach-socfpga => platforms/socfpga}/self-refresh.S | 0
arch/arm/{mach-socfpga => platforms/socfpga}/socfpga.c | 0
arch/arm/{mach-sunxi => platforms/sunxi}/Kconfig | 0
arch/arm/{mach-sunxi => platforms/sunxi}/Makefile | 0
arch/arm/{mach-sunxi => platforms/sunxi}/platsmp.c | 0
arch/arm/{mach-sunxi => platforms/sunxi}/sunxi.c | 0
arch/arm/{mach-uniphier => platforms/uniphier}/Kconfig | 0
.../arm/{mach-uniphier => platforms/uniphier}/Makefile | 0
.../{mach-uniphier => platforms/uniphier}/headsmp.S | 0
.../{mach-uniphier => platforms/uniphier}/platsmp.c | 0
.../{mach-uniphier => platforms/uniphier}/uniphier.c | 0
arch/arm/{mach-zynq => platforms/zynq}/Kconfig | 0
arch/arm/{mach-zynq => platforms/zynq}/Makefile | 0
arch/arm/{mach-zynq => platforms/zynq}/common.c | 0
arch/arm/{mach-zynq => platforms/zynq}/common.h | 0
arch/arm/{mach-zynq => platforms/zynq}/headsmp.S | 0
arch/arm/{mach-zynq => platforms/zynq}/platsmp.c | 0
arch/arm/{mach-zynq => platforms/zynq}/pm.c | 0
arch/arm/{mach-zynq => platforms/zynq}/slcr.c | 0
71 files changed, 23 insertions(+), 24 deletions(-)
create mode 100644 arch/arm/platforms/Kconfig
create mode 100644 arch/arm/platforms/Makefile
rename arch/arm/{mach-bcm => platforms/bcm}/Kconfig (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/Makefile (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/bcm63xx.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/bcm63xx_pmb.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/bcm63xx_smp.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/bcm63xx_smp.h (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/bcm_5301x.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/bcm_cygnus.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/bcm_kona_smc.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/bcm_kona_smc.h (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/bcm_nsp.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/board_bcm21664.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/board_bcm281xx.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/board_bcm2835.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/brcmstb.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/kona_l2_cache.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/kona_l2_cache.h (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/platsmp-brcmstb.c (100%)
rename arch/arm/{mach-bcm => platforms/bcm}/platsmp.c (100%)
rename arch/arm/{mach-highbank => platforms/highbank}/Kconfig (100%)
rename arch/arm/{mach-highbank => platforms/highbank}/Makefile (100%)
rename arch/arm/{mach-highbank => platforms/highbank}/core.h (100%)
rename arch/arm/{mach-highbank => platforms/highbank}/highbank.c (100%)
rename arch/arm/{mach-highbank => platforms/highbank}/pm.c (100%)
rename arch/arm/{mach-highbank => platforms/highbank}/smc.S (100%)
rename arch/arm/{mach-highbank => platforms/highbank}/sysregs.h (100%)
rename arch/arm/{mach-highbank => platforms/highbank}/system.c (100%)
rename arch/arm/{mach-mediatek => platforms/mediatek}/Kconfig (100%)
rename arch/arm/{mach-mediatek => platforms/mediatek}/Makefile (100%)
rename arch/arm/{mach-mediatek => platforms/mediatek}/mediatek.c (100%)
rename arch/arm/{mach-mediatek => platforms/mediatek}/platsmp.c (100%)
rename arch/arm/{mach-rockchip => platforms/rockchip}/Kconfig (100%)
rename arch/arm/{mach-rockchip => platforms/rockchip}/Makefile (100%)
rename arch/arm/{mach-rockchip => platforms/rockchip}/core.h (100%)
rename arch/arm/{mach-rockchip => platforms/rockchip}/headsmp.S (100%)
rename arch/arm/{mach-rockchip => platforms/rockchip}/platsmp.c (100%)
rename arch/arm/{mach-rockchip => platforms/rockchip}/pm.c (100%)
rename arch/arm/{mach-rockchip => platforms/rockchip}/pm.h (100%)
rename arch/arm/{mach-rockchip => platforms/rockchip}/rockchip.c (100%)
rename arch/arm/{mach-rockchip => platforms/rockchip}/sleep.S (100%)
rename arch/arm/{mach-socfpga => platforms/socfpga}/Kconfig (100%)
rename arch/arm/{mach-socfpga => platforms/socfpga}/Makefile (100%)
rename arch/arm/{mach-socfpga => platforms/socfpga}/core.h (100%)
rename arch/arm/{mach-socfpga => platforms/socfpga}/headsmp.S (100%)
rename arch/arm/{mach-socfpga => platforms/socfpga}/l2_cache.c (100%)
rename arch/arm/{mach-socfpga => platforms/socfpga}/ocram.c (100%)
rename arch/arm/{mach-socfpga => platforms/socfpga}/platsmp.c (100%)
rename arch/arm/{mach-socfpga => platforms/socfpga}/pm.c (100%)
rename arch/arm/{mach-socfpga => platforms/socfpga}/self-refresh.S (100%)
rename arch/arm/{mach-socfpga => platforms/socfpga}/socfpga.c (100%)
rename arch/arm/{mach-sunxi => platforms/sunxi}/Kconfig (100%)
rename arch/arm/{mach-sunxi => platforms/sunxi}/Makefile (100%)
rename arch/arm/{mach-sunxi => platforms/sunxi}/platsmp.c (100%)
rename arch/arm/{mach-sunxi => platforms/sunxi}/sunxi.c (100%)
rename arch/arm/{mach-uniphier => platforms/uniphier}/Kconfig (100%)
rename arch/arm/{mach-uniphier => platforms/uniphier}/Makefile (100%)
rename arch/arm/{mach-uniphier => platforms/uniphier}/headsmp.S (100%)
rename arch/arm/{mach-uniphier => platforms/uniphier}/platsmp.c (100%)
rename arch/arm/{mach-uniphier => platforms/uniphier}/uniphier.c (100%)
rename arch/arm/{mach-zynq => platforms/zynq}/Kconfig (100%)
rename arch/arm/{mach-zynq => platforms/zynq}/Makefile (100%)
rename arch/arm/{mach-zynq => platforms/zynq}/common.c (100%)
rename arch/arm/{mach-zynq => platforms/zynq}/common.h (100%)
rename arch/arm/{mach-zynq => platforms/zynq}/headsmp.S (100%)
rename arch/arm/{mach-zynq => platforms/zynq}/platsmp.c (100%)
rename arch/arm/{mach-zynq => platforms/zynq}/pm.c (100%)
rename arch/arm/{mach-zynq => platforms/zynq}/slcr.c (100%)
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH 7/9] ARM: mediatek: move mach-mediatek/ to platforms/mediatek/
2016-04-03 14:39 [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/* Masahiro Yamada
@ 2016-04-03 14:39 ` Masahiro Yamada
2016-04-03 18:25 ` [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/* Russell King - ARM Linux
1 sibling, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2016-04-03 14:39 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Russell King, Arnd Bergmann, Marcus Cooper, Emilio López,
Russell King, linux-kernel, Masahiro Yamada, Mark Brown,
linux-mediatek, Olof Johansson, Maxime Ripard, Matthias Brugger
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/Kconfig | 2 --
arch/arm/Makefile | 1 -
arch/arm/platforms/Kconfig | 1 +
arch/arm/platforms/Makefile | 1 +
arch/arm/{mach-mediatek => platforms/mediatek}/Kconfig | 0
arch/arm/{mach-mediatek => platforms/mediatek}/Makefile | 0
arch/arm/{mach-mediatek => platforms/mediatek}/mediatek.c | 0
arch/arm/{mach-mediatek => platforms/mediatek}/platsmp.c | 0
8 files changed, 2 insertions(+), 3 deletions(-)
rename arch/arm/{mach-mediatek => platforms/mediatek}/Kconfig (100%)
rename arch/arm/{mach-mediatek => platforms/mediatek}/Makefile (100%)
rename arch/arm/{mach-mediatek => platforms/mediatek}/mediatek.c (100%)
rename arch/arm/{mach-mediatek => platforms/mediatek}/platsmp.c (100%)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 51e2663..38d9cb7 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -781,8 +781,6 @@ source "arch/arm/mach-mv78xx0/Kconfig"
source "arch/arm/mach-imx/Kconfig"
-source "arch/arm/mach-mediatek/Kconfig"
-
source "arch/arm/mach-mxs/Kconfig"
source "arch/arm/mach-netx/Kconfig"
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 923be10..17ccd3f 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -187,7 +187,6 @@ machine-$(CONFIG_ARCH_MOXART) += moxart
machine-$(CONFIG_ARCH_MV78XX0) += mv78xx0
machine-$(CONFIG_ARCH_MVEBU) += mvebu
machine-$(CONFIG_ARCH_MXC) += imx
-machine-$(CONFIG_ARCH_MEDIATEK) += mediatek
machine-$(CONFIG_ARCH_MXS) += mxs
machine-$(CONFIG_ARCH_NETX) += netx
machine-$(CONFIG_ARCH_NOMADIK) += nomadik
diff --git a/arch/arm/platforms/Kconfig b/arch/arm/platforms/Kconfig
index ce6ed8a..069b6a2 100644
--- a/arch/arm/platforms/Kconfig
+++ b/arch/arm/platforms/Kconfig
@@ -1,5 +1,6 @@
# This is sorted alphabetically by directory pathname.
+source "arch/arm/platforms/mediatek/Kconfig"
source "arch/arm/platforms/rockchip/Kconfig"
source "arch/arm/platforms/socfpga/Kconfig"
source "arch/arm/platforms/sunxi/Kconfig"
diff --git a/arch/arm/platforms/Makefile b/arch/arm/platforms/Makefile
index bf88c66e..3b0a4e7 100644
--- a/arch/arm/platforms/Makefile
+++ b/arch/arm/platforms/Makefile
@@ -1,5 +1,6 @@
# This list sorted alphanumerically by CONFIG_* macro name.
+obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/
obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/
obj-$(CONFIG_ARCH_SOCFPGA) += socfpga/
obj-$(CONFIG_ARCH_SUNXI) += sunxi/
diff --git a/arch/arm/mach-mediatek/Kconfig b/arch/arm/platforms/mediatek/Kconfig
similarity index 100%
rename from arch/arm/mach-mediatek/Kconfig
rename to arch/arm/platforms/mediatek/Kconfig
diff --git a/arch/arm/mach-mediatek/Makefile b/arch/arm/platforms/mediatek/Makefile
similarity index 100%
rename from arch/arm/mach-mediatek/Makefile
rename to arch/arm/platforms/mediatek/Makefile
diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/platforms/mediatek/mediatek.c
similarity index 100%
rename from arch/arm/mach-mediatek/mediatek.c
rename to arch/arm/platforms/mediatek/mediatek.c
diff --git a/arch/arm/mach-mediatek/platsmp.c b/arch/arm/platforms/mediatek/platsmp.c
similarity index 100%
rename from arch/arm/mach-mediatek/platsmp.c
rename to arch/arm/platforms/mediatek/platsmp.c
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/*
2016-04-03 14:39 [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/* Masahiro Yamada
2016-04-03 14:39 ` [RFC PATCH 7/9] ARM: mediatek: move mach-mediatek/ to platforms/mediatek/ Masahiro Yamada
@ 2016-04-03 18:25 ` Russell King - ARM Linux
2016-04-04 1:53 ` Florian Fainelli
` (2 more replies)
1 sibling, 3 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2016-04-03 18:25 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-arm-kernel, Arnd Bergmann, Olof Johansson, Rob Herring,
Emilio López, Mark Brown, linux-kernel, linux-mediatek,
Matthias Brugger, Marcus Cooper, Maxime Ripard
On Sun, Apr 03, 2016 at 11:39:18PM +0900, Masahiro Yamada wrote:
> We have growing number of mach-* directories in arch/arm, and I guess
> it might be a good time to discuss moving them into a sub-directory.
What does it buy us? Let me summarise the actual change:
- Move up to 71 arch/arm/mach-* directories to arch/arm/platforms/*,
which just means another level of directory structure. We still
end up with up to 71 directories in arch/arm/platforms/
- The ability to use obj-y rather than machine-y, where both already
work in the same way.
Is there anything I missed?
If that is all, then I really do not like this change - it's seems
to be churn for no benefit, and that's something we really should be
minimising. Linus Torvalds has historically moaned at the ARM
architecture for stuff like this.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/*
2016-04-03 18:25 ` [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/* Russell King - ARM Linux
@ 2016-04-04 1:53 ` Florian Fainelli
2016-04-04 1:57 ` Masahiro Yamada
2016-04-04 19:02 ` Olof Johansson
2 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2016-04-04 1:53 UTC (permalink / raw)
To: Russell King - ARM Linux, Masahiro Yamada
Cc: linux-arm-kernel, Arnd Bergmann, Olof Johansson, Rob Herring,
Emilio López, Mark Brown, linux-kernel, linux-mediatek,
Matthias Brugger, Marcus Cooper, Maxime Ripard
On April 3, 2016 11:25:43 AM PDT, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
>On Sun, Apr 03, 2016 at 11:39:18PM +0900, Masahiro Yamada wrote:
>> We have growing number of mach-* directories in arch/arm, and I guess
>> it might be a good time to discuss moving them into a sub-directory.
>
>What does it buy us? Let me summarise the actual change:
>
>- Move up to 71 arch/arm/mach-* directories to arch/arm/platforms/*,
> which just means another level of directory structure. We still
> end up with up to 71 directories in arch/arm/platforms/
>
>- The ability to use obj-y rather than machine-y, where both already
> work in the same way.
>
>Is there anything I missed?
>
>If that is all, then I really do not like this change - it's seems
>to be churn for no benefit, and that's something we really should be
>minimising. Linus Torvalds has historically moaned at the ARM
>architecture for stuff like this.
Agreed, it also makes the life of people back porting, or just submitting changes harder (even though git does an excellent job at tracking renames). Nack from me.
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/*
2016-04-03 18:25 ` [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/* Russell King - ARM Linux
2016-04-04 1:53 ` Florian Fainelli
@ 2016-04-04 1:57 ` Masahiro Yamada
2016-04-04 19:02 ` Olof Johansson
2 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2016-04-04 1:57 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: linux-arm-kernel, Arnd Bergmann, Olof Johansson, Rob Herring,
Emilio López, Mark Brown, Linux Kernel Mailing List,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Marcus Cooper, Maxime Ripard
Hi Russell,
2016-04-04 3:25 GMT+09:00 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Sun, Apr 03, 2016 at 11:39:18PM +0900, Masahiro Yamada wrote:
>> We have growing number of mach-* directories in arch/arm, and I guess
>> it might be a good time to discuss moving them into a sub-directory.
>
> What does it buy us? Let me summarise the actual change:
>
> - Move up to 71 arch/arm/mach-* directories to arch/arm/platforms/*,
> which just means another level of directory structure. We still
> end up with up to 71 directories in arch/arm/platforms/
True, but we can separate non-SoC directories (kernel/, mm/, configs/, etc.)
from mach- directories, at least.
> - The ability to use obj-y rather than machine-y, where both already
> work in the same way.
Yes, but Kbuild standard Makefiles might provide more flexible
directory structures
to tidy up similar SoC families from the same vendor.
For example,
arch/arm/platforms/samsung/
arch/arm/platforms/samsung/exynos/
arch/arm/platforms/samsung/s3c64xx/
instead of
arch/arm/plat-samsung/
arch/arm/mach-exynos/
arch/arm/mach-s3c64xx/
I am missing something, though.
> Is there anything I missed?
>
> If that is all, then I really do not like this change - it's seems
> to be churn for no benefit, and that's something we really should be
> minimising. Linus Torvalds has historically moaned at the ARM
> architecture for stuff like this.
OK.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/*
2016-04-03 18:25 ` [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/* Russell King - ARM Linux
2016-04-04 1:53 ` Florian Fainelli
2016-04-04 1:57 ` Masahiro Yamada
@ 2016-04-04 19:02 ` Olof Johansson
2 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2016-04-04 19:02 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Masahiro Yamada, linux-arm-kernel@lists.infradead.org,
Arnd Bergmann, Rob Herring, Emilio López, Mark Brown,
linux-kernel@vger.kernel.org, moderated list:ARM/Mediatek SoC...,
Matthias Brugger, Marcus Cooper, Maxime Ripard
On Sun, Apr 3, 2016 at 11:25 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Sun, Apr 03, 2016 at 11:39:18PM +0900, Masahiro Yamada wrote:
>> We have growing number of mach-* directories in arch/arm, and I guess
>> it might be a good time to discuss moving them into a sub-directory.
>
> What does it buy us? Let me summarise the actual change:
>
> - Move up to 71 arch/arm/mach-* directories to arch/arm/platforms/*,
> which just means another level of directory structure. We still
> end up with up to 71 directories in arch/arm/platforms/
>
> - The ability to use obj-y rather than machine-y, where both already
> work in the same way.
>
> Is there anything I missed?
>
> If that is all, then I really do not like this change - it's seems
> to be churn for no benefit, and that's something we really should be
> minimising. Linus Torvalds has historically moaned at the ARM
> architecture for stuff like this.
Been behind on email so chiming in late, but I agree -- this change
isn't bringing enough benefit to justify the churn.
Overall we're looking at adding as little new code into arch/arm/mach*
as possible, so making it easier to structure up and build more
elaborate contents in their corner of it seems a bit like a step
backwards.
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-04 19:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-03 14:39 [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/* Masahiro Yamada
2016-04-03 14:39 ` [RFC PATCH 7/9] ARM: mediatek: move mach-mediatek/ to platforms/mediatek/ Masahiro Yamada
2016-04-03 18:25 ` [RFC PATCH 0/9] ARM: start to move arch/arm/mach-* to arch/arm/platforms/* Russell King - ARM Linux
2016-04-04 1:53 ` Florian Fainelli
2016-04-04 1:57 ` Masahiro Yamada
2016-04-04 19:02 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox