* [PATCH 01/15] dt-bindings: arm64: mediatek: Add MT8395 Radxa NIO 12L board compatible
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 17:06 ` Conor Dooley
2024-01-12 9:46 ` [PATCH 02/15] arm64: dts: mediatek: Introduce the MT8395 Radxa NIO 12L board AngeloGioacchino Del Regno
` (13 subsequent siblings)
14 siblings, 1 reply; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Add a board compatible for the Radxa NIO 12L, based on the MediaTek
MT8395 SoC.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 5d49c7af50e5..cc37c88d8d4a 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -345,6 +345,7 @@ properties:
- items:
- enum:
- mediatek,mt8395-evk
+ - radxa,nio-12l
- const: mediatek,mt8395
- const: mediatek,mt8195
- items:
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH 01/15] dt-bindings: arm64: mediatek: Add MT8395 Radxa NIO 12L board compatible
2024-01-12 9:46 ` [PATCH 01/15] dt-bindings: arm64: mediatek: Add MT8395 Radxa NIO 12L board compatible AngeloGioacchino Del Regno
@ 2024-01-12 17:06 ` Conor Dooley
0 siblings, 0 replies; 22+ messages in thread
From: Conor Dooley @ 2024-01-12 17:06 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: linux-mediatek, robh+dt, krzysztof.kozlowski+dt, conor+dt,
matthias.bgg, wenst, hsinyi, nfraprado, macpaul.lin, sean.wang,
devicetree, linux-kernel, linux-arm-kernel, kernel
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
On Fri, Jan 12, 2024 at 10:46:18AM +0100, AngeloGioacchino Del Regno wrote:
> Add a board compatible for the Radxa NIO 12L, based on the MediaTek
> MT8395 SoC.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 5d49c7af50e5..cc37c88d8d4a 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -345,6 +345,7 @@ properties:
> - items:
> - enum:
> - mediatek,mt8395-evk
> + - radxa,nio-12l
> - const: mediatek,mt8395
> - const: mediatek,mt8195
> - items:
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 02/15] arm64: dts: mediatek: Introduce the MT8395 Radxa NIO 12L board
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 01/15] dt-bindings: arm64: mediatek: Add MT8395 Radxa NIO 12L board compatible AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 03/15] arm64: dts: mediatek: radxa-nio-12l: Enable I2C 2/4/6 busses AngeloGioacchino Del Regno
` (12 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Add an initial devicetree for the Radxa NIO 12L SBC, powered by the
MT8395 Genio 1200 SoC.
This achieves a console boot.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/Makefile | 1 +
.../dts/mediatek/mt8395-radxa-nio-12l.dts | 102 ++++++++++++++++++
2 files changed, 103 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index 679dddb09966..cf997191d046 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -76,4 +76,5 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-demo.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-evb.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-genio-1200-evk.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-radxa-nio-12l.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
new file mode 100644
index 000000000000..2c4d6805b668
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -0,0 +1,102 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (C) 2023 MediaTek Inc.
+ * Copyright (C) 2024 Collabora Ltd.
+ * Author: Ben Lok <ben.lok@mediatek.com>
+ * Macpaul Lin <macpaul.lin@mediatek.com>
+ * AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
+ */
+
+#include "mt8195.dtsi"
+#include <dt-bindings/pinctrl/mt8195-pinfunc.h>
+
+/ {
+ model = "Radxa NIO 12L";
+ chassis-type = "embedded";
+ compatible = "radxa,nio-12l", "mediatek,mt8395", "mediatek,mt8195";
+
+ aliases {
+ serial0 = &uart0;
+ };
+
+ chosen {
+ stdout-path = "serial0:921600n8";
+ };
+
+ firmware {
+ optee {
+ compatible = "linaro,optee-tz";
+ method = "smc";
+ };
+ };
+
+ memory@40000000 {
+ device_type = "memory";
+ reg = <0 0x40000000 0x1 0x0>;
+ };
+
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ /*
+ * 12 MiB reserved for OP-TEE (BL32)
+ * +-----------------------+ 0x43e0_0000
+ * | SHMEM 2MiB |
+ * +-----------------------+ 0x43c0_0000
+ * | | TA_RAM 8MiB |
+ * + TZDRAM +--------------+ 0x4340_0000
+ * | | TEE_RAM 2MiB |
+ * +-----------------------+ 0x4320_0000
+ */
+ optee_reserved: optee@43200000 {
+ reg = <0 0x43200000 0 0xc00000>;
+ no-map;
+ };
+
+ scp_mem: memory@50000000 {
+ compatible = "shared-dma-pool";
+ reg = <0 0x50000000 0 0x2900000>;
+ no-map;
+ };
+
+ vpu_mem: memory@53000000 {
+ compatible = "shared-dma-pool";
+ reg = <0 0x53000000 0 0x1400000>; /* 20 MB */
+ };
+
+ /* 2 MiB reserved for ARM Trusted Firmware (BL31) */
+ bl31_secmon_mem: memory@54600000 {
+ reg = <0 0x54600000 0x0 0x200000>;
+ no-map;
+ };
+
+ afe_mem: memory@60000000 {
+ compatible = "shared-dma-pool";
+ reg = <0 0x60000000 0 0x1100000>;
+ no-map;
+ };
+
+ apu_mem: memory@62000000 {
+ compatible = "shared-dma-pool";
+ reg = <0 0x62000000 0 0x1400000>; /* 20 MB */
+ };
+ };
+};
+
+&pio {
+ uart0_pins: uart0-pins {
+ pins-bus {
+ pinmux = <PINMUX_GPIO98__FUNC_UTXD0>,
+ <PINMUX_GPIO99__FUNC_URXD0>;
+ };
+ };
+};
+
+&uart0 {
+ /* Exposed at 40 pin connector */
+ pinctrl-0 = <&uart0_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+};
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 03/15] arm64: dts: mediatek: radxa-nio-12l: Enable I2C 2/4/6 busses
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 01/15] dt-bindings: arm64: mediatek: Add MT8395 Radxa NIO 12L board compatible AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 02/15] arm64: dts: mediatek: Introduce the MT8395 Radxa NIO 12L board AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 04/15] arm64: dts: mediatek: radxa-nio-12l: Add external MT6360 PMIC on I2C6 AngeloGioacchino Del Regno
` (11 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Properly configure and enable the three i2c controllers that have
devices attached and/or have pins exposed on the board connectors.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../dts/mediatek/mt8395-radxa-nio-12l.dts | 54 +++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 2c4d6805b668..79358e1a3e60 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -85,7 +85,61 @@ apu_mem: memory@62000000 {
};
};
+&i2c2 {
+ clock-frequency = <400000>;
+ pinctrl-0 = <&i2c2_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+
+ /* iTE IT5205FN Type-C 3:2 Alt. mode passive MUX at 0x48 */
+};
+
+&i2c4 {
+ clock-frequency = <400000>;
+ pinctrl-0 = <&i2c4_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+
+ /* I2C4 exposed at 39-pins MIPI-LCD connector */
+};
+
+&i2c6 {
+ clock-frequency = <400000>;
+ pinctrl-0 = <&i2c6_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+
+ /* MT6360 PMIC at 0x34 */
+};
+
&pio {
+ i2c2_pins: i2c2-pins {
+ pins-bus {
+ pinmux = <PINMUX_GPIO12__FUNC_SDA2>,
+ <PINMUX_GPIO13__FUNC_SCL2>;
+ bias-pull-up = <MTK_PULL_SET_RSEL_111>;
+ drive-strength = <6>;
+ drive-strength-microamp = <1000>;
+ };
+ };
+
+ i2c4_pins: i2c4-pins {
+ pins-bus {
+ pinmux = <PINMUX_GPIO16__FUNC_SDA4>,
+ <PINMUX_GPIO17__FUNC_SCL4>;
+ bias-pull-up = <MTK_PULL_SET_RSEL_111>;
+ drive-strength-microamp = <1000>;
+ };
+ };
+
+ i2c6_pins: i2c6-pins {
+ pins {
+ pinmux = <PINMUX_GPIO25__FUNC_SDA6>,
+ <PINMUX_GPIO26__FUNC_SCL6>;
+ bias-pull-up = <MTK_PULL_SET_RSEL_111>;
+ };
+ };
+
uart0_pins: uart0-pins {
pins-bus {
pinmux = <PINMUX_GPIO98__FUNC_UTXD0>,
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 04/15] arm64: dts: mediatek: radxa-nio-12l: Add external MT6360 PMIC on I2C6
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (2 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 03/15] arm64: dts: mediatek: radxa-nio-12l: Enable I2C 2/4/6 busses AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-16 8:16 ` Krzysztof Kozlowski
2024-01-12 9:46 ` [PATCH 05/15] arm64: dts: mediatek: radxa-nio-12l: Configure board regulators AngeloGioacchino Del Regno
` (10 subsequent siblings)
14 siblings, 1 reply; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
In preparation for adding the power tree for this board, add a node for
the MT6360 PMIC, connected to I2C6.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../dts/mediatek/mt8395-radxa-nio-12l.dts | 20 ++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 79358e1a3e60..281847b8f022 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -8,6 +8,7 @@
*/
#include "mt8195.dtsi"
+#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/pinctrl/mt8195-pinfunc.h>
/ {
@@ -109,7 +110,15 @@ &i2c6 {
pinctrl-names = "default";
status = "okay";
- /* MT6360 PMIC at 0x34 */
+ mt6360: pmic@34 {
+ compatible = "mediatek,mt6360";
+ reg = <0x34>;
+ interrupts-extended = <&pio 101 IRQ_TYPE_EDGE_FALLING>;
+ interrupt-names = "IRQB";
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ pinctrl-0 = <&mt6360_pins>;
+ };
};
&pio {
@@ -140,6 +149,15 @@ pins {
};
};
+ mt6360_pins: mt6360-pins {
+ pins-irq {
+ pinmux = <PINMUX_GPIO100__FUNC_GPIO100>,
+ <PINMUX_GPIO101__FUNC_GPIO101>;
+ input-enable;
+ bias-pull-up;
+ };
+ };
+
uart0_pins: uart0-pins {
pins-bus {
pinmux = <PINMUX_GPIO98__FUNC_UTXD0>,
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH 04/15] arm64: dts: mediatek: radxa-nio-12l: Add external MT6360 PMIC on I2C6
2024-01-12 9:46 ` [PATCH 04/15] arm64: dts: mediatek: radxa-nio-12l: Add external MT6360 PMIC on I2C6 AngeloGioacchino Del Regno
@ 2024-01-16 8:16 ` Krzysztof Kozlowski
2024-01-22 7:28 ` Matthias Brugger
0 siblings, 1 reply; 22+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-16 8:16 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg, wenst,
hsinyi, nfraprado, macpaul.lin, sean.wang, devicetree,
linux-kernel, linux-arm-kernel, kernel
On 12/01/2024 10:46, AngeloGioacchino Del Regno wrote:
> In preparation for adding the power tree for this board, add a node for
> the MT6360 PMIC, connected to I2C6.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Why do you add new device in pieces? Logical change is "new device", not
"half of device". If the patch is too big, sure, split it into two
chunks, but not 15!
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 04/15] arm64: dts: mediatek: radxa-nio-12l: Add external MT6360 PMIC on I2C6
2024-01-16 8:16 ` Krzysztof Kozlowski
@ 2024-01-22 7:28 ` Matthias Brugger
0 siblings, 0 replies; 22+ messages in thread
From: Matthias Brugger @ 2024-01-22 7:28 UTC (permalink / raw)
To: Krzysztof Kozlowski, AngeloGioacchino Del Regno, linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, wenst, hsinyi,
nfraprado, macpaul.lin, sean.wang, devicetree, linux-kernel,
linux-arm-kernel, kernel
On 16/01/2024 09:16, Krzysztof Kozlowski wrote:
> On 12/01/2024 10:46, AngeloGioacchino Del Regno wrote:
>> In preparation for adding the power tree for this board, add a node for
>> the MT6360 PMIC, connected to I2C6.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> Why do you add new device in pieces? Logical change is "new device", not
Well we have done that in the past, so somehow for MediaTek tree that's ok to
do. From my personal maintainer position it's easier to review 15 small patches
then one or two huge ones.
Regards,
Matthias
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 05/15] arm64: dts: mediatek: radxa-nio-12l: Configure board regulators
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (3 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 04/15] arm64: dts: mediatek: radxa-nio-12l: Add external MT6360 PMIC on I2C6 AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 06/15] arm64: dts: mediatek: radxa-nio-12l: Add Ethernet controller and Xceiver AngeloGioacchino Del Regno
` (9 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Add the entire power tree, which also includes all of the voltage
regulators found on all of the PMICs and fixed vregs on this board.
While at it, also add the two MT6315 PMICs over SPMI, providing
CPU-Big and GPU power rails.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../dts/mediatek/mt8395-radxa-nio-12l.dts | 228 ++++++++++++++++++
1 file changed, 228 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 281847b8f022..0daf27410311 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -8,8 +8,12 @@
*/
#include "mt8195.dtsi"
+#include "mt6359.dtsi"
+#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/pinctrl/mt8195-pinfunc.h>
+#include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
+#include <dt-bindings/spmi/spmi.h>
/ {
model = "Radxa NIO 12L";
@@ -36,6 +40,48 @@ memory@40000000 {
reg = <0 0x40000000 0x1 0x0>;
};
+ wifi_vreg: regulator-wifi-3v3-en {
+ compatible = "regulator-fixed";
+ regulator-name = "wifi_3v3_en";
+ regulator-always-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ enable-active-high;
+ gpio = <&pio 67 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&wifi_vreg_pins>;
+ vin-supply = <&vsys>;
+ };
+
+ /* system wide switching 5.0V power rail */
+ vsys: regulator-vsys {
+ compatible = "regulator-fixed";
+ regulator-name = "vsys";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ vin-supply = <&vcc5v0_vsys>;
+ };
+
+ vsys_buck: regulator-vsys-buck {
+ compatible = "regulator-fixed";
+ regulator-name = "vsys_buck";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ vin-supply = <&vcc5v0_vsys>;
+ };
+
+ /* Rail from power-only "TYPE C DC" port */
+ vcc5v0_vsys: regulator-vcc5v0-sys {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc5v0_sys";
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
reserved-memory {
#address-cells = <2>;
#size-cells = <2>;
@@ -118,9 +164,138 @@ mt6360: pmic@34 {
interrupt-controller;
#interrupt-cells = <1>;
pinctrl-0 = <&mt6360_pins>;
+
+ regulator {
+ compatible = "mediatek,mt6360-regulator";
+ LDO_VIN1-supply = <&vsys_buck>;
+ LDO_VIN3-supply = <&mt6360_buck2>;
+
+ mt6360_buck1: buck1 {
+ regulator-name = "emi_vdd2";
+ regulator-min-microvolt = <300000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-allowed-modes = <MT6360_OPMODE_NORMAL
+ MT6360_OPMODE_LP
+ MT6360_OPMODE_ULP>;
+ regulator-always-on;
+ };
+
+ mt6360_buck2: buck2 {
+ regulator-name = "emi_vddq";
+ regulator-min-microvolt = <300000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-allowed-modes = <MT6360_OPMODE_NORMAL
+ MT6360_OPMODE_LP
+ MT6360_OPMODE_ULP>;
+ regulator-always-on;
+ };
+
+ mt6360_ldo1: ldo1 {
+ regulator-name = "ext_lcd_3v3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-allowed-modes = <MT6360_OPMODE_NORMAL
+ MT6360_OPMODE_LP>;
+ regulator-always-on;
+ };
+
+ mt6360_ldo2: ldo2 {
+ regulator-name = "panel1_p1v8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-allowed-modes = <MT6360_OPMODE_NORMAL
+ MT6360_OPMODE_LP>;
+ };
+
+ mt6360_ldo3: ldo3 {
+ regulator-name = "vmc_pmu";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <3600000>;
+ regulator-allowed-modes = <MT6360_OPMODE_NORMAL
+ MT6360_OPMODE_LP>;
+ };
+
+ mt6360_ldo5: ldo5 {
+ regulator-name = "vmch_pmu";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-allowed-modes = <MT6360_OPMODE_NORMAL
+ MT6360_OPMODE_LP>;
+ regulator-always-on;
+ };
+
+ mt6360_ldo6: ldo6 {
+ regulator-name = "mt6360_ldo6"; /* Test point */
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <2100000>;
+ regulator-allowed-modes = <MT6360_OPMODE_NORMAL
+ MT6360_OPMODE_LP>;
+ };
+
+ mt6360_ldo7: ldo7 {
+ regulator-name = "emi_vmddr_en";
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <2100000>;
+ regulator-allowed-modes = <MT6360_OPMODE_NORMAL
+ MT6360_OPMODE_LP>;
+ regulator-always-on;
+ };
+ };
};
};
+&mt6359_vaud18_ldo_reg {
+ regulator-always-on;
+};
+
+&mt6359_vbbck_ldo_reg {
+ regulator-always-on;
+};
+
+/* For USB Hub */
+&mt6359_vcamio_ldo_reg {
+ regulator-always-on;
+};
+
+&mt6359_vcn33_2_bt_ldo_reg {
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+};
+
+&mt6359_vcore_buck_reg {
+ regulator-always-on;
+};
+
+&mt6359_vgpu11_buck_reg {
+ regulator-always-on;
+};
+
+&mt6359_vproc1_buck_reg {
+ regulator-always-on;
+};
+
+&mt6359_vproc2_buck_reg {
+ regulator-always-on;
+};
+
+&mt6359_vpu_buck_reg {
+ regulator-always-on;
+};
+
+&mt6359_vrf12_ldo_reg {
+ regulator-always-on;
+};
+
+&mt6359_vsram_md_ldo_reg {
+ regulator-always-on;
+};
+
+/* for GPU SRAM */
+&mt6359_vsram_others_ldo_reg {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <750000>;
+};
+
&pio {
i2c2_pins: i2c2-pins {
pins-bus {
@@ -164,6 +339,59 @@ pins-bus {
<PINMUX_GPIO99__FUNC_URXD0>;
};
};
+
+ wifi_vreg_pins: wifi-vreg-pins {
+ pins-wifi-pmu-en {
+ pinmux = <PINMUX_GPIO65__FUNC_GPIO65>;
+ output-high;
+ };
+
+ pins-wifi-vreg-en {
+ pinmux = <PINMUX_GPIO67__FUNC_GPIO67>;
+ };
+ };
+};
+
+&pmic {
+ interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>;
+};
+
+&spmi {
+ #address-cells = <2>;
+ #size-cells = <0>;
+
+ mt6315_6: pmic@6 {
+ compatible = "mediatek,mt6315-regulator";
+ reg = <0x6 SPMI_USID>;
+
+ regulators {
+ mt6315_6_vbuck1: vbuck1 {
+ regulator-compatible = "vbuck1";
+ regulator-name = "Vbcpu";
+ regulator-min-microvolt = <300000>;
+ regulator-max-microvolt = <1193750>;
+ regulator-enable-ramp-delay = <256>;
+ regulator-allowed-modes = <0 1 2>;
+ regulator-always-on;
+ };
+ };
+ };
+
+ mt6315_7: pmic@7 {
+ compatible = "mediatek,mt6315-regulator";
+ reg = <0x7 SPMI_USID>;
+
+ regulators {
+ mt6315_7_vbuck1: vbuck1 {
+ regulator-compatible = "vbuck1";
+ regulator-name = "Vgpu";
+ regulator-min-microvolt = <300000>;
+ regulator-max-microvolt = <1193750>;
+ regulator-enable-ramp-delay = <256>;
+ regulator-allowed-modes = <0 1 2>;
+ };
+ };
+ };
};
&uart0 {
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 06/15] arm64: dts: mediatek: radxa-nio-12l: Add Ethernet controller and Xceiver
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (4 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 05/15] arm64: dts: mediatek: radxa-nio-12l: Configure board regulators AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 07/15] arm64: dts: mediatek: radxa-nio-12l: Add MT6360 battery charger AngeloGioacchino Del Regno
` (8 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Configure and enable the ethernet controller found on the MT8395 SoC,
along with the MDIO PHY/Transceiver (RTL8211FD) found on this board,
enabling 10/100/1000M Ethernet connectivity.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../dts/mediatek/mt8395-radxa-nio-12l.dts | 92 +++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 0daf27410311..221d7062d5ef 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -21,6 +21,7 @@ / {
compatible = "radxa,nio-12l", "mediatek,mt8395", "mediatek,mt8195";
aliases {
+ ethernet0 = ð
serial0 = &uart0;
};
@@ -132,6 +133,26 @@ apu_mem: memory@62000000 {
};
};
+ð {
+ phy-mode = "rgmii-rxid";
+ phy-handle = <&rgmii_phy>;
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <ð_default_pins>;
+ pinctrl-1 = <ð_sleep_pins>;
+ mediatek,tx-delay-ps = <2030>;
+ mediatek,mac-wol;
+ snps,reset-gpio = <&pio 93 GPIO_ACTIVE_HIGH>;
+ snps,reset-delays-us = <0 20000 100000>;
+ status = "okay";
+
+ mdio {
+ rgmii_phy: ethernet-phy@1 {
+ compatible = "ethernet-phy-id001c.c916";
+ reg = <0x1>;
+ };
+ };
+};
+
&i2c2 {
clock-frequency = <400000>;
pinctrl-0 = <&i2c2_pins>;
@@ -297,6 +318,77 @@ &mt6359_vsram_others_ldo_reg {
};
&pio {
+ eth_default_pins: eth-default-pins {
+ pins-cc {
+ pinmux = <PINMUX_GPIO85__FUNC_GBE_TXC>,
+ <PINMUX_GPIO86__FUNC_GBE_RXC>,
+ <PINMUX_GPIO87__FUNC_GBE_RXDV>,
+ <PINMUX_GPIO88__FUNC_GBE_TXEN>;
+ drive-strength = <8>;
+ };
+
+ pins-mdio {
+ pinmux = <PINMUX_GPIO89__FUNC_GBE_MDC>,
+ <PINMUX_GPIO90__FUNC_GBE_MDIO>;
+ input-enable;
+ };
+
+ pins-power {
+ pinmux = <PINMUX_GPIO91__FUNC_GPIO91>,
+ <PINMUX_GPIO92__FUNC_GPIO92>;
+ output-high;
+ };
+
+ pins-rst {
+ pinmux = <PINMUX_GPIO93__FUNC_GPIO93>;
+ };
+
+ pins-rxd {
+ pinmux = <PINMUX_GPIO81__FUNC_GBE_RXD3>,
+ <PINMUX_GPIO82__FUNC_GBE_RXD2>,
+ <PINMUX_GPIO83__FUNC_GBE_RXD1>,
+ <PINMUX_GPIO84__FUNC_GBE_RXD0>;
+ };
+
+ pins-txd {
+ pinmux = <PINMUX_GPIO77__FUNC_GBE_TXD3>,
+ <PINMUX_GPIO78__FUNC_GBE_TXD2>,
+ <PINMUX_GPIO79__FUNC_GBE_TXD1>,
+ <PINMUX_GPIO80__FUNC_GBE_TXD0>;
+ drive-strength = <8>;
+ };
+ };
+
+ eth_sleep_pins: eth-sleep-pins {
+ pins-cc {
+ pinmux = <PINMUX_GPIO85__FUNC_GPIO85>,
+ <PINMUX_GPIO86__FUNC_GPIO86>,
+ <PINMUX_GPIO87__FUNC_GPIO87>,
+ <PINMUX_GPIO88__FUNC_GPIO88>;
+ };
+
+ pins-mdio {
+ pinmux = <PINMUX_GPIO89__FUNC_GPIO89>,
+ <PINMUX_GPIO90__FUNC_GPIO90>;
+ bias-disable;
+ input-disable;
+ };
+
+ pins-rxd {
+ pinmux = <PINMUX_GPIO81__FUNC_GPIO81>,
+ <PINMUX_GPIO82__FUNC_GPIO82>,
+ <PINMUX_GPIO83__FUNC_GPIO83>,
+ <PINMUX_GPIO84__FUNC_GPIO84>;
+ };
+
+ pins-txd {
+ pinmux = <PINMUX_GPIO77__FUNC_GPIO77>,
+ <PINMUX_GPIO78__FUNC_GPIO78>,
+ <PINMUX_GPIO79__FUNC_GPIO79>,
+ <PINMUX_GPIO80__FUNC_GPIO80>;
+ };
+ };
+
i2c2_pins: i2c2-pins {
pins-bus {
pinmux = <PINMUX_GPIO12__FUNC_SDA2>,
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 07/15] arm64: dts: mediatek: radxa-nio-12l: Add MT6360 battery charger
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (5 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 06/15] arm64: dts: mediatek: radxa-nio-12l: Add Ethernet controller and Xceiver AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-16 8:17 ` Krzysztof Kozlowski
2024-01-12 9:46 ` [PATCH 08/15] arm64: dts: mediatek: radxa-nio-12l: Add support for eMMC and MicroSD AngeloGioacchino Del Regno
` (7 subsequent siblings)
14 siblings, 1 reply; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Enable the MT6360 PMIC's battery charger which also provides a regulator
the USB VBUS.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 221d7062d5ef..3b8880db49ff 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -186,6 +186,17 @@ mt6360: pmic@34 {
#interrupt-cells = <1>;
pinctrl-0 = <&mt6360_pins>;
+ charger {
+ compatible = "mediatek,mt6360-chg";
+ richtek,vinovp-microvolt = <14500000>;
+
+ otg_vbus_regulator: usb-otg-vbus-regulator {
+ regulator-name = "usb-otg-vbus";
+ regulator-min-microvolt = <4425000>;
+ regulator-max-microvolt = <5825000>;
+ };
+ };
+
regulator {
compatible = "mediatek,mt6360-regulator";
LDO_VIN1-supply = <&vsys_buck>;
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH 07/15] arm64: dts: mediatek: radxa-nio-12l: Add MT6360 battery charger
2024-01-12 9:46 ` [PATCH 07/15] arm64: dts: mediatek: radxa-nio-12l: Add MT6360 battery charger AngeloGioacchino Del Regno
@ 2024-01-16 8:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 22+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-16 8:17 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg, wenst,
hsinyi, nfraprado, macpaul.lin, sean.wang, devicetree,
linux-kernel, linux-arm-kernel, kernel
On 12/01/2024 10:46, AngeloGioacchino Del Regno wrote:
> Enable the MT6360 PMIC's battery charger which also provides a regulator
> the USB VBUS.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Don't add new nodes one by one. This obfuscates entire picture.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 08/15] arm64: dts: mediatek: radxa-nio-12l: Add support for eMMC and MicroSD
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (6 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 07/15] arm64: dts: mediatek: radxa-nio-12l: Add MT6360 battery charger AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor AngeloGioacchino Del Regno
` (6 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Enable and properly configure the MMC0/1 controllers to add support
for the eMMC and MicroSD slot (respectively) found on this board.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../dts/mediatek/mt8395-radxa-nio-12l.dts | 128 ++++++++++++++++++
1 file changed, 128 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 3b8880db49ff..8492cf52413f 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -276,6 +276,44 @@ mt6360_ldo7: ldo7 {
};
};
+/* MMC0 Controller: eMMC (HS400). Power lines are shared with UFS! */
+&mmc0 {
+ pinctrl-names = "default", "state_uhs";
+ pinctrl-0 = <&mmc0_default_pins>;
+ pinctrl-1 = <&mmc0_uhs_pins>;
+ bus-width = <8>;
+ max-frequency = <200000000>;
+ hs400-ds-delay = <0x14c11>;
+ cap-mmc-highspeed;
+ cap-mmc-hw-reset;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
+ no-sdio;
+ no-sd;
+ non-removable;
+ vmmc-supply = <&mt6359_vemc_1_ldo_reg>;
+ vqmmc-supply = <&mt6359_vufs_ldo_reg>;
+ status = "okay";
+};
+
+/* MMC1 Controller: MicroSD card slot */
+&mmc1 {
+ pinctrl-names = "default", "state_uhs";
+ pinctrl-0 = <&mmc1_default_pins>, <&mmc1_pins_detect>;
+ pinctrl-1 = <&mmc1_default_pins>;
+ bus-width = <4>;
+ max-frequency = <200000000>;
+ cap-sd-highspeed;
+ cd-gpios = <&pio 129 GPIO_ACTIVE_LOW>;
+ no-mmc;
+ no-sdio;
+ sd-uhs-sdr50;
+ sd-uhs-sdr104;
+ vmmc-supply = <&mt6360_ldo5>;
+ vqmmc-supply = <&mt6360_ldo3>;
+ status = "okay";
+};
+
&mt6359_vaud18_ldo_reg {
regulator-always-on;
};
@@ -427,6 +465,96 @@ pins {
};
};
+ mmc0_default_pins: mmc0-default-pins {
+ pins-clk {
+ pinmux = <PINMUX_GPIO122__FUNC_MSDC0_CLK>;
+ bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
+ drive-strength = <6>;
+ };
+
+ pins-cmd-dat {
+ pinmux = <PINMUX_GPIO126__FUNC_MSDC0_DAT0>,
+ <PINMUX_GPIO125__FUNC_MSDC0_DAT1>,
+ <PINMUX_GPIO124__FUNC_MSDC0_DAT2>,
+ <PINMUX_GPIO123__FUNC_MSDC0_DAT3>,
+ <PINMUX_GPIO119__FUNC_MSDC0_DAT4>,
+ <PINMUX_GPIO118__FUNC_MSDC0_DAT5>,
+ <PINMUX_GPIO117__FUNC_MSDC0_DAT6>,
+ <PINMUX_GPIO116__FUNC_MSDC0_DAT7>,
+ <PINMUX_GPIO121__FUNC_MSDC0_CMD>;
+ bias-pull-up = <MTK_PUPD_SET_R1R0_01>;
+ drive-strength = <6>;
+ input-enable;
+ };
+
+ pins-rst {
+ pinmux = <PINMUX_GPIO120__FUNC_MSDC0_RSTB>;
+ bias-pull-up = <MTK_PUPD_SET_R1R0_01>;
+ drive-strength = <6>;
+ };
+ };
+
+ mmc0_uhs_pins: mmc0-uhs-pins {
+ pins-clk {
+ pinmux = <PINMUX_GPIO122__FUNC_MSDC0_CLK>;
+ bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
+ drive-strength = <8>;
+ };
+
+ pins-cmd-dat {
+ pinmux = <PINMUX_GPIO126__FUNC_MSDC0_DAT0>,
+ <PINMUX_GPIO125__FUNC_MSDC0_DAT1>,
+ <PINMUX_GPIO124__FUNC_MSDC0_DAT2>,
+ <PINMUX_GPIO123__FUNC_MSDC0_DAT3>,
+ <PINMUX_GPIO119__FUNC_MSDC0_DAT4>,
+ <PINMUX_GPIO118__FUNC_MSDC0_DAT5>,
+ <PINMUX_GPIO117__FUNC_MSDC0_DAT6>,
+ <PINMUX_GPIO116__FUNC_MSDC0_DAT7>,
+ <PINMUX_GPIO121__FUNC_MSDC0_CMD>;
+ bias-pull-up = <MTK_PUPD_SET_R1R0_01>;
+ drive-strength = <8>;
+ input-enable;
+ };
+
+ pins-ds {
+ pinmux = <PINMUX_GPIO127__FUNC_MSDC0_DSL>;
+ bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
+ drive-strength = <8>;
+ };
+
+ pins-rst {
+ pinmux = <PINMUX_GPIO120__FUNC_MSDC0_RSTB>;
+ bias-pull-up = <MTK_PUPD_SET_R1R0_01>;
+ drive-strength = <8>;
+ };
+ };
+
+ mmc1_default_pins: mmc1-default-pins {
+ pins-clk {
+ pinmux = <PINMUX_GPIO111__FUNC_MSDC1_CLK>;
+ bias-pull-down = <MTK_PUPD_SET_R1R0_10>;
+ drive-strength = <8>;
+ };
+
+ pins-cmd-dat {
+ pinmux = <PINMUX_GPIO110__FUNC_MSDC1_CMD>,
+ <PINMUX_GPIO112__FUNC_MSDC1_DAT0>,
+ <PINMUX_GPIO113__FUNC_MSDC1_DAT1>,
+ <PINMUX_GPIO114__FUNC_MSDC1_DAT2>,
+ <PINMUX_GPIO115__FUNC_MSDC1_DAT3>;
+ bias-pull-up = <MTK_PUPD_SET_R1R0_01>;
+ drive-strength = <8>;
+ input-enable;
+ };
+ };
+
+ mmc1_pins_detect: mmc1-detect-pins {
+ pins-insert {
+ pinmux = <PINMUX_GPIO129__FUNC_GPIO129>;
+ bias-pull-up;
+ };
+ };
+
mt6360_pins: mt6360-pins {
pins-irq {
pinmux = <PINMUX_GPIO100__FUNC_GPIO100>,
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (7 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 08/15] arm64: dts: mediatek: radxa-nio-12l: Add support for eMMC and MicroSD AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-16 8:18 ` Krzysztof Kozlowski
2024-01-12 9:46 ` [PATCH 10/15] arm64: dts: mediatek: radxa-nio-12l: Enable PCI-Express 0 for USB HUB AngeloGioacchino Del Regno
` (5 subsequent siblings)
14 siblings, 1 reply; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
The SCP is used by the SoC for various tasks, including initializing
hardware video encoding/decoding hardware and managing other remote
processors. Enable this node and assign its own DMA pool to it.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 8492cf52413f..5a9e33013209 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -587,6 +587,11 @@ &pmic {
interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>;
};
+&scp {
+ memory-region = <&scp_mem>;
+ status = "okay";
+};
+
&spmi {
#address-cells = <2>;
#size-cells = <0>;
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor
2024-01-12 9:46 ` [PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor AngeloGioacchino Del Regno
@ 2024-01-16 8:18 ` Krzysztof Kozlowski
2024-01-16 8:41 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 22+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-16 8:18 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg, wenst,
hsinyi, nfraprado, macpaul.lin, sean.wang, devicetree,
linux-kernel, linux-arm-kernel, kernel
On 12/01/2024 10:46, AngeloGioacchino Del Regno wrote:
> The SCP is used by the SoC for various tasks, including initializing
> hardware video encoding/decoding hardware and managing other remote
> processors. Enable this node and assign its own DMA pool to it.
>
Please provide reason why this cannot be included in initial submission
and must be split into separate patch. I really do not understand except
some patch count stats.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor
2024-01-16 8:18 ` Krzysztof Kozlowski
@ 2024-01-16 8:41 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-16 8:41 UTC (permalink / raw)
To: Krzysztof Kozlowski, linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg, wenst,
hsinyi, nfraprado, macpaul.lin, sean.wang, devicetree,
linux-kernel, linux-arm-kernel, kernel
Il 16/01/24 09:18, Krzysztof Kozlowski ha scritto:
> On 12/01/2024 10:46, AngeloGioacchino Del Regno wrote:
>> The SCP is used by the SoC for various tasks, including initializing
>> hardware video encoding/decoding hardware and managing other remote
>> processors. Enable this node and assign its own DMA pool to it.
>>
>
> Please provide reason why this cannot be included in initial submission
> and must be split into separate patch. I really do not understand except
> some patch count stats.
>
This was done to describe both the reasons why each node was enabled at
which point and the actual workflow for the bringup with each commit.
I don't care about the stats.
I will squash some of those patches for v2, anyway.
Regards,
Angelo
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 10/15] arm64: dts: mediatek: radxa-nio-12l: Enable PCI-Express 0 for USB HUB
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (8 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 11/15] arm64: dts: mediatek: radxa-nio-12l: Enable the USB XHCI controllers AngeloGioacchino Del Regno
` (4 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Enable the PCIe0 controller, providing part of the USB connectivity
found on this board through a USB HUB connected over PCI-Express.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 5a9e33013209..dbde2c7b3c64 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -564,6 +564,15 @@ pins-irq {
};
};
+ pcie0_default_pins: pcie0-default-pins {
+ pins-bus {
+ pinmux = <PINMUX_GPIO19__FUNC_WAKEN>,
+ <PINMUX_GPIO20__FUNC_PERSTN>,
+ <PINMUX_GPIO21__FUNC_CLKREQN>;
+ bias-pull-up;
+ };
+ };
+
uart0_pins: uart0-pins {
pins-bus {
pinmux = <PINMUX_GPIO98__FUNC_UTXD0>,
@@ -583,6 +592,12 @@ pins-wifi-vreg-en {
};
};
+&pcie0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pcie0_default_pins>;
+ status = "okay";
+};
+
&pmic {
interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 11/15] arm64: dts: mediatek: radxa-nio-12l: Enable the USB XHCI controllers
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (9 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 10/15] arm64: dts: mediatek: radxa-nio-12l: Enable PCI-Express 0 for USB HUB AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 12/15] arm64: dts: mediatek: radxa-nio-12l: Enable PCI-Express 1 for WiFi AngeloGioacchino Del Regno
` (3 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Enable the three XHCI controllers found in the MT8395 SoC, used for
both MT7921's Bluetooth (using USB 2.0) and external USB3 connectivity.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../dts/mediatek/mt8395-radxa-nio-12l.dts | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index dbde2c7b3c64..eafce9cb2598 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -651,3 +651,23 @@ &uart0 {
pinctrl-names = "default";
status = "okay";
};
+
+&xhci0 {
+ vusb33-supply = <&mt6359_vusb_ldo_reg>;
+ vbus-supply = <&otg_vbus_regulator>;
+ status = "okay";
+};
+
+&xhci1 {
+ /* MT7921's USB Bluetooth has issues with USB2 LPM */
+ usb2-lpm-disable;
+ vusb33-supply = <&mt6359_vusb_ldo_reg>;
+ vbus-supply = <&vsys>;
+ status = "okay";
+};
+
+&xhci2 {
+ vusb33-supply = <&mt6359_vusb_ldo_reg>;
+ vbus-supply = <&vsys>;
+ status = "okay";
+};
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 12/15] arm64: dts: mediatek: radxa-nio-12l: Enable PCI-Express 1 for WiFi
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (10 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 11/15] arm64: dts: mediatek: radxa-nio-12l: Enable the USB XHCI controllers AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 13/15] arm64: dts: mediatek: radxa-nio-12l: Enable SPI1/2 for 40pin header AngeloGioacchino Del Regno
` (2 subsequent siblings)
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
This board has a MT7921E combo chip connected through USB for Bluetooth
and PCI-Express for WiFi.
Add the PCIe1 controller to enable WiFi connectivity.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index eafce9cb2598..be2094b8fe3c 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -573,6 +573,15 @@ pins-bus {
};
};
+ pcie1_default_pins: pcie1-default-pins {
+ pins-bus {
+ pinmux = <PINMUX_GPIO0__FUNC_PERSTN_1>,
+ <PINMUX_GPIO1__FUNC_CLKREQN_1>,
+ <PINMUX_GPIO2__FUNC_WAKEN_1>;
+ bias-disable;
+ };
+ };
+
uart0_pins: uart0-pins {
pins-bus {
pinmux = <PINMUX_GPIO98__FUNC_UTXD0>,
@@ -598,6 +607,12 @@ &pcie0 {
status = "okay";
};
+&pcie1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pcie1_default_pins>;
+ status = "okay";
+};
+
&pmic {
interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 13/15] arm64: dts: mediatek: radxa-nio-12l: Enable SPI1/2 for 40pin header
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (11 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 12/15] arm64: dts: mediatek: radxa-nio-12l: Enable PCI-Express 1 for WiFi AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 14/15] arm64: dts: mediatek: radxa-nio-12l: Enable UART1 " AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 15/15] arm64: dts: mediatek: radxa-nio-12l: Enable Panfrost for Mali GPU AngeloGioacchino Del Regno
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Enable the SPI1 and SPI2 controllers as pins for those are exposed on
the 40pins header.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../dts/mediatek/mt8395-radxa-nio-12l.dts | 40 +++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index be2094b8fe3c..191c059f5c97 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -582,6 +582,26 @@ pins-bus {
};
};
+ spi1_pins: spi1-default-pins {
+ pins-bus {
+ pinmux = <PINMUX_GPIO136__FUNC_SPIM1_CSB>,
+ <PINMUX_GPIO137__FUNC_SPIM1_CLK>,
+ <PINMUX_GPIO138__FUNC_SPIM1_MO>,
+ <PINMUX_GPIO139__FUNC_SPIM1_MI>;
+ bias-disable;
+ };
+ };
+
+ spi2_pins: spi2-default-pins {
+ pins-bus {
+ pinmux = <PINMUX_GPIO140__FUNC_SPIM2_CSB>,
+ <PINMUX_GPIO141__FUNC_SPIM2_CLK>,
+ <PINMUX_GPIO142__FUNC_SPIM2_MO>,
+ <PINMUX_GPIO143__FUNC_SPIM2_MI>;
+ bias-disable;
+ };
+ };
+
uart0_pins: uart0-pins {
pins-bus {
pinmux = <PINMUX_GPIO98__FUNC_UTXD0>,
@@ -622,6 +642,26 @@ &scp {
status = "okay";
};
+&spi1 {
+ /* Exposed at 40 pin connector */
+ pinctrl-0 = <&spi1_pins>;
+ pinctrl-names = "default";
+ mediatek,pad-select = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+};
+
+&spi2 {
+ /* Exposed at 40 pin connector */
+ pinctrl-0 = <&spi2_pins>;
+ pinctrl-names = "default";
+ mediatek,pad-select = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+};
+
&spmi {
#address-cells = <2>;
#size-cells = <0>;
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 14/15] arm64: dts: mediatek: radxa-nio-12l: Enable UART1 for 40pin header
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (12 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 13/15] arm64: dts: mediatek: radxa-nio-12l: Enable SPI1/2 for 40pin header AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 15/15] arm64: dts: mediatek: radxa-nio-12l: Enable Panfrost for Mali GPU AngeloGioacchino Del Regno
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Enable the secondary UART port, exposed on the 40pins header.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 191c059f5c97..b0d66fa139b5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -609,6 +609,13 @@ pins-bus {
};
};
+ uart1_pins: uart1-pins {
+ pins-bus {
+ pinmux = <PINMUX_GPIO102__FUNC_UTXD1>,
+ <PINMUX_GPIO103__FUNC_URXD1>;
+ };
+ };
+
wifi_vreg_pins: wifi-vreg-pins {
pins-wifi-pmu-en {
pinmux = <PINMUX_GPIO65__FUNC_GPIO65>;
@@ -707,6 +714,13 @@ &uart0 {
status = "okay";
};
+&uart1 {
+ /* Exposed at 40 pin connector */
+ pinctrl-0 = <&uart1_pins>;
+ pinctrl-names = "default";
+ status = "okay";
+};
+
&xhci0 {
vusb33-supply = <&mt6359_vusb_ldo_reg>;
vbus-supply = <&otg_vbus_regulator>;
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH 15/15] arm64: dts: mediatek: radxa-nio-12l: Enable Panfrost for Mali GPU
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
` (13 preceding siblings ...)
2024-01-12 9:46 ` [PATCH 14/15] arm64: dts: mediatek: radxa-nio-12l: Enable UART1 " AngeloGioacchino Del Regno
@ 2024-01-12 9:46 ` AngeloGioacchino Del Regno
14 siblings, 0 replies; 22+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-12 9:46 UTC (permalink / raw)
To: linux-mediatek
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, hsinyi, nfraprado, macpaul.lin,
sean.wang, devicetree, linux-kernel, linux-arm-kernel, kernel
Enable the GPU node and add the required power supply to get GPU
support through Panfrost.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index b0d66fa139b5..1e97d2bf7b8b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -153,6 +153,11 @@ rgmii_phy: ethernet-phy@1 {
};
};
+&gpu {
+ mali-supply = <&mt6315_7_vbuck1>;
+ status = "okay";
+};
+
&i2c2 {
clock-frequency = <400000>;
pinctrl-0 = <&i2c2_pins>;
--
2.43.0
^ permalink raw reply related [flat|nested] 22+ messages in thread