Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 02/14] irqchip: fix typos in comments
@ 2026-09-07  6:53 Hemanth Selam
  2026-09-13 18:31 ` Radu Rendec
  0 siblings, 1 reply; 2+ messages in thread
From: Hemanth Selam @ 2026-09-07  6:53 UTC (permalink / raw)
  To: Thomas Gleixner, Radu Rendec, Matthias Brugger,
	AngeloGioacchino Del Regno, Paul Walmsley, Samuel Holland,
	Linus Walleij
  Cc: linux-kernel, linux-arm-kernel, linux-mediatek, linux-riscv

Fix typos in comments, reported by scripts/checkpatch.pl using the
misspelling list in scripts/spelling.txt.  Only touches comments, no code
changes.

Assisted-by: Cursor:claude-opus-5
Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
---
 drivers/irqchip/irq-mtk-cirq.c    | 2 +-
 drivers/irqchip/irq-sifive-plic.c | 2 +-
 drivers/irqchip/irq-vic.c         | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-mtk-cirq.c b/drivers/irqchip/irq-mtk-cirq.c
index 914d1d639fe3..d30c34ce0f56 100644
--- a/drivers/irqchip/irq-mtk-cirq.c
+++ b/drivers/irqchip/irq-mtk-cirq.c
@@ -247,7 +247,7 @@ static int mtk_cirq_suspend(void *data)
 		writel_relaxed(mask, reg);
 	}
 
-	/* set edge_only mode, record edge-triggerd interrupts */
+	/* set edge_only mode, record edge-triggered interrupts */
 	/* enable cirq */
 	reg = mtk_cirq_reg(cirq_data, CIRQ_CONTROL);
 	value = readl_relaxed(reg);
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index 5b0dac104814..a7cddadddf40 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -452,7 +452,7 @@ static irq_hw_number_t cp100_get_hwirq(struct plic_handler *handler, void __iome
 		return 0;
 
 	/*
-	 * Interrupts delievered to hardware still become pending, but only
+	 * Interrupts delivered to hardware still become pending, but only
 	 * interrupts that are both pending and enabled can be claimed.
 	 * Clearing the enable bit for all interrupts but the first pending
 	 * one avoids a hardware bug that occurs during read from the claim
diff --git a/drivers/irqchip/irq-vic.c b/drivers/irqchip/irq-vic.c
index e38104c5064e..607e3284f700 100644
--- a/drivers/irqchip/irq-vic.c
+++ b/drivers/irqchip/irq-vic.c
@@ -478,7 +478,7 @@ static void __init __vic_init(void __iomem *base, int parent_irq, int irq_start,
 /**
  * vic_init() - initialise a vectored interrupt controller
  * @base: iomem base address
- * @irq_start: starting interrupt number, must be muliple of 32
+ * @irq_start: starting interrupt number, must be multiple of 32
  * @vic_sources: bitmask of interrupt sources to allow
  * @resume_sources: bitmask of interrupt sources to allow for resume
  */


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 02/14] irqchip: fix typos in comments
  2026-09-07  6:53 [PATCH 02/14] irqchip: fix typos in comments Hemanth Selam
@ 2026-09-13 18:31 ` Radu Rendec
  0 siblings, 0 replies; 2+ messages in thread
From: Radu Rendec @ 2026-09-13 18:31 UTC (permalink / raw)
  To: Hemanth Selam, Thomas Gleixner, Matthias Brugger,
	AngeloGioacchino Del Regno, Paul Walmsley, Samuel Holland,
	Linus Walleij
  Cc: linux-kernel, linux-arm-kernel, linux-mediatek, linux-riscv

On Mon, 2026-09-07 at 12:23 +0530, Hemanth Selam wrote:
> Fix typos in comments, reported by scripts/checkpatch.pl using the
> misspelling list in scripts/spelling.txt.  Only touches comments, no code
> changes.
> 
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
> ---
>  drivers/irqchip/irq-mtk-cirq.c    | 2 +-
>  drivers/irqchip/irq-sifive-plic.c | 2 +-
>  drivers/irqchip/irq-vic.c         | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

The changes look good, but in my opinion should be split into 3
different patches, one per driver, and grouped into a series. Not that
it matters too much in this particular case (where only comments are
touched), but it's common practice in the Linux kernel development.

There are multiple reasons. The main one is that different drivers can
be reviewed/maintained by different people, and patches to them may be
picked up via different (Git) maintainer trees. Also, some companies
selectively port patches against specific drivers to the kernel trees
they maintain.

> diff --git a/drivers/irqchip/irq-mtk-cirq.c b/drivers/irqchip/irq-mtk-cirq.c
> index 914d1d639fe3..d30c34ce0f56 100644
> --- a/drivers/irqchip/irq-mtk-cirq.c
> +++ b/drivers/irqchip/irq-mtk-cirq.c
> @@ -247,7 +247,7 @@ static int mtk_cirq_suspend(void *data)
>  		writel_relaxed(mask, reg);
>  	}
>  
> -	/* set edge_only mode, record edge-triggerd interrupts */
> +	/* set edge_only mode, record edge-triggered interrupts */
>  	/* enable cirq */
>  	reg = mtk_cirq_reg(cirq_data, CIRQ_CONTROL);
>  	value = readl_relaxed(reg);
> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
> index 5b0dac104814..a7cddadddf40 100644
> --- a/drivers/irqchip/irq-sifive-plic.c
> +++ b/drivers/irqchip/irq-sifive-plic.c
> @@ -452,7 +452,7 @@ static irq_hw_number_t cp100_get_hwirq(struct plic_handler *handler, void __iome
>  		return 0;
>  
>  	/*
> -	 * Interrupts delievered to hardware still become pending, but only
> +	 * Interrupts delivered to hardware still become pending, but only
>  	 * interrupts that are both pending and enabled can be claimed.
>  	 * Clearing the enable bit for all interrupts but the first pending
>  	 * one avoids a hardware bug that occurs during read from the claim
> diff --git a/drivers/irqchip/irq-vic.c b/drivers/irqchip/irq-vic.c
> index e38104c5064e..607e3284f700 100644
> --- a/drivers/irqchip/irq-vic.c
> +++ b/drivers/irqchip/irq-vic.c
> @@ -478,7 +478,7 @@ static void __init __vic_init(void __iomem *base, int parent_irq, int irq_start,
>  /**
>   * vic_init() - initialise a vectored interrupt controller
>   * @base: iomem base address
> - * @irq_start: starting interrupt number, must be muliple of 32
> + * @irq_start: starting interrupt number, must be multiple of 32
>   * @vic_sources: bitmask of interrupt sources to allow
>   * @resume_sources: bitmask of interrupt sources to allow for resume
>   */


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-13 18:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-07  6:53 [PATCH 02/14] irqchip: fix typos in comments Hemanth Selam
2026-09-13 18:31 ` Radu Rendec

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox