Re: [PATCH v1 06/10] ufs: host: mediatek: Enable interrupts for MCQ mode

[Bart Van Assche <bvanassche@acm.org>]

On 9/19/25 1:14 AM, Peter Wang (王信友) wrote:
> On Thu, 2025-09-18 at 11:34 -0700, Bart Van Assche wrote:
>> Additionally, the above patch description doesn't make it clear what
>> makes the MediaTek driver different from other drivers and why only
>> the
>> MediaTek driver needs this change.
> 
> This is a confidential design by MediaTek, so we are unable
> to share further details. We apologize for the inconvenience.

Having taken a closer look at this patch, the only reason I can think of
why interrupts are re-enabled from a .resume callback is a workaround
for a controller bug. Please consider adding a quirk and moving the code
that reenables interrupts into the UFSHCI core instead of exporting the
ufshcd_enable_intr() function. I'm concerned that exporting
ufshcd_enable_intr() would make the UFSHCI driver much harder to
maintain than necessary, especially if this would lead to concurrent
writes to the REG_INTERRUPT_ENABLE register.

Thanks,

Bart.