Re: [PATCH v1 01/10] ufs: host: mediatek: Fix runtime suspend error deadlock

["Peter Wang (王信友)" <peter.wang@mediatek.com>]

On Mon, 2025-09-22 at 11:27 -0700, Bart Van Assche wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> > 
> > @@ -6625,6 +6625,11 @@ static void ufshcd_err_handler(struct
> > work_struct *work)
> >          }
> >          spin_unlock_irqrestore(hba->host->host_lock, flags);
> > 
> > +       if (hba->pm_op_in_progress) {
> > +               ufshcd_link_recovery(hba);
> > +               return;
> > +       }
> > +
> >          ufshcd_err_handling_prepare(hba);
> 
> Yes, the above change is what I prefer. Please note that I haven't
> tested this change myself.
> > > > 
> > 
> > This is a limitation of MediaTek’s SoC.
> > If auto-hibernate is triggered concurrently with manual
> > hibernate, it may cause errors. Therefore, we disable
> > auto-hibernate before issuing a manual hibernate command.
> 
> How about adding a comment that explains this?
> 
> Thanks,
> 
> Bart.

Hi Bart,

Okay, I will submit another patch and include this comment.

Thanks
Peter