Re: [PATCH v1 06/10] ufs: host: mediatek: Enable interrupts for MCQ mode

[Bart Van Assche <bvanassche@acm.org>]

On 9/22/25 1:41 AM, Peter Wang (王信友) wrote:
> So, maybe re-enabling MCQ IRQs the same way as legacy IRQs
> in ufshcd_make_hba_operational would be better.
> What do you think? like below patch
> 
> @@ -355,9 +355,15 @@ EXPORT_SYMBOL_GPL(ufshcd_mcq_poll_cqe_lock);
>   void ufshcd_mcq_make_queues_operational(struct ufs_hba *hba)
>   {
>          struct ufs_hw_queue *hwq;
> +       u32 intrs;
>          u16 qsize;
>          int i;
> 
> +       intrs = UFSHCD_ENABLE_MCQ_INTRS;
> +       if (hba->quirks & UFSHCD_QUIRK_MCQ_BROKEN_INTR)
> +               intrs &= ~MCQ_CQ_EVENT_STATUS;
> +       ufshcd_enable_intr(hba, intrs);
> +
>          for (i = 0; i < hba->nr_hw_queues; i++) {

Thanks, this looks better to me.

If an ufshcd_enable_intr() call is added in 
ufshcd_mcq_make_queues_operational(), shouldn't the ufshcd_enable_intr()
call be removed from ufshcd_config_mcq()?

Thanks,

Bart.