[PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189

[PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189

[Cathy Xu]

Disable new_tx/rx and modify related settings helps avoid data
transmission instability, and better compatibility for mt8189.

Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
---
 drivers/mmc/host/mtk-sd.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 302ac8529c4f..b2680cc054bd 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible mt8189_compat = {
 	.needs_top_base = true,
 	.pad_tune_reg = MSDC_PAD_TUNE0,
 	.async_fifo = true,
-	.data_tune = true,
+	.data_tune = false,
 	.busy_check = true,
 	.stop_clk_fix = true,
-	.stop_dly_sel = 1,
-	.pop_en_cnt = 2,
+	.stop_dly_sel = 3,
+	.pop_en_cnt = 8,
 	.enhance_rx = true,
 	.support_64g = true,
-	.support_new_tx = true,
-	.support_new_rx = true,
+	.support_new_tx = false,
+	.support_new_rx = false,
 	.support_spm_res_release = true,
 };
 
-- 
2.45.2

Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189

[Ulf Hansson]

On Wed, 4 Feb 2026 at 03:09, Cathy Xu <ot_cathy.xu@mediatek.com> wrote:
>
> Disable new_tx/rx and modify related settings helps avoid data
> transmission instability, and better compatibility for mt8189.
>
> Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>

Should this have a fixes/stable tag?

Kind regards
Uffe

> ---
>  drivers/mmc/host/mtk-sd.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 302ac8529c4f..b2680cc054bd 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible mt8189_compat = {
>         .needs_top_base = true,
>         .pad_tune_reg = MSDC_PAD_TUNE0,
>         .async_fifo = true,
> -       .data_tune = true,
> +       .data_tune = false,
>         .busy_check = true,
>         .stop_clk_fix = true,
> -       .stop_dly_sel = 1,
> -       .pop_en_cnt = 2,
> +       .stop_dly_sel = 3,
> +       .pop_en_cnt = 8,
>         .enhance_rx = true,
>         .support_64g = true,
> -       .support_new_tx = true,
> -       .support_new_rx = true,
> +       .support_new_tx = false,
> +       .support_new_rx = false,
>         .support_spm_res_release = true,
>  };
>
> --
> 2.45.2
>

Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189

[AngeloGioacchino Del Regno]

Il 04/02/26 03:06, Cathy Xu ha scritto:
> Disable new_tx/rx and modify related settings helps avoid data
> transmission instability, and better compatibility for mt8189.
> 
> Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>

Needs a fixes tag. Please add the relevant one and resend.

Thanks,
Angelo

> ---
>   drivers/mmc/host/mtk-sd.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 302ac8529c4f..b2680cc054bd 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible mt8189_compat = {
>   	.needs_top_base = true,
>   	.pad_tune_reg = MSDC_PAD_TUNE0,
>   	.async_fifo = true,
> -	.data_tune = true,
> +	.data_tune = false,
>   	.busy_check = true,
>   	.stop_clk_fix = true,
> -	.stop_dly_sel = 1,
> -	.pop_en_cnt = 2,
> +	.stop_dly_sel = 3,
> +	.pop_en_cnt = 8,
>   	.enhance_rx = true,
>   	.support_64g = true,
> -	.support_new_tx = true,
> -	.support_new_rx = true,
> +	.support_new_tx = false,
> +	.support_new_rx = false,
>   	.support_spm_res_release = true,
>   };
>   

Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189

[Louis-Alexis Eyraud]

Hi,

On Wed, 2026-02-04 at 10:06 +0800, Cathy Xu wrote:
> Disable new_tx/rx and modify related settings helps avoid data
> transmission instability, and better compatibility for mt8189.
> 
> Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
> ---
>  drivers/mmc/host/mtk-sd.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 302ac8529c4f..b2680cc054bd 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible
> mt8189_compat = {
>  	.needs_top_base = true,
>  	.pad_tune_reg = MSDC_PAD_TUNE0,
>  	.async_fifo = true,
> -	.data_tune = true,
> +	.data_tune = false,
>  	.busy_check = true,
>  	.stop_clk_fix = true,
> -	.stop_dly_sel = 1,
> -	.pop_en_cnt = 2,
> +	.stop_dly_sel = 3,
> +	.pop_en_cnt = 8,
>  	.enhance_rx = true,
>  	.support_64g = true,
> -	.support_new_tx = true,
> -	.support_new_rx = true,
> +	.support_new_tx = false,
> +	.support_new_rx = false,
>  	.support_spm_res_release = true,
>  };
>  
I've tested this patch on Genio 720-EVK board that uses MT8391 SoC, a
MT8189 variant.
I did not get issue with these new settings when using this board eMMC
(MSDC0) or microsd (MSDC1). I did not observe issues with previous
settings but as it does not seem to cause regressions,

Tested-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

Regards,
Louis-Alexis

Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189

[Cathy Xu (许华婷)]

On Wed, 2026-02-04 at 15:35 +0100, Ulf Hansson wrote:
> On Wed, 4 Feb 2026 at 03:09, Cathy Xu <ot_cathy.xu@mediatek.com>
> wrote:
> > 
> > Disable new_tx/rx and modify related settings helps avoid data
> > transmission instability, and better compatibility for mt8189.
> > 
> > Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
> 
> Should this have a fixes/stable tag?
> 
> Kind regards
> Uffe

  Thank you for your review, I will fix it in next version.

  Thanks,
  Cathy

> 
> > ---
> >  drivers/mmc/host/mtk-sd.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> > index 302ac8529c4f..b2680cc054bd 100644
> > --- a/drivers/mmc/host/mtk-sd.c
> > +++ b/drivers/mmc/host/mtk-sd.c
> > @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible
> > mt8189_compat = {
> >         .needs_top_base = true,
> >         .pad_tune_reg = MSDC_PAD_TUNE0,
> >         .async_fifo = true,
> > -       .data_tune = true,
> > +       .data_tune = false,
> >         .busy_check = true,
> >         .stop_clk_fix = true,
> > -       .stop_dly_sel = 1,
> > -       .pop_en_cnt = 2,
> > +       .stop_dly_sel = 3,
> > +       .pop_en_cnt = 8,
> >         .enhance_rx = true,
> >         .support_64g = true,
> > -       .support_new_tx = true,
> > -       .support_new_rx = true,
> > +       .support_new_tx = false,
> > +       .support_new_rx = false,
> >         .support_spm_res_release = true,
> >  };
> > 
> > --
> > 2.45.2
> > 

Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189

[Cathy Xu (许华婷)]

On Thu, 2026-02-05 at 12:47 +0100, AngeloGioacchino Del Regno wrote:
> Il 04/02/26 03:06, Cathy Xu ha scritto:
> > Disable new_tx/rx and modify related settings helps avoid data
> > transmission instability, and better compatibility for mt8189.
> > 
> > Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
> 
> Needs a fixes tag. Please add the relevant one and resend.
> 
> Thanks,
> Angelo

  Thank you for your review, I will add it in next.

  Thanks,
  Cathy

> 
> > ---
> >   drivers/mmc/host/mtk-sd.c | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> > index 302ac8529c4f..b2680cc054bd 100644
> > --- a/drivers/mmc/host/mtk-sd.c
> > +++ b/drivers/mmc/host/mtk-sd.c
> > @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible
> > mt8189_compat = {
> >   	.needs_top_base = true,
> >   	.pad_tune_reg = MSDC_PAD_TUNE0,
> >   	.async_fifo = true,
> > -	.data_tune = true,
> > +	.data_tune = false,
> >   	.busy_check = true,
> >   	.stop_clk_fix = true,
> > -	.stop_dly_sel = 1,
> > -	.pop_en_cnt = 2,
> > +	.stop_dly_sel = 3,
> > +	.pop_en_cnt = 8,
> >   	.enhance_rx = true,
> >   	.support_64g = true,
> > -	.support_new_tx = true,
> > -	.support_new_rx = true,
> > +	.support_new_tx = false,
> > +	.support_new_rx = false,
> >   	.support_spm_res_release = true,
> >   };
> >   
> 
>