* Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189
2026-02-04 2:06 [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189 Cathy Xu
@ 2026-02-04 14:35 ` Ulf Hansson
2026-03-09 7:31 ` Cathy Xu (许华婷)
2026-02-05 11:47 ` AngeloGioacchino Del Regno
2026-02-20 17:23 ` Louis-Alexis Eyraud
2 siblings, 1 reply; 6+ messages in thread
From: Ulf Hansson @ 2026-02-04 14:35 UTC (permalink / raw)
To: Cathy Xu
Cc: Chaotian Jing, Matthias Brugger, AngeloGioacchino Del Regno,
linux-mmc, linux-kernel, linux-arm-kernel, linux-mediatek,
Mengqi Zhang, Wenbin Mei, Andy-ld Lu, Yong Mao
On Wed, 4 Feb 2026 at 03:09, Cathy Xu <ot_cathy.xu@mediatek.com> wrote:
>
> Disable new_tx/rx and modify related settings helps avoid data
> transmission instability, and better compatibility for mt8189.
>
> Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
Should this have a fixes/stable tag?
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 302ac8529c4f..b2680cc054bd 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible mt8189_compat = {
> .needs_top_base = true,
> .pad_tune_reg = MSDC_PAD_TUNE0,
> .async_fifo = true,
> - .data_tune = true,
> + .data_tune = false,
> .busy_check = true,
> .stop_clk_fix = true,
> - .stop_dly_sel = 1,
> - .pop_en_cnt = 2,
> + .stop_dly_sel = 3,
> + .pop_en_cnt = 8,
> .enhance_rx = true,
> .support_64g = true,
> - .support_new_tx = true,
> - .support_new_rx = true,
> + .support_new_tx = false,
> + .support_new_rx = false,
> .support_spm_res_release = true,
> };
>
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189
2026-02-04 14:35 ` Ulf Hansson
@ 2026-03-09 7:31 ` Cathy Xu (许华婷)
0 siblings, 0 replies; 6+ messages in thread
From: Cathy Xu (许华婷) @ 2026-03-09 7:31 UTC (permalink / raw)
To: ulf.hansson@linaro.org
Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, Andy-ld Lu (卢东),
Wenbin Mei (梅文彬),
Mengqi Zhang (张梦琦),
Yong Mao (毛勇),
Chaotian Jing (井朝天),
linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com,
AngeloGioacchino Del Regno
On Wed, 2026-02-04 at 15:35 +0100, Ulf Hansson wrote:
> On Wed, 4 Feb 2026 at 03:09, Cathy Xu <ot_cathy.xu@mediatek.com>
> wrote:
> >
> > Disable new_tx/rx and modify related settings helps avoid data
> > transmission instability, and better compatibility for mt8189.
> >
> > Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
>
> Should this have a fixes/stable tag?
>
> Kind regards
> Uffe
Thank you for your review, I will fix it in next version.
Thanks,
Cathy
>
> > ---
> > drivers/mmc/host/mtk-sd.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> > index 302ac8529c4f..b2680cc054bd 100644
> > --- a/drivers/mmc/host/mtk-sd.c
> > +++ b/drivers/mmc/host/mtk-sd.c
> > @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible
> > mt8189_compat = {
> > .needs_top_base = true,
> > .pad_tune_reg = MSDC_PAD_TUNE0,
> > .async_fifo = true,
> > - .data_tune = true,
> > + .data_tune = false,
> > .busy_check = true,
> > .stop_clk_fix = true,
> > - .stop_dly_sel = 1,
> > - .pop_en_cnt = 2,
> > + .stop_dly_sel = 3,
> > + .pop_en_cnt = 8,
> > .enhance_rx = true,
> > .support_64g = true,
> > - .support_new_tx = true,
> > - .support_new_rx = true,
> > + .support_new_tx = false,
> > + .support_new_rx = false,
> > .support_spm_res_release = true,
> > };
> >
> > --
> > 2.45.2
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189
2026-02-04 2:06 [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189 Cathy Xu
2026-02-04 14:35 ` Ulf Hansson
@ 2026-02-05 11:47 ` AngeloGioacchino Del Regno
2026-03-09 7:32 ` Cathy Xu (许华婷)
2026-02-20 17:23 ` Louis-Alexis Eyraud
2 siblings, 1 reply; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-02-05 11:47 UTC (permalink / raw)
To: Cathy Xu, Chaotian Jing, Ulf Hansson, Matthias Brugger
Cc: linux-mmc, linux-kernel, linux-arm-kernel, linux-mediatek,
Mengqi Zhang, Wenbin Mei, Andy-ld Lu, Yong Mao
Il 04/02/26 03:06, Cathy Xu ha scritto:
> Disable new_tx/rx and modify related settings helps avoid data
> transmission instability, and better compatibility for mt8189.
>
> Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
Needs a fixes tag. Please add the relevant one and resend.
Thanks,
Angelo
> ---
> drivers/mmc/host/mtk-sd.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 302ac8529c4f..b2680cc054bd 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible mt8189_compat = {
> .needs_top_base = true,
> .pad_tune_reg = MSDC_PAD_TUNE0,
> .async_fifo = true,
> - .data_tune = true,
> + .data_tune = false,
> .busy_check = true,
> .stop_clk_fix = true,
> - .stop_dly_sel = 1,
> - .pop_en_cnt = 2,
> + .stop_dly_sel = 3,
> + .pop_en_cnt = 8,
> .enhance_rx = true,
> .support_64g = true,
> - .support_new_tx = true,
> - .support_new_rx = true,
> + .support_new_tx = false,
> + .support_new_rx = false,
> .support_spm_res_release = true,
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189
2026-02-05 11:47 ` AngeloGioacchino Del Regno
@ 2026-03-09 7:32 ` Cathy Xu (许华婷)
0 siblings, 0 replies; 6+ messages in thread
From: Cathy Xu (许华婷) @ 2026-03-09 7:32 UTC (permalink / raw)
To: ulf.hansson@linaro.org, matthias.bgg@gmail.com,
AngeloGioacchino Del Regno,
Chaotian Jing (井朝天)
Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-mmc@vger.kernel.org, Andy-ld Lu (卢东),
Wenbin Mei (梅文彬),
Yong Mao (毛勇),
Mengqi Zhang (张梦琦),
linux-arm-kernel@lists.infradead.org
On Thu, 2026-02-05 at 12:47 +0100, AngeloGioacchino Del Regno wrote:
> Il 04/02/26 03:06, Cathy Xu ha scritto:
> > Disable new_tx/rx and modify related settings helps avoid data
> > transmission instability, and better compatibility for mt8189.
> >
> > Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
>
> Needs a fixes tag. Please add the relevant one and resend.
>
> Thanks,
> Angelo
Thank you for your review, I will add it in next.
Thanks,
Cathy
>
> > ---
> > drivers/mmc/host/mtk-sd.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> > index 302ac8529c4f..b2680cc054bd 100644
> > --- a/drivers/mmc/host/mtk-sd.c
> > +++ b/drivers/mmc/host/mtk-sd.c
> > @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible
> > mt8189_compat = {
> > .needs_top_base = true,
> > .pad_tune_reg = MSDC_PAD_TUNE0,
> > .async_fifo = true,
> > - .data_tune = true,
> > + .data_tune = false,
> > .busy_check = true,
> > .stop_clk_fix = true,
> > - .stop_dly_sel = 1,
> > - .pop_en_cnt = 2,
> > + .stop_dly_sel = 3,
> > + .pop_en_cnt = 8,
> > .enhance_rx = true,
> > .support_64g = true,
> > - .support_new_tx = true,
> > - .support_new_rx = true,
> > + .support_new_tx = false,
> > + .support_new_rx = false,
> > .support_spm_res_release = true,
> > };
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189
2026-02-04 2:06 [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189 Cathy Xu
2026-02-04 14:35 ` Ulf Hansson
2026-02-05 11:47 ` AngeloGioacchino Del Regno
@ 2026-02-20 17:23 ` Louis-Alexis Eyraud
2 siblings, 0 replies; 6+ messages in thread
From: Louis-Alexis Eyraud @ 2026-02-20 17:23 UTC (permalink / raw)
To: Cathy Xu, Chaotian Jing, Ulf Hansson, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: linux-mmc, linux-kernel, linux-arm-kernel, linux-mediatek,
Mengqi Zhang, Wenbin Mei, Andy-ld Lu, Yong Mao
Hi,
On Wed, 2026-02-04 at 10:06 +0800, Cathy Xu wrote:
> Disable new_tx/rx and modify related settings helps avoid data
> transmission instability, and better compatibility for mt8189.
>
> Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
> ---
> drivers/mmc/host/mtk-sd.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 302ac8529c4f..b2680cc054bd 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible
> mt8189_compat = {
> .needs_top_base = true,
> .pad_tune_reg = MSDC_PAD_TUNE0,
> .async_fifo = true,
> - .data_tune = true,
> + .data_tune = false,
> .busy_check = true,
> .stop_clk_fix = true,
> - .stop_dly_sel = 1,
> - .pop_en_cnt = 2,
> + .stop_dly_sel = 3,
> + .pop_en_cnt = 8,
> .enhance_rx = true,
> .support_64g = true,
> - .support_new_tx = true,
> - .support_new_rx = true,
> + .support_new_tx = false,
> + .support_new_rx = false,
> .support_spm_res_release = true,
> };
>
I've tested this patch on Genio 720-EVK board that uses MT8391 SoC, a
MT8189 variant.
I did not get issue with these new settings when using this board eMMC
(MSDC0) or microsd (MSDC1). I did not observe issues with previous
settings but as it does not seem to cause regressions,
Tested-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Regards,
Louis-Alexis
^ permalink raw reply [flat|nested] 6+ messages in thread