From: "Petar Jovanovic" <petar.jovanovic@rt-rk.com>
To: "'Petar Jovanovic'" <Petar.Jovanovic@imgtec.com>,
"'David Daney'" <ddaney@caviumnetworks.com>,
"'Maciej Rozycki'" <Maciej.Rozycki@imgtec.com>,
<ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>, <david.daney@cavium.com>
Subject: RE: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and mips64r1
Date: Thu, 14 Sep 2017 18:41:34 +0200 [thread overview]
Message-ID: <000001d32d78$539cb260$fad61720$@rt-rk.com> (raw)
In-Reply-To: <56EA75BA695AE044ACFB41322F6D2BF4013D06C0AF@BADAG02.ba.imgtec.org>
ping
-----Original Message-----
From: Petar Jovanovic [mailto:Petar.Jovanovic@imgtec.com]
Sent: Monday, August 7, 2017 7:00 PM
To: David Daney <ddaney@caviumnetworks.com>; Maciej Rozycki
<Maciej.Rozycki@imgtec.com>; Petar Jovanovic <petar.jovanovic@rt-rk.com>;
ralf@linux-mips.org
Cc: linux-mips@linux-mips.org; david.daney@cavium.com
Subject: RE: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and
mips64r1
________________________________________
From: David Daney [ddaney@caviumnetworks.com]
Sent: Friday, July 07, 2017 6:19 PM
To: Maciej Rozycki; Petar Jovanovic; ralf@linux-mips.org
Cc: Petar Jovanovic; linux-mips@linux-mips.org; david.daney@cavium.com
Subject: Re: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and
mips64r1
On 07/07/2017 08:04 AM, Maciej W. Rozycki wrote:
> On Fri, 7 Jul 2017, Petar Jovanovic wrote:
>
>> As I said earlier in the thread, "in the current ToT, I have not seen
>> where this change would affect apart from show_cpuinfo()"[1]. So, if
>> someone implements Octeon-specific controls, where this should be used?
>
> Right, `egrep -r 'cpu_has_(mips_r1|mips32r1|mips64r1|mips32r2)'
arch/mips'
> does not show anything else indeed. Please make it unambiguous in the
> patch description then, i.e. that there is no functional change beyond
> reporting in `show_cpuinfo'.
>
>> I am not aware of the places where Octeon (ab)uses it in the current
>> kernel code. David says he "cannot recall exactly what the issues
>> were" [2].
>
> In my recent review of the code while working the the eBPF JIT, I
> tried to audit the use of cpu_has_* as it relates to OCTEON. My
> current thoughts are that there is no reason not to merge Petar's patch.
> Ralf, please add ...
> Acked-by: David Daney <david.daney@cavium.com>
> Sorry for the pain here.
Ralf?
Regards,
Petar
=
WARNING: multiple messages have this Message-ID (diff)
From: "Petar Jovanovic" <petar.jovanovic@rt-rk.com>
To: 'Petar Jovanovic' <Petar.Jovanovic@imgtec.com>,
'David Daney' <ddaney@caviumnetworks.com>,
'Maciej Rozycki' <Maciej.Rozycki@imgtec.com>,
ralf@linux-mips.org
Cc: linux-mips@linux-mips.org, david.daney@cavium.com
Subject: RE: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and mips64r1
Date: Thu, 14 Sep 2017 18:41:34 +0200 [thread overview]
Message-ID: <000001d32d78$539cb260$fad61720$@rt-rk.com> (raw)
Message-ID: <20170914164134.qKvX1c3MubYTDDo8zItFqXwt90w96Nj8dcwUMfS6Kgc@z> (raw)
In-Reply-To: <56EA75BA695AE044ACFB41322F6D2BF4013D06C0AF@BADAG02.ba.imgtec.org>
ping
-----Original Message-----
From: Petar Jovanovic [mailto:Petar.Jovanovic@imgtec.com]
Sent: Monday, August 7, 2017 7:00 PM
To: David Daney <ddaney@caviumnetworks.com>; Maciej Rozycki
<Maciej.Rozycki@imgtec.com>; Petar Jovanovic <petar.jovanovic@rt-rk.com>;
ralf@linux-mips.org
Cc: linux-mips@linux-mips.org; david.daney@cavium.com
Subject: RE: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and
mips64r1
________________________________________
From: David Daney [ddaney@caviumnetworks.com]
Sent: Friday, July 07, 2017 6:19 PM
To: Maciej Rozycki; Petar Jovanovic; ralf@linux-mips.org
Cc: Petar Jovanovic; linux-mips@linux-mips.org; david.daney@cavium.com
Subject: Re: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and
mips64r1
On 07/07/2017 08:04 AM, Maciej W. Rozycki wrote:
> On Fri, 7 Jul 2017, Petar Jovanovic wrote:
>
>> As I said earlier in the thread, "in the current ToT, I have not seen
>> where this change would affect apart from show_cpuinfo()"[1]. So, if
>> someone implements Octeon-specific controls, where this should be used?
>
> Right, `egrep -r 'cpu_has_(mips_r1|mips32r1|mips64r1|mips32r2)'
arch/mips'
> does not show anything else indeed. Please make it unambiguous in the
> patch description then, i.e. that there is no functional change beyond
> reporting in `show_cpuinfo'.
>
>> I am not aware of the places where Octeon (ab)uses it in the current
>> kernel code. David says he "cannot recall exactly what the issues
>> were" [2].
>
> In my recent review of the code while working the the eBPF JIT, I
> tried to audit the use of cpu_has_* as it relates to OCTEON. My
> current thoughts are that there is no reason not to merge Petar's patch.
> Ralf, please add ...
> Acked-by: David Daney <david.daney@cavium.com>
> Sorry for the pain here.
Ralf?
Regards,
Petar
=
next prev parent reply other threads:[~2017-09-14 16:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 17:59 [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and mips64r1 Petar Jovanovic
2017-04-05 16:01 ` Petar Jovanovic
2017-04-05 16:01 ` Petar Jovanovic
2017-04-25 17:24 ` Petar Jovanovic
2017-05-08 15:25 ` Petar Jovanovic
2017-05-08 15:25 ` Petar Jovanovic
2017-05-15 11:33 ` Petar Jovanovic
2017-05-21 1:37 ` Maciej W. Rozycki
2017-05-22 16:25 ` David Daney
2017-05-22 16:43 ` Petar Jovanovic
2017-05-22 16:43 ` Petar Jovanovic
2017-05-22 17:52 ` Maciej W. Rozycki
2017-06-16 13:26 ` Petar Jovanovic
2017-06-16 13:26 ` Petar Jovanovic
2017-07-06 16:17 ` Petar Jovanovic
2017-07-06 20:47 ` Maciej W. Rozycki
2017-07-07 11:37 ` Petar Jovanovic
2017-07-07 11:37 ` Petar Jovanovic
2017-07-07 15:04 ` Maciej W. Rozycki
2017-07-07 15:04 ` Maciej W. Rozycki
2017-07-07 16:19 ` David Daney
2017-08-07 16:59 ` Petar Jovanovic
2017-09-14 16:41 ` Petar Jovanovic [this message]
2017-09-14 16:41 ` Petar Jovanovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d32d78$539cb260$fad61720$@rt-rk.com' \
--to=petar.jovanovic@rt-rk.com \
--cc=Maciej.Rozycki@imgtec.com \
--cc=Petar.Jovanovic@imgtec.com \
--cc=david.daney@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox