Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: "Petar Jovanovic" <petar.jovanovic@rt-rk.com>
To: "'David Daney'" <ddaney@caviumnetworks.com>,
	"'Maciej W. Rozycki'" <macro@imgtec.com>,
	"'Petar Jovanovic'" <Petar.Jovanovic@imgtec.com>
Cc: <linux-mips@linux-mips.org>, <ralf@linux-mips.org>,
	<david.daney@cavium.com>
Subject: RE: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and mips64r1
Date: Mon, 22 May 2017 18:43:39 +0200	[thread overview]
Message-ID: <003601d2d31a$90c22a20$b2467e60$@rt-rk.com> (raw)
In-Reply-To: <22c5e59d-fb87-9dbf-1285-2a5ff3b62497@caviumnetworks.com>

-----Original Message-----
From: David Daney [mailto:ddaney@caviumnetworks.com] 
Sent: Monday, May 22, 2017 6:26 PM
To: Maciej W. Rozycki <macro@imgtec.com>; Petar Jovanovic <Petar.Jovanovic@imgtec.com>
Cc: Petar Jovanovic <petar.jovanovic@rt-rk.com>; linux-mips@linux-mips.org; ralf@linux-mips.org; david.daney@cavium.com
Subject: Re: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and mips64r1

On 05/20/2017 06:37 PM, Maciej W. Rozycki wrote:
>>   I suspect it will affect more than just `show_cpuinfo', e.g. some inline
>> asm, and you could have included a justification as to why this patch is
>> correct, such as by referring to how `set_isa' sets flags in `isa_level'.

> That is correct, and exactly what I said in my reply to the patch when 
> it was posted.  When the OCTEON code was merged, different code paths 
> were taken in the kernel, and there was a deliberate decision to 
> structure mach-cavium-octeon/cpu-feature-overrides.h the way we did it.

In the current ToT, I have not seen where this change would affect apart
from show_cpuinfo(). I understood from your words it was different at the
time when the original patch was added.

Petar

WARNING: multiple messages have this Message-ID (diff)
From: "Petar Jovanovic" <petar.jovanovic@rt-rk.com>
To: 'David Daney' <ddaney@caviumnetworks.com>,
	"'Maciej W. Rozycki'" <macro@imgtec.com>,
	'Petar Jovanovic' <Petar.Jovanovic@imgtec.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, david.daney@cavium.com
Subject: RE: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and mips64r1
Date: Mon, 22 May 2017 18:43:39 +0200	[thread overview]
Message-ID: <003601d2d31a$90c22a20$b2467e60$@rt-rk.com> (raw)
Message-ID: <20170522164339.kcERvUihK8p-QCyPOE-JA2HemvlY-CES7qaLzMvrb28@z> (raw)
In-Reply-To: <22c5e59d-fb87-9dbf-1285-2a5ff3b62497@caviumnetworks.com>

-----Original Message-----
From: David Daney [mailto:ddaney@caviumnetworks.com] 
Sent: Monday, May 22, 2017 6:26 PM
To: Maciej W. Rozycki <macro@imgtec.com>; Petar Jovanovic <Petar.Jovanovic@imgtec.com>
Cc: Petar Jovanovic <petar.jovanovic@rt-rk.com>; linux-mips@linux-mips.org; ralf@linux-mips.org; david.daney@cavium.com
Subject: Re: [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and mips64r1

On 05/20/2017 06:37 PM, Maciej W. Rozycki wrote:
>>   I suspect it will affect more than just `show_cpuinfo', e.g. some inline
>> asm, and you could have included a justification as to why this patch is
>> correct, such as by referring to how `set_isa' sets flags in `isa_level'.

> That is correct, and exactly what I said in my reply to the patch when 
> it was posted.  When the OCTEON code was merged, different code paths 
> were taken in the kernel, and there was a deliberate decision to 
> structure mach-cavium-octeon/cpu-feature-overrides.h the way we did it.

In the current ToT, I have not seen where this change would affect apart
from show_cpuinfo(). I understood from your words it was different at the
time when the original patch was added.

Petar

  reply	other threads:[~2017-05-22 16:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15 17:59 [PATCH] MIPS: Octeon: Expose support for mips32r1, mips32r2 and mips64r1 Petar Jovanovic
2017-04-05 16:01 ` Petar Jovanovic
2017-04-05 16:01   ` Petar Jovanovic
2017-04-25 17:24   ` Petar Jovanovic
2017-05-08 15:25     ` Petar Jovanovic
2017-05-08 15:25       ` Petar Jovanovic
2017-05-15 11:33       ` Petar Jovanovic
2017-05-21  1:37         ` Maciej W. Rozycki
2017-05-22 16:25           ` David Daney
2017-05-22 16:43             ` Petar Jovanovic [this message]
2017-05-22 16:43               ` Petar Jovanovic
2017-05-22 17:52             ` Maciej W. Rozycki
2017-06-16 13:26               ` Petar Jovanovic
2017-06-16 13:26                 ` Petar Jovanovic
2017-07-06 16:17                 ` Petar Jovanovic
2017-07-06 20:47                   ` Maciej W. Rozycki
2017-07-07 11:37                     ` Petar Jovanovic
2017-07-07 11:37                       ` Petar Jovanovic
2017-07-07 15:04                       ` Maciej W. Rozycki
2017-07-07 15:04                         ` Maciej W. Rozycki
2017-07-07 16:19                         ` David Daney
2017-08-07 16:59                           ` Petar Jovanovic
2017-09-14 16:41                             ` Petar Jovanovic
2017-09-14 16:41                               ` Petar Jovanovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003601d2d31a$90c22a20$b2467e60$@rt-rk.com' \
    --to=petar.jovanovic@rt-rk.com \
    --cc=Petar.Jovanovic@imgtec.com \
    --cc=david.daney@cavium.com \
    --cc=ddaney@caviumnetworks.com \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@imgtec.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox