* 2.4.4-pre5 drivers/sgi/char/Makefile
@ 2001-04-23 22:58 Keith Owens
2001-04-24 14:58 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Keith Owens @ 2001-04-23 22:58 UTC (permalink / raw)
To: linux-mips
I am trying to make sense of drivers/sgi/char/Makefile in 2.4.4-pre5.
export-objs := newport.o shmiq.o sgicons.o usema.o
obj-y := newport.o shmiq.o sgicons.o usema.o streamable.o
obj-$(CONFIG_SGI_SERIAL) += sgiserial.o
obj-$(CONFIG_SGI_DS1286) += ds1286.o
obj-$(CONFIG_SGI_NEWPORT_GFX) += graphics.o rrm.o
None of newport.o shmiq.o sgicons.o usema.o export any symbols so why
are they defined as export-objs? The only object that does export
symbols is graphics_syms.c and no Makefile refers to that source, it
appears to be dead.
I recommend removing all export-objs from drivers/sgi/char/Makefile and
deleting drivers/sgi/char/graphics_syms.c.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.4.4-pre5 drivers/sgi/char/Makefile
2001-04-23 22:58 2.4.4-pre5 drivers/sgi/char/Makefile Keith Owens
@ 2001-04-24 14:58 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2001-04-24 14:58 UTC (permalink / raw)
To: Keith Owens; +Cc: linux-mips
On Tue, Apr 24, 2001 at 08:58:32AM +1000, Keith Owens wrote:
> I am trying to make sense of drivers/sgi/char/Makefile in 2.4.4-pre5.
>
> export-objs := newport.o shmiq.o sgicons.o usema.o
> obj-y := newport.o shmiq.o sgicons.o usema.o streamable.o
>
> obj-$(CONFIG_SGI_SERIAL) += sgiserial.o
> obj-$(CONFIG_SGI_DS1286) += ds1286.o
> obj-$(CONFIG_SGI_NEWPORT_GFX) += graphics.o rrm.o
>
> None of newport.o shmiq.o sgicons.o usema.o export any symbols so why
> are they defined as export-objs? The only object that does export
> symbols is graphics_syms.c and no Makefile refers to that source, it
> appears to be dead.
>
> I recommend removing all export-objs from drivers/sgi/char/Makefile and
> deleting drivers/sgi/char/graphics_syms.c.
The real fix is one of many patches pending to be merged with Linus ...
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-04-24 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-04-23 22:58 2.4.4-pre5 drivers/sgi/char/Makefile Keith Owens
2001-04-24 14:58 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox