From: Ralf Baechle <ralf@oss.sgi.com>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: linux-mips@fnet.fr, linux-mips@oss.sgi.com
Subject: Re: [patch] linux: cpu_probe(): remove 32-bit CPU bits for MIPS64
Date: Tue, 23 Jul 2002 14:14:07 +0200 [thread overview]
Message-ID: <20020723141407.B10566@dea.linux-mips.net> (raw)
In-Reply-To: <Pine.GSO.3.96.1020722222909.2373P-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Tue, Jul 23, 2002 at 01:55:13PM +0200
On Tue, Jul 23, 2002 at 01:55:13PM +0200, Maciej W. Rozycki wrote:
> There is no need to carry support for pure 32-bit CPUs around in
> cpu_probe() in arch/mips64/kernel/setup.c, since such CPUs are not
> supported by the port and likely won't ever reach that code due to a
> reserved instruction exception earlier. The code is misleading and a
> possible cause of troubles, e.g. the 2.4 branch doesn't link now because
> of an unresolved reference to cpu_has_fpu() which is only needed for
> R2000/R3000.
>
> The following patch removes the code for 2.4. For the trunk
> cpu_has_fpu() would be removed as well. Any objections?
I intentionally have that 32-bit stuff in the 64-bit kernel so we can simply
have share identical CPU probing code between the 32-bit and 64-bit kernels.
This in anticipation of a further unification of the two ports which still
duplicate plenty of code with just minor changes.
To make sharing easier I suggest to move all the CPU probing code into it's
own file, probe.c or so?
Ralf
next prev parent reply other threads:[~2002-07-23 12:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-23 11:55 [patch] linux: cpu_probe(): remove 32-bit CPU bits for MIPS64 Maciej W. Rozycki
2002-07-23 12:14 ` Ralf Baechle [this message]
2002-07-23 13:05 ` Maciej W. Rozycki
2002-07-23 13:23 ` Ralf Baechle
2002-07-23 13:31 ` Maciej W. Rozycki
2002-07-23 13:59 ` Ralf Baechle
2002-07-23 18:20 ` Jun Sun
2002-07-24 15:11 ` Maciej W. Rozycki
2002-07-23 14:38 ` Kevin D. Kissell
2002-07-23 14:38 ` Kevin D. Kissell
2002-07-23 14:49 ` Ralf Baechle
2002-07-23 16:00 ` Maciej W. Rozycki
2002-07-23 21:13 ` Kevin D. Kissell
2002-07-24 14:52 ` Ralf Baechle
2002-07-24 15:05 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020723141407.B10566@dea.linux-mips.net \
--to=ralf@oss.sgi.com \
--cc=linux-mips@fnet.fr \
--cc=linux-mips@oss.sgi.com \
--cc=macro@ds2.pg.gda.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox