From: Ralf Baechle <ralf@oss.sgi.com>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: linux-mips@fnet.fr, linux-mips@oss.sgi.com
Subject: Re: [patch] linux: cpu_probe(): remove 32-bit CPU bits for MIPS64
Date: Tue, 23 Jul 2002 15:59:35 +0200 [thread overview]
Message-ID: <20020723155935.A22195@dea.linux-mips.net> (raw)
In-Reply-To: <Pine.GSO.3.96.1020723152521.26569C-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Tue, Jul 23, 2002 at 03:31:30PM +0200
On Tue, Jul 23, 2002 at 03:31:30PM +0200, Maciej W. Rozycki wrote:
> > You've been a little bit too fast :) I've almost implemented my suggestion
> > of moving the probing code into cpu-probe.c.
>
> What's the problem? Now the branch and the trunk are in sync (I just did
> a `cp' from the trunk as the missing function was the only difference), so
> you may apply the same changes to both. :-) Otherwise you'd have to deal
> with the difference.
No real toy, just a merge conflict. Doing this cleanup I also noticed that
the 2.4 and 2.5 cpu probing code is out of sync, so I took care of that
as well. Any future clean and fix should new be easier as the merge between
32-bit and 64-bit, 2.4 and 2.5 can simply be done using cp. Modern
technology rules :)
> > > That might be a good idea in principle, but it won't solve the problem
> > > anyway. I'd like to see the code for 32-bit processors get annihilated by
> > > the compiler if built for mips64. I'll look at it soon. The MIPS32/64
> > > crap needs to be fixed here as well.
> >
> > If you find a nice way of implementing this I certainly won't object.
>
> The MIPS32/64 fix is obvious; the 32-bit CPU is not so, but I have a sort
> of an idea. I'd like to get rid of all ifdefs in the area. Not a high
> priority, though, sorry.
I was refering to the less obvious part, obviously ;-)
Ralf
next prev parent reply other threads:[~2002-07-23 13:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-23 11:55 [patch] linux: cpu_probe(): remove 32-bit CPU bits for MIPS64 Maciej W. Rozycki
2002-07-23 12:14 ` Ralf Baechle
2002-07-23 13:05 ` Maciej W. Rozycki
2002-07-23 13:23 ` Ralf Baechle
2002-07-23 13:31 ` Maciej W. Rozycki
2002-07-23 13:59 ` Ralf Baechle [this message]
2002-07-23 18:20 ` Jun Sun
2002-07-24 15:11 ` Maciej W. Rozycki
2002-07-23 14:38 ` Kevin D. Kissell
2002-07-23 14:38 ` Kevin D. Kissell
2002-07-23 14:49 ` Ralf Baechle
2002-07-23 16:00 ` Maciej W. Rozycki
2002-07-23 21:13 ` Kevin D. Kissell
2002-07-24 14:52 ` Ralf Baechle
2002-07-24 15:05 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020723155935.A22195@dea.linux-mips.net \
--to=ralf@oss.sgi.com \
--cc=linux-mips@fnet.fr \
--cc=linux-mips@oss.sgi.com \
--cc=macro@ds2.pg.gda.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox