Re: [patch] linux: cpu_probe(): remove 32-bit CPU bits for MIPS64

[Ralf Baechle <ralf@oss.sgi.com>]

On Tue, Jul 23, 2002 at 03:05:47PM +0200, Maciej W. Rozycki wrote:

> > I intentionally have that 32-bit stuff in the 64-bit kernel so we can simply
> > have share identical CPU probing code between the 32-bit and 64-bit kernels.
> > This in anticipation of a further unification of the two ports which still
> > duplicate plenty of code with just minor changes.
> 
>  I suspected a maintability reason.

Right

> Thus as a temporary fix I'm checking in a version that provides the
> missing cpu_has_fpu() function (a copy from the trunk).

You've been a little bit too fast :) I've almost implemented my suggestion
of moving the probing code into cpu-probe.c.

> > To make sharing easier I suggest to move all the CPU probing code into it's
> > own file, probe.c or so?
> 
>  That might be a good idea in principle, but it won't solve the problem
> anyway.  I'd like to see the code for 32-bit processors get annihilated by
> the compiler if built for mips64.  I'll look at it soon.  The MIPS32/64
> crap needs to be fixed here as well.

If you find a nice way of implementing this I certainly won't object.

  Ralf