* [PATCH 2.6] fix mips atomic_lock declaration
@ 2004-09-13 22:33 Peter Buckingham
2004-09-14 0:22 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: Peter Buckingham @ 2004-09-13 22:33 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
Hi Ralf,
I modified the declaration of atomic_lock to be static. This means that
I can now build and run SMP on the 1250. See attached patch.
peter
Signed-off-by: Peter Buckingham <peter@pantasys.com>
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 574 bytes --]
? include/asm-mips/.atomic.h.swp
? include/asm-mips/agp.h
Index: include/asm-mips/atomic.h
===================================================================
RCS file: /home/cvs/linux/include/asm-mips/atomic.h,v
retrieving revision 1.36
diff -u -r1.36 atomic.h
--- include/asm-mips/atomic.h 19 Aug 2004 09:54:23 -0000 1.36
+++ include/asm-mips/atomic.h 13 Sep 2004 21:51:56 -0000
@@ -26,7 +26,7 @@
#include <asm/cpu-features.h>
#include <asm/war.h>
-extern spinlock_t atomic_lock;
+static spinlock_t atomic_lock;
typedef struct { volatile int counter; } atomic_t;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2.6] fix mips atomic_lock declaration
2004-09-13 22:33 [PATCH 2.6] fix mips atomic_lock declaration Peter Buckingham
@ 2004-09-14 0:22 ` Ralf Baechle
2004-09-14 0:24 ` Peter Buckingham
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2004-09-14 0:22 UTC (permalink / raw)
To: Peter Buckingham; +Cc: linux-mips
On Mon, Sep 13, 2004 at 03:33:09PM -0700, Peter Buckingham wrote:
> diff -u -r1.36 atomic.h
> --- include/asm-mips/atomic.h 19 Aug 2004 09:54:23 -0000 1.36
> +++ include/asm-mips/atomic.h 13 Sep 2004 21:51:56 -0000
> @@ -26,7 +26,7 @@
> #include <asm/cpu-features.h>
> #include <asm/war.h>
>
> -extern spinlock_t atomic_lock;
> +static spinlock_t atomic_lock;
>
> typedef struct { volatile int counter; } atomic_t;
No. atomic_lock is intentionally undefined, so this patch seems very
broken.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2.6] fix mips atomic_lock declaration
2004-09-14 0:22 ` Ralf Baechle
@ 2004-09-14 0:24 ` Peter Buckingham
0 siblings, 0 replies; 3+ messages in thread
From: Peter Buckingham @ 2004-09-14 0:24 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
Ralf Baechle wrote:
> No. atomic_lock is intentionally undefined, so this patch seems very
> broken.
if i don't change it to static it won't compile correctly. so obviously
i don't get something.
it seems that the bcm1250 needs atomic_lock to be defined for the fall
through case for smp. either that or i need to figure out how to write
the assemble code for the SB1 case...
what do you think needs to be done?
peter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-09-14 0:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-13 22:33 [PATCH 2.6] fix mips atomic_lock declaration Peter Buckingham
2004-09-14 0:22 ` Ralf Baechle
2004-09-14 0:24 ` Peter Buckingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox