From: Ralf Baechle <ralf@linux-mips.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bjoern Riemer <riemer@fokus.fraunhofer.de>,
ppopov@embeddedalley.com,
Linux/MIPS Development <linux-mips@linux-mips.org>
Subject: Re: meshcube patch for au1000 network driver
Date: Thu, 14 Oct 2004 22:13:44 +0200 [thread overview]
Message-ID: <20041014201344.GD5975@linux-mips.org> (raw)
In-Reply-To: <Pine.GSO.4.61.0410131314040.2571@waterleaf.sonytel.be>
On Wed, Oct 13, 2004 at 01:14:22PM +0200, Geert Uytterhoeven wrote:
> On Wed, 13 Oct 2004, Ralf Baechle wrote:
> > On Tue, Oct 12, 2004 at 01:49:45PM +0200, Bjoern Riemer wrote:
> > > i fixed the ioctl support in the net driver to support link detection by
> > > ifplugd ond maybe netplugd(not tested)
> > > here my patch for
> > > drivers/net/au1000.c
> >
> > Please never ever send ed-style patches, only unified (-u). They're
> > totally unreadable and have several technical problems. And preferbly
> > inline, not attachment.
>
> And `-p' helps as wel...
True, it makes patches more readable but there seems to be some trouble
with -p and cvs diff and I certaily don't consider the non-use any kind
of reason for rejecting a patch.
Ralf
prev parent reply other threads:[~2004-10-14 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-12 11:49 meshcube patch for au1000 network driver Bjoern Riemer
2004-10-13 11:09 ` Ralf Baechle
2004-10-13 11:14 ` Geert Uytterhoeven
2004-10-14 20:13 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041014201344.GD5975@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=geert@linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=ppopov@embeddedalley.com \
--cc=riemer@fokus.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox