* meshcube patch for au1000 network driver
@ 2004-10-12 11:49 Bjoern Riemer
2004-10-13 11:09 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Bjoern Riemer @ 2004-10-12 11:49 UTC (permalink / raw)
To: ppopov, linux-mips
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
hi
i fixed the ioctl support in the net driver to support link detection by
ifplugd ond maybe netplugd(not tested)
here my patch for
drivers/net/au1000.c
bjoern riemer
[-- Attachment #2: au1000.c.patch --]
[-- Type: text/x-patch, Size: 1620 bytes --]
9,11c9
< * Bjoern Riemer 2004
< * riemer@fokus.fraunhofer.de or riemer@riemer-nt.de
< * // fixed the link beat detection with ioctls (SIOCGMIIPHY)
---
> *
120c118
< "au1000eth.c:1.5 ppopov@mvista.com\n";
---
> "au1000eth.c:1.4 ppopov@mvista.com\n";
1388,1391d1385
< /*riemer: fix for startup without cable */
< if (!link)
< dev->flags &= ~IFF_RUNNING;
<
1448d1441
<
1846,1856c1839
< /*
< // This structure is used in all SIOCxMIIxxx ioctl calls
< struct mii_ioctl_data {
< 0 u16 phy_id;
< 1 u16 reg_num;
< 2 u16 val_in;
< 3 u16 val_out;
< };*/
< u16 *data = (u16 *)&rq->ifr_data;
< struct au1000_private *aup = (struct au1000_private *) dev->priv;
< //struct mii_ioctl_data *data = (struct mii_ioctl_data *) & rq->ifr_data;
---
> //u16 *data = (u16 *)&rq->ifr_data;
1859d1841
<
1862,1865c1844
< case SIOCGMIIPHY:
< if (!netif_running(dev))
< return -EINVAL;
< data[0] = aup->phy_addr;
---
> //data[0] = PHY_ADDRESS;
1867,1870c1846,1847
< case SIOCGMIIREG:
< data[3] = mdio_read(dev, data[0], data[1]);
< //data->val_out = mdio_read(dev,data->phy_id,data->reg_num);
< return 0;
---
> //data[3] = mdio_read(ioaddr, data[0], data[1]);
> return 0;
1872,1876c1849,1850
< case SIOCSMIIREG:
< if (!capable(CAP_NET_ADMIN))
< return -EPERM;
< mdio_write(dev, data[0], data[1],data[2]);
< return 0;
---
> //mdio_write(ioaddr, data[0], data[1], data[2]);
> return 0;
1878c1852
< return -EOPNOTSUPP;
---
> return -EOPNOTSUPP;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: meshcube patch for au1000 network driver
2004-10-12 11:49 meshcube patch for au1000 network driver Bjoern Riemer
@ 2004-10-13 11:09 ` Ralf Baechle
2004-10-13 11:14 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Ralf Baechle @ 2004-10-13 11:09 UTC (permalink / raw)
To: Bjoern Riemer; +Cc: ppopov, linux-mips
On Tue, Oct 12, 2004 at 01:49:45PM +0200, Bjoern Riemer wrote:
> hi
> i fixed the ioctl support in the net driver to support link detection by
> ifplugd ond maybe netplugd(not tested)
> here my patch for
> drivers/net/au1000.c
Please never ever send ed-style patches, only unified (-u). They're
totally unreadable and have several technical problems. And preferbly
inline, not attachment.
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: meshcube patch for au1000 network driver
2004-10-13 11:09 ` Ralf Baechle
@ 2004-10-13 11:14 ` Geert Uytterhoeven
2004-10-14 20:13 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2004-10-13 11:14 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Bjoern Riemer, ppopov, Linux/MIPS Development
On Wed, 13 Oct 2004, Ralf Baechle wrote:
> On Tue, Oct 12, 2004 at 01:49:45PM +0200, Bjoern Riemer wrote:
> > i fixed the ioctl support in the net driver to support link detection by
> > ifplugd ond maybe netplugd(not tested)
> > here my patch for
> > drivers/net/au1000.c
>
> Please never ever send ed-style patches, only unified (-u). They're
> totally unreadable and have several technical problems. And preferbly
> inline, not attachment.
And `-p' helps as wel...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: meshcube patch for au1000 network driver
2004-10-13 11:14 ` Geert Uytterhoeven
@ 2004-10-14 20:13 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2004-10-14 20:13 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Bjoern Riemer, ppopov, Linux/MIPS Development
On Wed, Oct 13, 2004 at 01:14:22PM +0200, Geert Uytterhoeven wrote:
> On Wed, 13 Oct 2004, Ralf Baechle wrote:
> > On Tue, Oct 12, 2004 at 01:49:45PM +0200, Bjoern Riemer wrote:
> > > i fixed the ioctl support in the net driver to support link detection by
> > > ifplugd ond maybe netplugd(not tested)
> > > here my patch for
> > > drivers/net/au1000.c
> >
> > Please never ever send ed-style patches, only unified (-u). They're
> > totally unreadable and have several technical problems. And preferbly
> > inline, not attachment.
>
> And `-p' helps as wel...
True, it makes patches more readable but there seems to be some trouble
with -p and cvs diff and I certaily don't consider the non-use any kind
of reason for rejecting a patch.
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-10-14 20:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-12 11:49 meshcube patch for au1000 network driver Bjoern Riemer
2004-10-13 11:09 ` Ralf Baechle
2004-10-13 11:14 ` Geert Uytterhoeven
2004-10-14 20:13 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox