From: Russell King <rmk@arm.linux.org.uk>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Rodolfo Giometti <giometti@linux.it>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] au1x00 serial real interrupt
Date: Sat, 9 Sep 2006 17:39:07 +0100 [thread overview]
Message-ID: <20060909163907.GA24012@flint.arm.linux.org.uk> (raw)
In-Reply-To: <4502ED14.6080506@ru.mvista.com>
On Sat, Sep 09, 2006 at 08:34:28PM +0400, Sergei Shtylyov wrote:
> Well, after looking at drivers/serial/8250.c a bit more, I think this
> may be even more simlified since that driver seems to treat the negative
> values as completely invalid anyway. IOW, we can just:
>
> #define is_real_interrupt(irq) 1
>
> Russel, what do you think?
That's Russell 8)
Well, if you need IRQ0 to be real then redefining is_real_interrupt()
is the correct way forward.
However, Linus' policy is that IRQ0 shall be invalid at least on PCI
systems, and architectures _should_ remap their real IRQ0 to some other
number. Personally I don't like this. Hence why I prefer to give people
the option.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-09-09 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 16:52 [PATCH] au1x00 serial real interrupt Rodolfo Giometti
2006-09-05 15:19 ` Sergei Shtylyov
2006-09-09 16:34 ` Sergei Shtylyov
2006-09-09 16:39 ` Russell King [this message]
2006-09-09 16:58 ` Sergei Shtylyov
2006-09-14 18:10 ` Ralf Baechle
2006-09-18 20:13 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060909163907.GA24012@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=giometti@linux.it \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox