Re: [PATCH] au1x00 serial real interrupt

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Sergei Shtylyov wrote:

>> ------------------------------------------------------------------------
>>
>> diff --git a/include/asm-mips/serial.h b/include/asm-mips/serial.h
>> index 7b23664..0197062 100644
>> --- a/include/asm-mips/serial.h
>> +++ b/include/asm-mips/serial.h
>> @@ -11,6 +11,14 @@
>>  
>>  #include <linux/config.h>
>>  
>> +#ifdef CONFIG_SOC_AU1X00
>> +/*
>> + * We have to redefine "is_real_interrupt()" for Au1x00 CPUs...
>> + */
>> +#undef is_real_interrupt
>> +#define is_real_interrupt(irq)    ((irq) != ~0)
>> +#endif
>> +
>>  /*
>>   * This assumes you have a 1.8432 MHz clock for your UART.
>>   *

>    Ralf, how about this patch? Can it be applied, at least 3 months 
> after posting? Alchemy UART0 uses IRQ0 and 0 is treated as "no IRQ" by 
> drivers/serial/8250.c which says the macro should be redefined in 
> <asm/serial.h> if needed.

    If the values other than 0 need to be filtered out, to be precise...

    Well, after looking at drivers/serial/8250.c a bit more, I think this may 
be even more simlified since that driver seems to treat the negative values as 
completely invalid anyway. IOW, we can just:

#define is_real_interrupt(irq)	1

    Russel, what do you think?

WBR, Sergei