From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Rodolfo Giometti <giometti@linux.it>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] au1x00 serial real interrupt
Date: Tue, 19 Sep 2006 00:13:03 +0400 [thread overview]
Message-ID: <450EFDCF.2020400@ru.mvista.com> (raw)
In-Reply-To: <4502ED14.6080506@ru.mvista.com>
Hello.
Sergei Shtylyov wrote:
>>> diff --git a/include/asm-mips/serial.h b/include/asm-mips/serial.h
>>> index 7b23664..0197062 100644
>>> --- a/include/asm-mips/serial.h
>>> +++ b/include/asm-mips/serial.h
>>> @@ -11,6 +11,14 @@
>>>
>>> #include <linux/config.h>
>>>
>>> +#ifdef CONFIG_SOC_AU1X00
>>> +/*
>>> + * We have to redefine "is_real_interrupt()" for Au1x00 CPUs...
>>> + */
>>> +#undef is_real_interrupt
>>> +#define is_real_interrupt(irq) ((irq) != ~0)
>>> +#endif
>>> +
>>> /*
>>> * This assumes you have a 1.8432 MHz clock for your UART.
>>> *
> Well, after looking at drivers/serial/8250.c a bit more, I think this
> may be even more simlified since that driver seems to treat the negative
> values as completely invalid anyway. IOW, we can just:
> #define is_real_interrupt(irq) 1
Rodolfo, can you do this (possibly adding more elaborate comment about
UART0 using IRQ0)?
WBR, Sergei
prev parent reply other threads:[~2006-09-18 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 16:52 [PATCH] au1x00 serial real interrupt Rodolfo Giometti
2006-09-05 15:19 ` Sergei Shtylyov
2006-09-09 16:34 ` Sergei Shtylyov
2006-09-09 16:39 ` Russell King
2006-09-09 16:58 ` Sergei Shtylyov
2006-09-14 18:10 ` Ralf Baechle
2006-09-18 20:13 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450EFDCF.2020400@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=giometti@linux.it \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox